Josef Bacik 5aa2717b6b btrfs: fix error handling in commit_fs_roots ... [ Upstream commit 4f4317c13a40194940acf4a71670179c4faca2b5 ] While doing error injection I would sometimes get a corrupt file system. This is because I was injecting errors at btrfs_search_slot, but would only do it one time per stack. This uncovered a problem in commit_fs_roots, where if we get an error we would just break. However we're in a nested loop, the first loop being a loop to find all the dirty fs roots, and then subsequent root updates would succeed clearing the error value. This isn't likely to happen in real scenarios, however we could potentially get a random ENOMEM once and then not again, and we'd end up with a corrupted file system. Fix this by moving the error checking around a bit to the main loop, as this is the only place where something will fail, and return the error as soon as it occurs. With this patch my reproducer no longer corrupts the file system. Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-03-07 12:34:13 +01:00
..
tests	btrfs: fix missing delalloc new bit for new delalloc ranges	2020-11-13 22:15:59 +01:00
acl.c
async-thread.c
async-thread.h
backref.c	btrfs: do not warn if we can't find the reloc root when looking up backref	2021-03-04 11:38:29 +01:00
backref.h	btrfs: add asserts for deleting backref cache nodes	2021-03-04 11:38:29 +01:00
block-group.c	btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself	2021-03-04 11:38:30 +01:00
block-group.h
block-rsv.c	btrfs: print the block rsv type when we fail our reservation	2020-11-05 13:02:05 +01:00
block-rsv.h
btrfs_inode.h	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
check-integrity.c
check-integrity.h
compression.c
compression.h
ctree.c	btrfs: fix extent buffer leak on failure to copy root	2021-03-04 11:38:30 +01:00
ctree.h	btrfs: fix backport of 2175bf57dc in 5.10.13	2021-02-23 15:53:25 +01:00
delalloc-space.c
delalloc-space.h
delayed-inode.c
delayed-inode.h
delayed-ref.c	btrfs: account for new extents being deleted in total_bytes_pinned	2021-03-04 11:38:30 +01:00
delayed-ref.h	btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself	2021-03-04 11:38:30 +01:00
dev-replace.c	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
dev-replace.h
dir-item.c
discard.c	btrfs: merge critical sections of discard lock in workfn	2021-01-19 18:27:24 +01:00
discard.h
disk-io.c	btrfs: print the actual offset in btrfs_root_name	2021-01-27 11:55:06 +01:00
disk-io.h	btrfs: add a helper to read the tree_root commit root for backref lookup	2020-10-26 15:04:57 +01:00
export.c
export.h
extent_io.c	btrfs: prevent NULL pointer dereference in extent_io_tree_panic	2021-01-19 18:27:17 +01:00
extent_io.h	btrfs: remove struct extent_io_ops	2020-10-07 12:13:25 +02:00
extent_map.c
extent_map.h
extent-io-tree.h	btrfs: remove struct extent_io_ops	2020-10-07 12:13:25 +02:00
extent-tree.c	btrfs: account for new extents being deleted in total_bytes_pinned	2021-03-04 11:38:30 +01:00
file-item.c
file.c	btrfs: fix missing delalloc new bit for new delalloc ranges	2020-11-13 22:15:59 +01:00
free-space-cache.c	btrfs: clarify error returns values in __load_free_space_cache	2021-03-04 11:37:47 +01:00
free-space-cache.h
free-space-tree.c	btrfs: fix possible free space tree corruption with online conversion	2021-02-03 23:28:40 +01:00
free-space-tree.h
inode-item.c
inode-map.c
inode-map.h
inode.c	btrfs: fix double accounting of ordered extent for subpage case in btrfs_invalidapge	2021-03-04 11:37:48 +01:00
ioctl.c	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
Kconfig
locking.c
locking.h
lzo.c
Makefile
misc.h
ordered-data.c
ordered-data.h
orphan.c
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-27 11:55:06 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-27 11:55:06 +01:00
props.c
props.h
qgroup.c	btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan	2021-01-19 18:27:24 +01:00
qgroup.h
raid56.c
raid56.h
rcu-string.h
reada.c	btrfs: fix readahead hang and use-after-free after removing a device	2020-10-26 15:03:59 +01:00
ref-verify.c	btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod	2020-11-05 13:03:39 +01:00
ref-verify.h
reflink.c	btrfs: fix deadlock when cloning inline extent and low on free metadata space	2021-01-17 14:16:54 +01:00
reflink.h
relocation.c	btrfs: fix reloc root leak with 0 ref reloc roots on recovery	2021-03-04 11:38:30 +01:00
root-tree.c
scrub.c	btrfs: scrub: update message regarding read-only status	2020-11-05 13:02:58 +01:00
send.c	btrfs: send: fix invalid clone operations when cloning from the same file and root	2021-01-27 11:54:53 +01:00
send.h
space-info.c	btrfs: shrink delalloc pages instead of full inodes	2021-01-17 14:16:54 +01:00
space-info.h	btrfs: handle space_info::total_bytes_pinned inside the delayed ref itself	2021-03-04 11:38:30 +01:00
struct-funcs.c
super.c	btrfs: fix transaction leak and crash after RO remount caused by qgroup rescan	2021-01-19 18:27:24 +01:00
sysfs.c
sysfs.h
transaction.c	btrfs: fix error handling in commit_fs_roots	2021-03-07 12:34:13 +01:00
transaction.h
tree-checker.c	btrfs: tree-checker: check if chunk item end overflows	2021-01-19 18:27:22 +01:00
tree-checker.h
tree-defrag.c
tree-log.c	btrfs: skip unnecessary searches for xattrs when logging an inode	2021-01-17 14:16:53 +01:00
tree-log.h
ulist.c
ulist.h
uuid-tree.c
volumes.c	btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch	2021-02-03 23:28:40 +01:00
volumes.h	btrfs: fix lockdep warning due to seqcount_mutex on 32bit arch	2021-02-03 23:28:40 +01:00
xattr.c	btrfs: skip unnecessary searches for xattrs when logging an inode	2021-01-17 14:16:53 +01:00
xattr.h
zlib.c
zstd.c