Josef Bacik 5aa2717b6b btrfs: fix error handling in commit_fs_roots ... [ Upstream commit 4f4317c13a40194940acf4a71670179c4faca2b5 ] While doing error injection I would sometimes get a corrupt file system. This is because I was injecting errors at btrfs_search_slot, but would only do it one time per stack. This uncovered a problem in commit_fs_roots, where if we get an error we would just break. However we're in a nested loop, the first loop being a loop to find all the dirty fs roots, and then subsequent root updates would succeed clearing the error value. This isn't likely to happen in real scenarios, however we could potentially get a random ENOMEM once and then not again, and we'd end up with a corrupted file system. Fix this by moving the error checking around a bit to the main loop, as this is the only place where something will fail, and return the error as soon as it occurs. With this patch my reproducer no longer corrupts the file system. Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-03-07 12:34:13 +01:00
..
9p	fs: 9p: add generic splice_write file operation	2020-12-01 21:40:47 +01:00
adfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
affs	fs/affs: release old buffer head on error path	2021-03-04 11:38:37 +01:00
afs	rxrpc: Fix deadlock around release of dst cached on udp tunnel	2021-02-10 09:29:13 +01:00
autofs
befs
bfs	bfs: don't use WARNING: string when it's just info.	2021-01-06 14:56:52 +01:00
btrfs	btrfs: fix error handling in commit_fs_roots	2021-03-07 12:34:13 +01:00
cachefiles	cachefiles: Drop superfluous readpages aops NULL check	2021-01-27 11:55:22 +01:00
ceph	ceph: fix flush_snap logic after putting caps	2021-03-04 11:38:08 +01:00
cifs	cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.	2021-02-26 10:13:01 +01:00
coda
configfs
cramfs
crypto	fscrypt: add fscrypt_is_nokey_name()	2020-12-26 16:02:43 +01:00
debugfs	debugfs: do not attempt to create a new file before the filesystem is initalized	2021-03-04 11:37:17 +01:00
devpts
dlm
ecryptfs
efivarfs	efivarfs: revert "fix memory leak in efivarfs_create()"	2020-11-25 16:55:02 +01:00
efs
erofs	erofs: fix shift-out-of-bounds of blkszbits	2021-03-07 12:34:05 +01:00
exfat	exfat: fix shift-out-of-bounds in exfat_fill_super()	2021-03-04 11:38:41 +01:00
exportfs
ext2	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
ext4	ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it	2021-03-04 11:38:15 +01:00
f2fs	f2fs: fix to set/clear I_LINKABLE under i_lock	2021-03-07 12:34:12 +01:00
fat
freevxfs
fscache
fuse	fuse: fix bad inode	2021-01-09 13:46:24 +01:00
gfs2	gfs2: Recursive gfs2_quota_hold in gfs2_iomap_end	2021-03-04 11:38:44 +01:00
hfs	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
hfsplus	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
hostfs
hpfs
hugetlbfs	mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page	2021-02-10 09:29:20 +01:00
iomap	iomap: clean up writeback state logic on writepage error	2020-11-04 08:52:46 -08:00
isofs	isofs: release buffer head before return	2021-03-04 11:38:00 +01:00
jbd2	jbd2: fix kernel-doc markups	2020-11-19 22:38:29 -05:00
jffs2	jffs2: fix use after free in jffs2_sum_write_data()	2021-03-04 11:37:51 +01:00
jfs	JFS: more checks for invalid superblock	2021-03-07 12:34:04 +01:00
kernfs	kernfs: wire up ->splice_read and ->splice_write	2021-01-27 11:55:29 +01:00
lockd	lockd: don't use interval-based rebinding over TCP	2020-12-30 11:53:30 +01:00
minix
nfs	NFSv4: Fixes for nfs4_bitmask_adjust()	2021-03-04 11:38:20 +01:00
nfs_common	nfs_common: need lock during iterate through the list	2020-12-30 11:53:45 +01:00
nfsd	nfsd: register pernet ops last, unregister first	2021-03-04 11:38:07 +01:00
nilfs2	nilfs2: make splice write available again	2021-02-13 13:55:16 +01:00
nls
notify	fanotify: Fix sys_fanotify_mark() on native x86-32	2021-01-17 14:16:59 +01:00
ntfs	ntfs: check for valid standard information attribute	2021-02-26 10:13:00 +01:00
ocfs2	ocfs2: fix a use after free on error	2021-03-04 11:38:18 +01:00
omfs
openpromfs
orangefs
overlayfs	ovl: expand warning in ovl_d_real()	2021-02-17 11:02:30 +01:00
proc	proc: don't allow async path resolution of /proc/thread-self components	2021-03-04 11:38:42 +01:00
pstore	pstore: Fix typo in compression option name	2021-03-04 11:38:33 +01:00
qnx4
qnx6
quota	quota: Fix memory leak when handling corrupted quota file	2021-03-04 11:37:53 +01:00
ramfs
reiserfs	reiserfs: add check for an invalid ih_entry_count	2021-01-06 14:56:52 +01:00
romfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
squashfs	squashfs: add more sanity checks in xattr id lookup	2021-02-13 13:55:19 +01:00
sysfs
sysv
tracefs
ubifs	ubifs: Fix error return code in alloc_wbufs()	2021-03-04 11:37:51 +01:00
udf	udf: fix the problem that the disc content is not displayed	2021-02-07 15:37:15 +01:00
ufs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
unicode
vboxsf
verity
xfs	xfs: Fix assert failure in xfs_setattr_size()	2021-03-07 12:34:05 +01:00
zonefs	zonefs: Fix file size of zones in full condition	2021-03-04 11:38:41 +01:00
aio.c	vfs: separate __sb_start_write into blocking and non-blocking helpers	2020-11-10 16:53:07 -08:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	fs: Replace zero-length array with flexible-array member	2020-10-29 17:22:59 -05:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c
binfmt_script.c
block_dev.c	Revert "block: simplify set_init_blocksize" to regain lost performance	2021-02-03 23:28:45 +01:00
buffer.c
char_dev.c
compat_binfmt_elf.c
coredump.c	coredump: fix core_pattern parse error	2020-12-06 10:19:07 -08:00
d_path.c
dax.c	mm: provide a saner PTE walking API for modules	2021-02-26 10:13:01 +01:00
dcache.c
dcookies.c
direct-io.c
drop_caches.c
eventfd.c
eventpoll.c	kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE	2021-03-04 11:38:41 +01:00
exec.c	exec: Transform exec_update_mutex into a rw_semaphore	2021-01-09 13:46:24 +01:00
fcntl.c	fcntl: Fix potential deadlock in send_sig{io, urg}()	2021-01-06 14:56:53 +01:00
fhandle.c
file_table.c
file.c	kernel/io_uring: cancel io_uring before task works	2021-01-30 13:55:18 +01:00
filesystems.c
fs_context.c
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fs-writeback.c	fs: fix lazytime expiration handling in __writeback_single_inode()	2021-01-27 11:54:53 +01:00
fsopen.c
init.c
inode.c	fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()	2020-12-30 11:53:49 +01:00
internal.h
io_uring.c	io_uring: fix possible deadlock in io_uring_poll	2021-03-04 11:37:49 +01:00
io-wq.c	io_uring: always batch cancel in *cancel_files()	2021-02-13 13:54:56 +01:00
io-wq.h	io_uring: always batch cancel in *cancel_files()	2021-02-13 13:54:56 +01:00
ioctl.c
Kconfig	tmpfs: disallow CONFIG_TMPFS_INODE64 on alpha	2021-02-17 11:02:21 +01:00
Kconfig.binfmt
kernel_read_file.c
libfs.c	libfs: fix error cast of negative value in simple_attr_write()	2020-11-22 10:48:22 -08:00
locks.c
Makefile	Refactored code for 5.10:	2020-10-23 11:33:41 -07:00
mbcache.c
mount.h
mpage.c
namei.c	fs: make unlazy_walk() error handling consistent	2021-03-07 12:34:11 +01:00
namespace.c	umount(2): move the flag validity checks first	2021-01-19 18:27:32 +01:00
no-block.c
nsfs.c
open.c	openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT	2020-12-30 11:54:24 +01:00
pipe.c	fs/pipe: allow sendfile() to pipe again	2021-01-27 11:55:29 +01:00
pnode.c
pnode.h	fs/namespace.c: WARN if mnt_count has become negative	2021-01-06 14:56:54 +01:00
posix_acl.c
proc_namespace.c	proc mountinfo: make splice available again	2020-12-30 11:54:02 +01:00
read_write.c	Refactored code for 5.10:	2020-10-23 11:33:41 -07:00
readdir.c
remap_range.c
select.c	poll: fix performance regression due to out-of-line __put_user()	2021-01-19 18:27:27 +01:00
seq_file.c	fix return values of seq_read_iter()	2020-11-15 22:12:53 -05:00
signalfd.c
splice.c	io_uring-5.10-2020-10-24	2020-10-24 12:40:18 -07:00
stack.c
stat.c
statfs.c
super.c	vfs: move __sb_{start,end}_write* to fs.h	2020-11-10 16:53:11 -08:00
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c