mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
f72f116a2a
set_filter_wr is requesting __GFP_NOFAIL allocation although it can return ENOMEM without any problems obviously (t4_l2t_set_switching does that already). So the non-failing requirement is too strong without any obvious reason. Drop __GFP_NOFAIL and reorganize the code to have the failure paths easier. The same applies to _c4iw_write_mem_dma_aligned which uses __GFP_NOFAIL and then checks the return value and returns -ENOMEM on failure. This doesn't make any sense what so ever. Either the allocation cannot fail or it can. del_filter_wr seems to be safe as well because the filter entry is not marked as pending and the return value is propagated up the stack up to c4iw_destroy_listen. Signed-off-by: Michal Hocko <mhocko@suse.cz> Cc: David Rientjes <rientjes@google.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Dave Chinner <david@fromorbit.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Mel Gorman <mgorman@suse.de> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: "David S. Miller" <davem@davemloft.net> Cc: Hariprasad S <hariprasad@chelsio.com> Cc: Jan Kara <jack@suse.cz> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| clip_tbl.c | ||
| clip_tbl.h | ||
| cxgb4_dcb.c | ||
| cxgb4_dcb.h | ||
| cxgb4_debugfs.c | ||
| cxgb4_debugfs.h | ||
| cxgb4_ethtool.c | ||
| cxgb4_fcoe.c | ||
| cxgb4_fcoe.h | ||
| cxgb4_main.c | ||
| cxgb4_uld.h | ||
| cxgb4.h | ||
| l2t.c | ||
| l2t.h | ||
| Makefile | ||
| sge.c | ||
| t4_hw.c | ||
| t4_hw.h | ||
| t4_msg.h | ||
| t4_pci_id_tbl.h | ||
| t4_regs.h | ||
| t4_values.h | ||
| t4fw_api.h | ||
| t4fw_version.h | ||