Chris Wilson 4f88f8747f drm/i915/gt: Schedule request retirement when timeline idles ... The major drawback of commit 7e34f4e4aa ("drm/i915/gen8+: Add RC6 CTX corruption WA") is that it disables RC6 while Skylake (and friends) is active, and we do not consider the GPU idle until all outstanding requests have been retired and the engine switched over to the kernel context. If userspace is idle, this task falls onto our background idle worker, which only runs roughly once a second, meaning that userspace has to have been idle for a couple of seconds before we enable RC6 again. Naturally, this causes us to consume considerably more energy than before as powersaving is effectively disabled while a display server (here's looking at you Xorg) is running. As execlists will get a completion event as each context is completed, we can use this interrupt to queue a retire worker bound to this engine to cleanup idle timelines. We will then immediately notice the idle engine (without userspace intervention or the aid of the background retire worker) and start parking the GPU. Thus during light workloads, we will do much more work to idle the GPU faster... Hopefully with commensurate power saving! v2: Watch context completions and only look at those local to the engine when retiring to reduce the amount of excess work we perform. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112315 References: 7e34f4e4aa ("drm/i915/gen8+: Add RC6 CTX corruption WA") References: 2248a28384 ("drm/i915/gen8+: Add RC6 CTX corruption WA") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191125105858.1718307-3-chris@chris-wilson.co.uk		2019-11-25 13:17:18 +00:00
..
selftests	drm/i915: make more headers self-contained	2019-11-08 10:16:13 +00:00
uc	drm/i915: Mark intel_wakeref_get() as a sleeper	2019-11-21 13:22:04 +00:00
gen6_renderstate.c	drm/i915: Move the renderstate setup under gt/	2019-07-04 11:48:22 +01:00
gen7_renderstate.c	drm/i915: Move the renderstate setup under gt/	2019-07-04 11:48:22 +01:00
gen8_renderstate.c	drm/i915: Move the renderstate setup under gt/	2019-07-04 11:48:22 +01:00
gen9_renderstate.c	drm/i915: Move the renderstate setup under gt/	2019-07-04 11:48:22 +01:00
intel_breadcrumbs.c	drm/i915: Don't disable interrupts for intel_engine_breadcrumbs_irq()	2019-09-26 18:44:35 +01:00
intel_context_types.h	drm/i915: Remove logical HW ID	2019-10-04 15:39:30 +01:00
intel_context.c	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
intel_context.h	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
intel_engine_cs.c	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_engine_heartbeat.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
intel_engine_heartbeat.h	drm/i915/gt: Replace hangcheck by heartbeats	2019-10-23 23:52:10 +01:00
intel_engine_pm.c	drm/i915/gt: Adapt engine_park synchronisation rules for engine_retire	2019-11-25 13:17:18 +00:00
intel_engine_pm.h	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
intel_engine_pool_types.h	drm/i915: Replace struct_mutex for batch pool serialisation	2019-08-04 14:31:18 +01:00
intel_engine_pool.c	drm/i915: make pool objects read-only	2019-11-19 16:46:58 +00:00
intel_engine_pool.h	drm/i915: Mark i915_request.timeline as a volatile, rcu pointer	2019-09-20 10:24:09 +01:00
intel_engine_types.h	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_engine_user.c	drm/i915: Make for_each_engine_masked work on intel_gt	2019-10-18 00:06:25 +01:00
intel_engine_user.h	drm/i915: Rename engines to match their user interface	2019-08-07 14:30:55 +01:00
intel_engine.h	drm/i915/gt: Mark the execlists->active as the primary volatile access	2019-11-25 09:45:37 +00:00
intel_gpu_commands.h	drm/i915/tgl: Add HDC Pipeline Flush	2019-10-15 18:15:59 +01:00
intel_gt_irq.c	drm/i915: Extract GT render power state management	2019-10-26 19:28:59 +01:00
intel_gt_irq.h	drm/i915: Extract general GT interrupt handlers	2019-08-12 15:36:13 +01:00
intel_gt_pm_irq.c	drm/i915: Extract general GT interrupt handlers	2019-08-12 15:36:13 +01:00
intel_gt_pm_irq.h	drm/i915: Extract GT powermanagement interrupt handling	2019-08-12 15:36:06 +01:00
intel_gt_pm.c	drm/i915/gt: Fixup config ifdeffery for pm_suspend_target_state	2019-11-20 20:34:44 +00:00
intel_gt_pm.h	drm/i915: Mark intel_wakeref_get() as a sleeper	2019-11-21 13:22:04 +00:00
intel_gt_requests.c	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_gt_requests.h	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_gt_types.h	drm/i915: Extract GT render power state management	2019-10-26 19:28:59 +01:00
intel_gt.c	drm/i915/gt: Only wait for register chipset flush if active	2019-11-19 10:11:29 +00:00
intel_gt.h	drm/i915/gt: Call intel_gt_sanitize() directly	2019-11-05 16:04:16 +02:00
intel_llc_types.h	drm/i915: Extract GT ring management	2019-10-20 20:45:18 +01:00
intel_llc.c	drm/i915: Extract GT render power state management	2019-10-26 19:28:59 +01:00
intel_llc.h	drm/i915: Extract GT ring management	2019-10-20 20:45:18 +01:00
intel_lrc_reg.h	drm/i915/execlists: Verify context register state before execution	2019-11-02 13:39:13 +00:00
intel_lrc.c	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_lrc.h	drm/i915: drop lrc header page	2019-10-31 16:47:22 +00:00
intel_mocs.c	drm/i915/selftests: Add coverage of mocs registers	2019-11-14 17:38:54 +00:00
intel_mocs.h	drm/i915: Do initial mocs configuration directly	2019-10-16 19:35:37 +01:00
intel_rc6_types.h	drm/i915/gen8+: Add RC6 CTX corruption WA	2019-11-14 10:51:54 +10:00
intel_rc6.c	drm/i915/selftests: Exercise rc6 w/a handling	2019-11-19 20:05:01 +00:00
intel_rc6.h	drm/i915/gen8+: Add RC6 CTX corruption WA	2019-11-14 10:51:54 +10:00
intel_renderstate.c	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
intel_renderstate.h	drm/i915: Move the renderstate setup under gt/	2019-07-04 11:48:22 +01:00
intel_reset_types.h	drm/i915: Define explicit wedged on init reset state	2019-09-26 18:44:35 +01:00
intel_reset.c	drm/i915/gt: Declare timeline.lock to be irq-free	2019-11-20 17:12:11 +00:00
intel_reset.h	drm/i915: Don't mix srcu tag and negative error codes	2019-10-07 10:44:48 -07:00
intel_ring_submission.c	drm/i915/gt: Invalidate as we write the gen7 breadcrumb	2019-11-13 16:42:10 +00:00
intel_ring_types.h	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
intel_ring.c	drm/i915/gt: Make intel_ring_unpin() safe for concurrent pint	2019-11-19 15:12:46 +00:00
intel_ring.h	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
intel_rps_types.h	drm/i915: Extract GT render power state management	2019-10-26 19:28:59 +01:00
intel_rps.c	drm/i915/guc: Properly capture & release GuC interrupts on Gen11+	2019-11-14 23:04:36 +00:00
intel_rps.h	drm/i915/gt: Always track callers to intel_rps_mark_interactive()	2019-10-30 13:23:00 +00:00
intel_sseu.c	drm/i915: Expand subslice mask	2019-08-23 19:14:27 +01:00
intel_sseu.h	drm/i915/tgl: s/ss/eu fuse reading support	2019-09-21 08:31:08 +01:00
intel_timeline_types.h	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_timeline.c	drm/i915/gt: Schedule request retirement when timeline idles	2019-11-25 13:17:18 +00:00
intel_timeline.h	drm/i915/gt: Pull timeline initialise to intel_gt_init_early	2019-11-01 14:47:36 +00:00
intel_workarounds_types.h	drm/i915: Add engine name to workaround debug print	2019-07-12 09:55:30 +01:00
intel_workarounds.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
intel_workarounds.h
Makefile	drm/i915: use upstream version of header tests	2019-07-30 12:11:57 +03:00
mock_engine.c	drm/i915/gt: Split intel_ring_submission	2019-10-24 12:14:21 +01:00
mock_engine.h
selftest_context.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
selftest_engine_cs.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
selftest_engine_heartbeat.c	drm/i915/selftests: Flush all active callbacks	2019-11-02 08:34:53 +00:00
selftest_engine_pm.c	drm/i915: Mark up the calling context for intel_wakeref_put()	2019-11-20 15:59:23 +00:00
selftest_engine.c	drm/i915: Defer final intel_wakeref_put to process context	2019-08-08 21:28:51 +01:00
selftest_engine.h	drm/i915: Defer final intel_wakeref_put to process context	2019-08-08 21:28:51 +01:00
selftest_gt_pm.c	drm/i915/selftests: Exercise rc6 w/a handling	2019-11-19 20:05:01 +00:00
selftest_hangcheck.c	drm/i915/selftests: Complete transition to a real struct file mock	2019-11-08 10:17:41 +00:00
selftest_llc.c	drm/i915: Extract GT render power state management	2019-10-26 19:28:59 +01:00
selftest_llc.h	drm/i915: Extract GT ring management	2019-10-20 20:45:18 +01:00
selftest_lrc.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
selftest_mocs.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
selftest_rc6.c	drm/i915/selftests: Exercise rc6 w/a handling	2019-11-19 20:05:01 +00:00
selftest_rc6.h	drm/i915/selftests: Exercise rc6 w/a handling	2019-11-19 20:05:01 +00:00
selftest_reset.c	drm/i915/selftests: Flush interrupts before disabling tasklets	2019-10-24 09:18:52 +01:00
selftest_timeline.c	drm/i915: Serialise with engine-pm around requests on the kernel_context	2019-11-25 13:17:18 +00:00
selftest_workarounds.c	drm/i915/selftests: Complete transition to a real struct file mock	2019-11-08 10:17:41 +00:00