Commit Graph

427595 Commits

Author SHA1 Message Date
Greg Kroah-Hartman
6e2055a9e5 staging: echo: move to drivers/misc/
The code is clean, there are users of it, so it doesn't belong in
staging anymore, move it to drivers/misc/.

Cc: Steve Underwood <steveu@coppice.org>
Cc: David Rowe <david@rowetel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-28 14:08:42 -08:00
Greg Kroah-Hartman
dc93c85235 staging: sm7xxfb: remove driver
It hasn't been worked on in a very long time, and the original author
has moved on to a different product as this one is no longer being made.
So remove the driver.  If someone wants to resurect it, and clean it up
and get it merged to the "proper" part of the kernel, this commit can be
reverted.

Cc: Teddy Wang <teddy.wang@siliconmotion.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-28 14:04:28 -08:00
Malcolm Priestley
d1b2a11d7a staging: vt6656: s_nsBulkOutIoCompleteWrite Remove variable status.
Remove status and move debug messages to switch statement.

Remove duplicate second debug message.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:19 -08:00
Malcolm Priestley
d597aaef2d staging: vt6656: s_nsBulkOutIoCompleteWrite remove buf_len.
Use context->uBufLen directly which is unsigned int.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:19 -08:00
Malcolm Priestley
07bc8398ad staging: vt6656: Remove unused variables packets*
These variables are unused and don't reach user.

Remove them all.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:19 -08:00
Malcolm Priestley
cbe4da533b staging: vt6656: Remove unused variable bEventAvailable.
Flips from true to false but does nothing.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:18 -08:00
Malcolm Priestley
81aec60ed7 staging: vt6656: struct vnt_usb_send_context remove sEthHeader.
In nsDMA_tx_packet and bRelayPacketSend s_vSaveTxPktInfo points
to sEthHeader.h_dest which is the wrong viable.

Correct and point to pDevice->sTxEthHeader.

This is only relevant in the non fuctioning hostapd access point
mode, shortly to be removed from driver.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:18 -08:00
Malcolm Priestley
7e5a9193b1 staging: vt6656: Remove all variables ulInt*
None of these variables reach user or used by debug messages.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:18 -08:00
Malcolm Priestley
88c4d12c91 staging: vt6656: Remove all variables ulBulk*
None of these variables reach user or in any debug messages.

Remove them all.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 17:09:18 -08:00
Himangi Saraogi
a6eb9af980 Staging: bcm: Replace bcm functions with equivalents
This patch removes unnecessary bcm functions and replaces them with
their equivalents defined in usb/ch9.h.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:24:20 -08:00
Monam Agarwal
2a27515822 Staging: slicoss: Fix unnecessary whitespace before a quoted newline in slicoss.c
This patch fixes the following checkpatch.pl issues in slicoss.c
WARNING: unnecessary whitespace before a quoted newline in slicoss.c

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:24:20 -08:00
Monam Agarwal
5d5b44b5f4 Staging: slicoss: Fix quoted string split across lines
This patch fixes the following checkpatch.pl issues in slicoss.c
WARNING: quoted string split across lines

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:24:20 -08:00
Himangi Saraogi
a1ccf4f865 Staging : rts5208: Fix code indent issue
This patch removes the checkpatch warning : suspect code indent for
conditional statements, by converting spaces to tabs.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:15:58 -08:00
Monam Agarwal
fe6c0f92b6 Staging: line6: Fix no space before tabs in usbdefs.h
This patch fixes the following checkpatch.pl issues in usbdefs.h:
WARNING: no space before tabs

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:15:58 -08:00
Monam Agarwal
56733e9793 Staging: line6: Fix unnecessary space after function pointer in driver.h
This patch fixes the following checkpatch.pl issues in driver.h:
WARNING: unnecessary space after function pointer in driver.h

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:15:58 -08:00
Monam Agarwal
1cad608ec2 Staging: line6: Fix unnecessary space after function pointer in driver.c
This patch fixes the following checkpatch.pl issues in driver.c:
WARNING: unnecessary space after function pointer in driver.c

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:15:58 -08:00
Monam Agarwal
012317f7d6 Staging: slicoss: Fix line over 80 characters in slic.h
This patch fixes the following checkpatch.pl issues in slic.h:
WARNING: line over 80 characters

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:12:12 -08:00
Masanari Iida
5484081d22 staging: usbip: Fix format string mismatch in usbip_vhci_attach_device2
Argument type of sockfd is set as int, but format string
is set as unsigned int. Fix the mismatch.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:12:12 -08:00
Masanari Iida
40a46d8b40 staging: rtl8188eu: Fix typo in rtl8188eu/core
Fix spelling typo in comments and printk within
rtl8188eu/core

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:12:11 -08:00
Elena Oat
f8cfc02309 Staging: usbip: Fix the warning of unchecked sscanf return value.
The return value of sscanf in stub_dev.c is not checked. This patch
adds the checking of the return value.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 15:12:11 -08:00
Fabio Estevam
fdffa6f2b3 imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()
Fix the following static checker warning:

drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static?

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:57:43 -08:00
Fabio Estevam
18589738ee imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'
Fix the following static checker warning:

drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]

Use %pad to print 'dma_addr_t'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:57:43 -08:00
Fabio Estevam
39dcf4f708 imx-drm: parallel-display: Check 'mode' pointer first
Fix the following static checker warnings:

drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:57:43 -08:00
Fabio Estevam
9f9b036f0e imx-drm: imx-ldb: Check 'mode' pointer first
Fix the following static checker warning:

drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'.  (drm_mode_create returns null)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:57:43 -08:00
Vinayak Menon
058dbde928 staging: android: lowmemorykiller: neglect swap cached pages in other_file
With ZRAM enabled it is observed that lowmemory killer
doesn't trigger properly. swap cached pages are
accounted in NR_FILE, and lowmemorykiller considers
this as reclaimable and adds to other_file. But these
pages can't be reclaimed unless lowmemorykiller triggers.
So subtract swap pages from other_file.

Signed-off-by: Vinayak Menon <vinayakm.list@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:51:27 -08:00
Ana Rey
12f2200f98 staging: rtl8187se: Convert _link_detect_t typedef into a struct.
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.

While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:59 -08:00
Ana Rey
f37e756033 staging: rtl8187se: Convert Stats typedef into a struct
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.

While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:58 -08:00
Ana Rey
02981dac48 staging: rtl8187se: Convert ChnlAccessSetting typedef into a struct.
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.

While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:06 -08:00
Ana Rey
742af58526 staging: rtl8187se: Added parenthesis in a macro in r8180.h
This patch adds parentheses to enclose a complex value in a macro as a the
CodingStyle recommends.

This errors was found by checkpatch.pl script

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:06 -08:00
Ana Rey
359754f4fa staging: rtl8187se: Fixed a pointer declaration error in r8180.h
This patch fixes a pointer declaration error found by checkpatch.pl in
r8180.h

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:06 -08:00
Ana Rey
cdef21cc0a staging: rtl8187se: Fixed open brace in r8180.h
The open brace following struct have to go on the same line as a codingStyle of
 the kernel recommends

This patch fixed errors with a open brace found by checkpatch.pl script in
r8180.h

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:49:06 -08:00
Ana Rey
ad0ec37bc5 staging: rtl8187se: Clean-up comment line style in r8180.h
This patch clean-up comment-line style in r8180 as the CodingStyle recommends.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:47:17 -08:00
Ana Rey
24d73efea7 staging: rtl8187se: Fixed whitespaces and indentations in r8180.h
This patch fixes whitespaces and converts some indentations to whitespaces and
whitespaces to indentations when it is necessary as the codingStyle of the
 kernel recommends.
Thus, It deletes a lot of errors found by checkpatch.pl in r8180.h

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:47:17 -08:00
Monam Agarwal
7dd1a0a9e0 Staging: sm7xxfb: Fix quoted string split across lines in sm7xxfb.c
This patch fixes the following checkpatch.pl issues in sm7xxfb.c:
WARNING: Quoted string split across lines

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 14:47:17 -08:00
Daeseok Youn
c272937fd5 staging: lustre: make functions as static
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:10:02 -08:00
Monam Agarwal
e26b0da125 Staging: sep: Fix line length over 80 characters in sep_main.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: line length over 80 characters

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:07:59 -08:00
Monam Agarwal
22fc12669b Staging: sep: Fix quoted string split across lines in sep_main.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Quoted string split across lines

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:07:59 -08:00
Monam Agarwal
38d6bc53e2 Staging: sep: Fix missing space after return type in sep_crypto.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Missing space after return type

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:07:59 -08:00
Daeseok Youn
4a467a438a staging: bcm: fix checkpatch error 'assignment in if condition'
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.

If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:07:11 -08:00
Daeseok Youn
24e3b16b99 staging: bcm: Remove unneeded set a variable
bClassificationSucceed is initialized with "false",
do not need to set "false" again.

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:07:11 -08:00
Malcolm Priestley
ebf5a3ccdf staging: vt6656: struct vnt_usb_send_context struct size optimization.
Reorder in size and remove dead member Next.

Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
599e4b5ca8 staging: vt6656: Remove pointer cast to urb->context.
Remove unnecessary cast to void * urb->context

Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
0b787d713b staging: vt6656: Cleanup PIPEnsBulkInUsbRead
Remove camel case and white space.

Camel case changes
pDevice -> priv
pRCB -> rcb
ntStatus -> status
pUrb -> urb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
d4fa2ab067 staging: vt6656: clean up s_nsBulkInUsbIoCompleteRead
Clean up white space and camel case.

Camel case changes
pDevice -> priv
pRCB -> rcb
bReAllocSkb -> re_alloc_skb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
67638980ef staging: vt6656: s_nsBulkInUsbIoCompleteRead Replace error handling.
Use switch on urb->status

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
1882c19c2d staging: vt6656: s_nsBulkInUsbIoCompleteRead Remove bytesRead/bIndicateReceive.
Replace with urb->actual_length.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
e3a8fa1748 staging: vt6656: s_nsBulkInUsbIoCompleteRead get rid of status.
Just use urb->status directly.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
3f38290e3b staging: vt6656: clean up PIPEnsSendBulkOut.
Remove commented out code, white space and camel case.

camel case changes
pDevice -> priv
pContext -> context
pUrb -> urb

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
da5c99fdf5 staging: vt6656: usb_fill_bulk_urb get rid of void* cast.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00
Malcolm Priestley
133383035f staging: vt6656: PIPEnsSendBulkOut reverse if statement
Get rid of unnessary else statement by !(MP_IS_READY(pDevice) &&
pDevice->Flags & fMP_POST_WRITES)

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27 13:04:36 -08:00