Commit Graph

2061 Commits

Author SHA1 Message Date
Andrey Borzenkov
b8a021c9e2 dbus: fix dbus assert due to uninitialized error
Add missing dbus_error_init() in UNKNOWN_OBJECT case. Fixes assertion

systemd[1]: Caught <ABRT>, dumped core as pid 6256.
systemd[1]: Freezing execution.

Core was generated by `/bin/systemd systemd.unit=graphical.target'.
Program terminated with signal 6, Aborted.
#0  0x00007f8966ec81db in raise () from /lib64/libpthread.so.0
(gdb) bt
#0  0x00007f8966ec81db in raise () from /lib64/libpthread.so.0
#1  0x000000000040823b in crash (sig=6) at src/main.c:120
#2  <signal handler called>
#3  0x00007f896613c075 in raise () from /lib64/libc.so.6
#4  0x00007f896613d806 in abort () from /lib64/libc.so.6
#5  0x00007f89672ac8a5 in _dbus_abort () at dbus-sysdeps.c:94
#6  0x00007f89672a37b5 in _dbus_warn_check_failed (
   format=0x7f89672b35d8 "arguments to %s() were incorrect, assertion
\"%s\" failed in file %s line %d.\nThis is normally a bug in some
application using the D-Bus library.\n") at dbus-internals.c:289
#7  0x0000000000441500 in bus_unit_message_handler (connection=0x21b6090,
   message=0x21b6760, data=0x1f3e870) at src/dbus-unit.c:572
#8  0x00007f8967299f11 in _dbus_object_tree_dispatch_and_unlock (
   tree=0x219d660, message=0x21b6760) at dbus-object-tree.c:858
#9  0x00007f896728bca2 in dbus_connection_dispatch (connection=0x21b6090)
   at dbus-connection.c:4688
#10 0x000000000043befa in bus_dispatch (m=0x1f3e870) at src/dbus.c:547
#11 0x000000000041056d in manager_loop (m=0x1f3e870) at src/manager.c:2344
#12 0x0000000000409515 in main (argc=<value optimized out>,
   argv=<value optimized out>) at src/main.c:1229
2011-03-09 20:03:29 +01:00
Lennart Poettering
05feefe0fb dbus: properly generate UnknownInterface, UnknownProperty and PropertyReadOnly errors 2011-03-09 20:01:53 +01:00
Lennart Poettering
34df5a34e1 drop unnecessary suffix NULs as gcc adds them anyway 2011-03-09 19:48:02 +01:00
Lennart Poettering
cc5524ecc6 mount: use /dev/.run as an early boot alias for /var/run
During early boot, mount a tmpfs to /dev/.run and then bind mount it to
/var/run as soon as /var is available.

This makes it possible for programs involved in early boot to put
runtime data in /dev/.run which later on will show up in /var/run like
any other.

This can be used to solve the early-boot D-Bus problem: D-Bus may start
up with its socket bound to /dev/.run/dbus/system_bus_socket and after
/var it will also be available under the traditional name
/var/run/dbus/system_bus_socket.

This also is intended to be used as a better place for systemd, mount,
mdadm, blkid, plymouth, bootchart and dracut runtime data, which is
currently stored in various places in /dev/.xxx.
2011-03-09 02:51:45 +01:00
Andrey Borzenkov
1de4d79bf5 build-sys: add Mandriva distribution support
This merges several separate patches that I carry as part of
Mandriva systemd RPM. They touch those parts that are very
unlikely to be changed in near future and do not impose any
functionality change for systemd core. I also think it is
useful for troubleshooting to have real distribution name in
system logs, espicially when someone reports problem upstream.

The patch looks bigger than sum of replaced patches because

- previous patches were applied on top of distro=fedora, now
I need to add all those bits for distro=mandriva as well

- part of patch was done as spec file magic, but it seems more
logical to ship all these bits together
2011-03-08 19:47:36 +01:00
Lennart Poettering
6e25b33cdd build-sys: prepare v20 2011-03-08 19:41:33 +01:00
Lennart Poettering
e527618da5 service: use uppercase SYSV prefix to make it easier to recognize 2011-03-08 18:51:20 +01:00
Lennart Poettering
85211309f0 service: prefix description with LSB only if script has LSB header, use 'SysV:' otherwise 2011-03-08 18:41:23 +01:00
Lennart Poettering
21256a2b3b unit: don't accidently create ordering links to targets when default deps are off for either target and unit 2011-03-08 03:24:42 +01:00
Lennart Poettering
d4a7e06dea mount: support less cumbersome x-systemd-xxx mount options 2011-03-08 03:08:15 +01:00
Lennart Poettering
267632f0ab unit: distuingish mandatory from triggering conditions 2011-03-08 03:04:47 +01:00
Lennart Poettering
08672cb507 dbus: return DBUS_ERROR_UNKNOWN_OBJECT when an object is unknown 2011-03-08 02:27:43 +01:00
Lennart Poettering
83310f162d systemctl: when forwarding is-enabled to chkconfig hardcode runlevel 3 2011-03-08 01:53:47 +01:00
Lennart Poettering
d68201e9aa job: introduce new job result code 'skipped' to use when pre conditions of job did not apply
https://bugzilla.redhat.com/show_bug.cgi?id=682245
https://bugzilla.redhat.com/show_bug.cgi?id=635780
2011-03-08 01:53:47 +01:00
Lennart Poettering
8125393018 job: convert job type as early as we can, to simplify things a bit 2011-03-08 01:53:47 +01:00
Zbigniew Jędrzejewski-Szmek
85f0c93a50 Keep emacs configuration in one configuration file.
On 07.03.2011 19:04, Lennart Poettering wrote:
>
> Oh, I had assumed that .vimrc trick would allow project-wide vim
> modelines without having to edit each and every single file.
>
> Currently, every file does contain an emacs modeline at the top. It
> would be fair I guess to add a vim modeline to all those files too, even
> though it's not necessarily pretty.
Hi,
maybe it makes sense to go in the opposite direction: add .dir-locals.el
in the top directory. The settings are actually identical in all .[ch]
files.
2011-03-08 01:53:46 +01:00
Lennart Poettering
b670e92b50 syslog: make sure the kmsg bridge is always pulled in and never terminated automatically
Since we want to replace the bridge dynamically by the real syslog
implementation such as rsyslog we need to make sure that the the bridge
stays running right to the moment rsyslog is up so that we process
messages enqueued by other processes started before rsyslog, so that
those clients don't stay stuck.
2011-03-07 21:56:13 +01:00
Andrey Borzenkov
0992bbd109 add .vimrc to .gitignore 2011-03-07 19:25:15 +01:00
Lennart Poettering
c4b5a3d66f mount: make /media a tmpfs 2011-03-07 17:38:15 +01:00
Lennart Poettering
7fc7012b8b update TODO 2011-03-07 02:17:36 +01:00
Andrey Borzenkov
c826cda421 add org.freedesktop.DBus.Properies.Set method
The patch adds framework for processing Set requests on properties
and as first consumers allows setting of LogTarget and LogLevel on
interface org.freedesktop.systemd1.Manager of org.freedesktop.systemd1.

The code should be generic enough to allow processing of any
property on other objects and interfaces as well.

No systemctl visible interface is added so far. The LogTarget and
LogLevel are meant for debugging in the first place; user interface
can be added if other usage emerge.

Set on systemwide systemd is restricted to root; I am not sure
how session level access is controlled.
2011-03-07 02:17:31 +01:00
Lennart Poettering
b4353094e5 service: drop redundant check in sysv_translate_facility
We check for _r with an assert in the function header anyway, no need to
check it again.
2011-03-06 23:28:39 +01:00
Lennart Poettering
fc7ac59412 update TODO 2011-03-05 00:30:54 +01:00
Lennart Poettering
76526bad9f machine-id: generate /etc/machine-id 0444 by default 2011-03-04 22:50:56 +01:00
Lennart Poettering
9b4f818bd8 machine-id: typo fix 2011-03-04 22:28:13 +01:00
Lennart Poettering
d7ccca2e3f main: introduce /etc/machine-id
This is supposed to play the same roles /var/lib/dbus/machine-id,
however fixes a couple of problems:

- It is available during early boot since it is stored in /etc

- Removes the ID from the D-Bus context and moves it into a system
  context, thus hopefully lowering hesitation by people to use it.

- It is generated at installation time. If the file is empty at boot
  time it will be mounted over with a randomly generated ID, which is
  not saved to disk. This is useful to support state-less machines with
  no transient or writable /etc configuration.
2011-03-04 21:53:19 +01:00
Lennart Poettering
63a723f3a7 systemctl: fix exit code when directing is-enabled to chkconfig 2011-03-04 19:48:38 +01:00
Lennart Poettering
81ab0d3c65 main: minor optimization 2011-03-04 19:48:12 +01:00
Lennart Poettering
c5d3439055 dbus: add 'Tainted' property to Manager object 2011-03-04 19:47:43 +01:00
Lennart Poettering
09bde77fc7 dbus: expose distribution name and features on manager object as properties 2011-03-04 18:34:56 +01:00
Lennart Poettering
f1779fd27b man: document changed EnvironmentFile= behaviour 2011-03-04 14:13:47 +01:00
Lennart Poettering
aa1671320d main: add link to wiki page with longer explanation of the /usr madness 2011-03-04 05:07:01 +01:00
Lennart Poettering
ed1c99fcc1 s/seperate/separate/ 2011-03-04 03:58:52 +01:00
Lennart Poettering
8c7be95e5a execute: load environment files at time of execution, not when we load the service configuration
https://bugzilla.redhat.com/show_bug.cgi?id=661282
2011-03-04 03:44:43 +01:00
Lennart Poettering
0595f9a1c1 path: after installing inotify watches, recheck file again to fix race 2011-03-04 01:50:38 +01:00
Lennart Poettering
3fc546f93d path: don't use IN_ATTRIB on parent dirs when watching a file, since those cannot be removed without emptying the dir first anyway and we need IN_ATTRIB only to detect the link count dropping to 0 2011-03-04 00:22:00 +01:00
Lennart Poettering
430c18ed7f kill: always send SIGCONT after SIGTERM
When we kill a process to terminate it make sure to send SIGCONT to
ensure it is unpaused and processes the signal.
2011-03-03 23:55:30 +01:00
Lennart Poettering
2b590e135f readahead: disable collector automatically on read-only media 2011-03-03 23:03:26 +01:00
Lennart Poettering
c1b664d055 sysctl: use scandir() instead of nftw() to guarantee systematic ordering 2011-03-03 22:17:09 +01:00
Lennart Poettering
1a6f4df6c9 dirent: support DT_UNKNOWN where necessary for compat with reiserfs 2011-03-03 16:29:50 +01:00
Lennart Poettering
fc7a744cc4 README: refer to profusion if people ask for consulting/engineering services 2011-03-01 23:46:01 +01:00
Lennart Poettering
64e5f1b721 systemctl: add condreload alias for compat with ALTLinux 2011-03-01 22:20:13 +01:00
Lennart Poettering
6221fcdf2e man: fix chkconfig syntax to use --level 3 2011-03-01 22:18:49 +01:00
Lennart Poettering
020501d952 build-sys: prepare v19 2011-03-01 01:33:38 +01:00
Lennart Poettering
3db48a7850 update TODO 2011-03-01 01:02:35 +01:00
Lennart Poettering
3414abee0d ask-password: make a confused gcc shut up 2011-02-28 23:24:33 +01:00
Harald Hoyer
4ce9faa9d2 ratelimit: removed n_printed
Removed n_printed and renamed n_printed to num.
This is not a logging rate limiter anymore.
2011-02-28 23:04:18 +01:00
Harald Hoyer
35b8ca3aaf Spelling Corrections
Just some lame spelling corrections with no functionality.
2011-02-28 22:47:38 +01:00
Zbigniew Jędrzejewski-Szmek
a9bd141b4a systemctl: always null-terminate the password 2011-02-28 22:17:36 +01:00
Alexey Shabalin
53bdb7c186 build-sys: update ALTLinux support
Please apply patch for update ALTLinux support.
2011-02-28 22:10:13 +01:00