Avoid "sender uid=65534, message ignored" case, where no credentials can
be read on the sender side.
Seems, the server socket does not enable credential receiving fast
enough, and the message from the client (without credential) sometimes
is queued before the credential passing was active.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Before, we would initialize many fields twice: first
by filling the structure with zeros, and then a second
time with the real values. We can let the compiler do
the job for us, avoiding one copy.
A downside of this patch is that text gets slightly
bigger. This is because all zero() calls are effectively
inlined:
$ size build/.libs/systemd
text data bss dec hex filename
before 897737 107300 2560 1007597 f5fed build/.libs/systemd
after 897873 107300 2560 1007733 f6075 build/.libs/systemd
… actually less than 1‰.
A few asserts that the parameter is not null had to be removed. I
don't think this changes much, because first, it is quite unlikely
for the assert to fail, and second, an immediate SEGV is almost as
good as an assert.
NOTE by Basile: the above analysis is for all systemd. This commit
is just a sliver of the commit for all of system and so we can't
expect size to be the same.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
For some reason this shows up on i686 only:
src/udev/udev-builtin-usb_id.c:192:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
This corrects a previously applied commit for upstream's
acd42fae59096d84e78f1c17bfcc0d8f96486341
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
This fixes two issues: 1) The -r option does not exist for busybox
and we do not need relative sym linking anyhow, and 2) if the
sym link already exists, we want to overwrite it, hence -f.
X-Eudev-Bug: 58
X-Eudev-Bug-URL: https://github.com/gentoo/eudev/issues/58
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
We do not want to install 80-net-name-slot.rules if we
--enable-rule-generator. In fact doing so will switch to
the predictable network interface names.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
There is no reason to keep this rule separate and it works fine
when incuded in 50-udev-default.rules.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
This code was dropped while importing from upstream. It is needed
to allow the legacy renaming of interfaces like eth* or wlan*.
X-Eudev-Bug: 56
X-Eudev-Bug-URL: https://github.com/gentoo/eudev/issues/56
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
The installation was overwriting udevadm when building with
--sbindir=/usr/bin and ignoring $bindir. Both situations lead
to a symlink which points to nowhere.
Thanks TZ86.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Libudev has a symbol version for 199 now, so the libudev_internal
version (which is used to essentially hide symbols that are not
part of the external API) needs to use 199 as its baseline instead
of 196
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
This error was introduced in our commit
601c4e8ce6
when importing from upstream. The revert line works only
in the context of all of upstream's commit
7850b3b83791ba0e2377ba40383c5abc258b839d
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Previously, rootprefix was set to the actual value of the default prefix,
which caused issues when running 'make distcheck' since prefix is set
to a non-standard value but rootprefix is unset. By assigning the variable
rather than its contents, this should now be avoided.
75-persistent-net-generator.rules is in the rule_generator subdir, do
not try and install from here.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Both scripts had hard-coded paths to 'rule_generator.functions'; these were changed
to be substituted in by configure so the paths will match where files are
installed.øy
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
This restores the rule generator scripts for the persistent
network and optical device rule generator scripts that were
removed after udev-171, and re-introduces their installation
to the build system.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Wraps the changes made in systemd commits 5ae18ddc and 53726349
with a #if's on LIBUDEV_LEGACY_VERSION so that old behaviour
can be chosen at build-time if users find it necessary to support
legacy software dependent on the original behaviour
Original Authors:
Kay Sievers
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
configure.ac has AC_PROG_LN_S already so we should use it.
upstream did this in commit 783162123dbac43d5b7a3fab9d4f11dcf86d06e1
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Follow upstream commit f432bb914499e2c28b43f592bb273f0a8664f352
but refactor the patch for eudev build system. Provide a
compatibility symlink in sbindir for anything that hard-codes
the path to udevadm
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Avoid two evaluations of src in util_strpcpy clean the code in the ones
where the pointer passed is not modified and merge the main loop of
util_strpcpyl and util_strscpyl into util_strpcpyv. Also make strpcpy
more compact by removing some unnecessary arithmetic.
Cleanup util_strpcpyv by shortcutting size == 0 case
Do some style fixups
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
This updates the daemon codebase to upstream.
Authors:
Zbigniew Jędrzejewski-Szmek
Lennart Poettering
Václav Pavlín
Kay Sievers
Harald Hoyer
Rob Clark
Zeeshan Ali (Khattak)
See http://cgit.freedesktop.org/systemd/systemd/log/src/udev
Ian is signing off but has some concerns on a few of the changes
that he may fix in future commits.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Add udev_device_set_sysattr_value which is defined in
libudev/libudev-device.c.
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
This sets the permissions on null, zero, full, random and urandom
to 666 which is needed for older kernels. This is part of Gentoo's
40-gentoo.rules which can now be dropped from Gentoo's ebuild.
X-gentoo-Bug: 457868
X-gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=457868
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
This updates the library codebase to upstream version 199.
(originally merged by Anthony G. Basile <blueness@gentoo.org>)
Upstream commits 5ae18ddc0d and 53726349e1 are not applied,
code will be excluded via #if...#endif in a future commit
Authors:
Kay Sievers
Thomas Hindoe Paaboel Andersen
Hannes Reinecke
Jan Engelhardt
See http://cgit.freedesktop.org/systemd/systemd/log/src/libudev
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
Separate out Ideapad U300s to its own line and add Microphone mute key.
Signed-off-by: Martin Pitt <martinpitt@gnome.org>
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Signed-off-by: Ian Stakenvicius <axs@gentoo.org>
