mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-15 04:26:42 +07:00
ff74745e6d
Kmemleak checking configuration reports a memory leak in
usb_os_desc_prepare_interf_dir function when rndis function
instance is freed and then allocated again. For example, this
happens with FunctionFS driver with RNDIS function enabled
when "ffs-test" test application is run several times in a row.
The data for intermediate "os_desc" group for interface directories
is allocated as a single VLA chunk and (after a change of default
groups handling) is not ever freed and actually not stored anywhere
besides inside a list of default groups of a parent group.
The fix is to make usb_os_desc_prepare_interf_dir function return
a pointer to allocated data (as a pointer to the first VLA item)
instead of (an unused) integer and to make the caller component
(currently the only one is RNDIS function) responsible for storing
the pointer and freeing the memory when appropriate.
Fixes: 1ae1602de0 ("configfs: switch ->default groups to a linked list")
Cc: stable@vger.kernel.org
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
21 lines
514 B
C
21 lines
514 B
C
#ifndef USB__GADGET__CONFIGFS__H
|
|
#define USB__GADGET__CONFIGFS__H
|
|
|
|
#include <linux/configfs.h>
|
|
|
|
void unregister_gadget_item(struct config_item *item);
|
|
|
|
struct config_group *usb_os_desc_prepare_interf_dir(
|
|
struct config_group *parent,
|
|
int n_interf,
|
|
struct usb_os_desc **desc,
|
|
char **names,
|
|
struct module *owner);
|
|
|
|
static inline struct usb_os_desc *to_usb_os_desc(struct config_item *item)
|
|
{
|
|
return container_of(to_config_group(item), struct usb_os_desc, group);
|
|
}
|
|
|
|
#endif /* USB__GADGET__CONFIGFS__H */
|