Jens Axboe fe54303ee2 NVMe: fix retry/error logic in nvme_queue_rq() ... The logic around retrying and erroring IO in nvme_queue_rq() is broken in a few ways: - If we fail allocating dma memory for a discard, we return retry. We have the 'iod' stored in ->special, but we free the 'iod'. - For a normal request, if we fail dma mapping of setting up prps, we have the same iod situation. Additionally, we haven't set the callback for the request yet, so we also potentially leak IOMMU resources. Get rid of the ->special 'iod' store. The retry is uncommon enough that it's not worth optimizing for or holding on to resources to attempt to speed it up. Additionally, it's usually best practice to free any request related resources when doing retries. Acked-by: Keith Busch <keith.busch@intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>		2014-12-11 13:58:39 -07:00
..
aoe	block: remove artifical max_hw_sectors cap	2014-10-21 14:02:54 -06:00
drbd	drbd: use generic io stats accounting functions to simplify io stat accounting	2014-11-24 08:05:14 -07:00
mtip32xx	blk-mq: add a 'list' parameter to ->queue_rq()	2014-10-29 11:14:52 -06:00
paride	Merge branch 'for-3.18/core' of git://git.kernel.dk/linux-block	2014-10-18 11:53:51 -07:00
rsxx	block/rsxx: use generic io stats accounting functions to simplify io stat accounting	2014-11-24 08:05:18 -07:00
xen-blkback	Merge branch 'for-3.18/drivers' of git://git.kernel.dk/linux-block	2014-10-18 12:12:45 -07:00
zram	zram: avoid kunmap_atomic() of a NULL pointer	2014-11-13 16:17:05 -08:00
amiflop.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00
ataflop.c	Merge branch 'for-3.16/core' of git://git.kernel.dk/linux-block into next	2014-06-02 09:29:34 -07:00
brd.c	brd: add ram disk visibility option	2014-08-21 20:42:01 -05:00
cciss_cmd.h	cciss: use new doorbell-bit-5 reset method	2011-05-06 08:23:55 -06:00
cciss_scsi.c	cciss: switch to ->show_info()	2013-04-09 14:13:19 -04:00
cciss_scsi.h	cciss: add cciss_tape_cmds module paramter	2011-05-06 08:23:59 -06:00
cciss.c	block: use pci_zalloc_consistent	2014-08-08 15:57:28 -07:00
cciss.h	cciss: Adds simple mode functionality	2011-08-08 11:40:15 +02:00
cpqarray.c	cpqarray: fix info leak in ida_locked_ioctl()	2013-09-24 17:00:26 -07:00
cpqarray.h
cryptoloop.c	move linux/loop.h to drivers/block	2013-06-29 12:46:45 +04:00
DAC960.c	block: use pci_zalloc_consistent	2014-08-08 15:57:28 -07:00
DAC960.h
floppy.c	Merge branch 'for-jens' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/linux-block into for-linus	2014-06-18 10:30:22 -07:00
hd.c	block: hd: remove deprecated IRQF_DISABLED	2014-10-01 08:16:07 -06:00
ida_cmd.h
ida_ioctl.h
Kconfig	zram: promote zram from staging	2014-01-30 16:56:55 -08:00
loop.c	Merge branch 'sched/urgent' into sched/core, to avoid conflicts	2014-05-07 13:15:46 +02:00
loop.h	move linux/loop.h to drivers/block	2013-06-29 12:46:45 +04:00
Makefile	zram: promote zram from staging	2014-01-30 16:56:55 -08:00
mg_disk.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00
nbd.c	block: disable entropy contributions for nonrot devices	2014-10-04 10:55:32 -06:00
null_blk.c	null_blk: boundary check queue_mode and irqmode	2014-11-26 14:45:48 -07:00
nvme-core.c	NVMe: fix retry/error logic in nvme_queue_rq()	2014-12-11 13:58:39 -07:00
nvme-scsi.c	NVMe: Convert to blk-mq	2014-11-04 13:18:52 -07:00
osdblk.c	block: replace strict_strtoul() with kstrtoul()	2013-09-11 15:56:56 -07:00
pktcdvd.c	block,scsi: fixup blk_get_request dead queue scenarios	2014-08-28 10:03:46 -06:00
ps3disk.c	block: Kill bio_segments()/bi_vcnt usage	2013-11-23 22:33:51 -08:00
ps3vram.c	block: Convert bio_for_each_segment() to bvec_iter	2013-11-23 22:33:49 -08:00
rbd_types.h	rbd: get rid of RBD_MAX_SEG_NAME_LEN	2012-12-17 08:37:29 -06:00
rbd.c	rbd: Fix error recovery in rbd_obj_read_sync()	2014-10-30 13:11:51 +03:00
skd_main.c	block: disable entropy contributions for nonrot devices	2014-10-04 10:55:32 -06:00
skd_s1120.h	skd: fix formatting in skd_s1120.h	2013-11-08 09:10:30 -07:00
smart1,2.h	fix typos 'comamnd' -> 'command' in comments	2011-02-02 11:31:21 +01:00
sunvdc.c	sunvdc: don't call VD_OP_GET_VTOC	2014-10-31 15:49:45 -04:00
swim3.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00
swim_asm.S
swim.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00
sx8.c	block,scsi: fixup blk_get_request dead queue scenarios	2014-08-28 10:03:46 -06:00
umem.c	block: Convert drivers to immutable biovecs	2013-11-23 22:33:51 -08:00
umem.h
virtio_blk.c	blk-mq: add a 'list' parameter to ->queue_rq()	2014-10-29 11:14:52 -06:00
xen-blkfront.c	xen/blkfront: remove redundant flush_op	2014-12-10 12:20:18 -05:00
xsysace.c	block: systemace: Remove .owner field for driver	2014-08-21 20:37:54 -05:00
z2ram.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00