Rafał Miłecki fd3667a8d1 brcmfmac: don't remove interface on link down firmware event ... There are two firmware events we handle similarly in brcmfmac: BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view is that the first one means BSS remains present in the firmware. Trying to (re)create it (e.g. when adding new virtual interface) will result in an error. Current code treats both events in a similar way. It removes Linux interface for each of them. It works OK with e.g. BCM43602. Its firmware generates both events for each interface. It means we get BRCMF_E_LINK and remove interface. That is soon followed by BRCMF_E_IF which means BSS was also removed in a firmware. The only downside of this is a harmless error like: [ 208.643180] brcmfmac: brcmf_fweh_call_event_handler: no interface object Unfortunately BCM4366 firmware doesn't automatically remove BSS and so it doesn't generate BRCMF_E_IF. In such case we incorrectly remove Linux interface on BRCMF_E_LINK as BSS is still present in the firmware. It results in an error when trying to re-create virtual interface, e.g.: > iw phy phy1 interface add wlan1-1 type __ap [ 3602.929199] brcmfmac: brcmf_ap_add_vif: timeout occurred command failed: I/O error (-5) With this patch we don't remove Linux interface while firmware keeps BSS. Thanks to this we keep a consistent states of host driver and device firmware. Further improvement should be to mark BSS as disabled and remove interface on BRCMF_E_LINK. Then we should add support for reusing BSS-es. Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>		2016-06-16 18:12:01 +03:00
..
accessibility
acpi	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
amba
android
ata	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
atm	atm: iphase: off by one in rx_pkt()	2016-05-31 11:52:59 -07:00
auxdisplay
base	More power management updates for v4.7-rc1	2016-05-25 15:29:21 -07:00
bcma	MTD updates for v4.7:	2016-05-24 11:00:20 -07:00
block	DAX error handling for 4.7	2016-05-26 19:34:26 -07:00
bluetooth	Bluetooth: Add USB ID 13D3:3487 to ath3k	2016-05-13 16:54:59 +02:00
bus	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2016-05-19 10:02:26 -07:00
cdrom
char	Merge branch 'akpm' (patches from Andrew)	2016-05-20 22:31:33 -07:00
clk	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
clocksource	Small release overall.	2016-05-19 11:27:09 -07:00
connector
cpufreq	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
cpuidle	cpuidle: Fix cpuidle_state_is_coupled() argument in cpuidle_enter()	2016-05-18 02:48:37 +02:00
crypto	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2016-05-30 15:20:18 -07:00
dax	/dev/dax, core: file operations and dax-mmap	2016-05-20 22:02:55 -07:00
dca
devfreq
dio
dma	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
dma-buf
edac	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2016-05-17 17:05:30 -07:00
eisa
extcon
firewire
firmware	driver core update for 4.7-rc1	2016-05-20 21:26:15 -07:00
fmc
fpga
gpio	gpio: drop lock before reading GPIO direction	2016-05-30 17:11:59 +02:00
gpu	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
hid	Merge branch 'for-4.7/wacom' into for-linus	2016-05-17 12:42:27 +02:00
hsi
hv
hwmon	Merge branch 'hwmon-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging	2016-05-26 09:48:23 -07:00
hwspinlock	drivers/hwspinlock: use correct radix tree API	2016-05-20 17:58:30 -07:00
hwtracing	Char / Misc driver update for 4.7-rc1	2016-05-20 21:20:31 -07:00
i2c	i2c: dev: use after free in detach	2016-05-28 17:37:42 +02:00
ide
idle
iio	Staging and IIO driver update for 4.7-rc1	2016-05-20 22:20:48 -07:00
infiniband	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2016-05-28 12:04:17 -07:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2016-05-27 19:14:35 -07:00
iommu	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
ipack
irqchip	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2016-05-28 16:41:39 -07:00
isdn	TTY and Serial driver update for 4.7-rc1	2016-05-20 20:57:27 -07:00
leds	pwm: Changes for v4.7-rc1	2016-05-25 10:40:15 -07:00
lguest
lightnvm
macintosh
mailbox
mcb
md	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2016-05-27 14:28:09 -07:00
media	Merge branch 'hash' of git://ftp.sciencehorizons.net/linux	2016-05-28 16:15:25 -07:00
memory	MTD updates for v4.7:	2016-05-24 11:00:20 -07:00
memstick	drivers/memstick/core/mspro_block: use kmemdup	2016-05-23 17:04:14 -07:00
message	SCSI misc on 20160517	2016-05-18 16:38:59 -07:00
mfd	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
misc	Char / Misc driver update for 4.7-rc1	2016-05-20 21:20:31 -07:00
mmc	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
mtd	This pull request contains mostly cleanups and minor	2016-05-27 18:49:29 -07:00
net	brcmfmac: don't remove interface on link down firmware event	2016-06-16 18:12:01 +03:00
nfc
ntb
nubus
nvdimm	DAX error handling for 4.7	2016-05-26 19:34:26 -07:00
nvme	nvme/host: Add missing blk_integrity tag_size + flags assignments	2016-05-17 17:14:21 -06:00
nvmem	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
of	MTD updates for v4.7:	2016-05-24 11:00:20 -07:00
oprofile
parisc
parport
pci	Char / Misc driver update for 4.7-rc1	2016-05-20 21:20:31 -07:00
pcmcia
perf
phy	USB patches for 4.7-rc1	2016-05-20 21:12:25 -07:00
pinctrl	drivers/pinctrl/intel/pinctrl-baytrail.c: fix build with gcc-4.4	2016-05-26 15:35:44 -07:00
platform	platform/chrome: Driver and binding changes for 4.7	2016-05-28 12:32:01 -07:00
pnp	driver core update for 4.7-rc1	2016-05-20 21:26:15 -07:00
power	power supply and reset changes for the v4.7 series	2016-05-20 14:06:21 -07:00
powercap	Power management material for v4.7-rc1	2016-05-16 19:17:22 -07:00
pps
ps3
ptp	ptp: oops in ptp_ioctl()	2016-05-29 22:32:27 -07:00
pwm	pwm: Changes for v4.7-rc1	2016-05-25 10:40:15 -07:00
rapidio
ras
regulator	regulator: pwm: Use pwm_get_args() where appropriate	2016-05-17 14:45:02 +02:00
remoteproc	remoteproc: Add additional crash reasons	2016-05-12 15:50:19 -07:00
reset
rpmsg
rtc	rtc: tps6586x: rename so module can be autoloaded	2016-05-21 17:07:17 +02:00
s390	DAX error handling for 4.7	2016-05-26 19:34:26 -07:00
sbus	openprom: fix warning	2016-05-20 18:33:37 -07:00
scsi	SCSI fixes on 20160529	2016-05-29 13:28:39 -07:00
sfi
sh
sn
soc	soc: mtk-pmic-wrap: avoid integer overflow warning	2016-05-19 15:20:24 +02:00
spi	sound updates #2 for 4.7-rc1	2016-05-28 12:23:12 -07:00
spmi
ssb
staging	Round two of 4.7 merge window patches	2016-05-28 11:04:16 -07:00
target	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2016-05-28 12:04:17 -07:00
tc
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2016-05-26 09:23:43 -07:00
thunderbolt
tty	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
uio
usb	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2016-05-28 12:04:17 -07:00
uwb
vfio	VFIO updates for v4.7-rc1	2016-05-25 09:47:26 -07:00
vhost
video	remove lots of IS_ERR_VALUE abuses	2016-05-27 15:26:11 -07:00
virt
virtio	virtio_balloon: fix PFN format for virtio-1	2016-05-22 19:44:13 +03:00
vlynq
vme
w1
watchdog	Merge git://www.linux-watchdog.org/linux-watchdog	2016-05-25 10:19:17 -07:00
xen	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2016-05-28 12:04:17 -07:00
zorro
Kconfig	libnvdimm for 4.7	2016-05-23 11:18:01 -07:00
Makefile	/dev/dax, pmem: direct access to persistent memory	2016-05-20 22:02:53 -07:00