mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-12 09:56:45 +07:00
99b7623380
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> |
||
|---|---|---|
| .. | ||
| act200l-sir.c | ||
| actisys-sir.c | ||
| ali-ircc.c | ||
| ali-ircc.h | ||
| au1k_ir.c | ||
| au1000_ircc.h | ||
| donauboe.c | ||
| donauboe.h | ||
| ep7211-sir.c | ||
| esi-sir.c | ||
| girbil-sir.c | ||
| irda-usb.c | ||
| irda-usb.h | ||
| irtty-sir.c | ||
| irtty-sir.h | ||
| Kconfig | ||
| kingsun-sir.c | ||
| ks959-sir.c | ||
| ksdazzle-sir.c | ||
| litelink-sir.c | ||
| ma600-sir.c | ||
| Makefile | ||
| mcp2120-sir.c | ||
| mcs7780.c | ||
| mcs7780.h | ||
| nsc-ircc.c | ||
| nsc-ircc.h | ||
| old_belkin-sir.c | ||
| pxaficp_ir.c | ||
| sa1100_ir.c | ||
| sir_dev.c | ||
| sir_dongle.c | ||
| sir-dev.h | ||
| smsc-ircc2.c | ||
| smsc-ircc2.h | ||
| smsc-sio.h | ||
| stir4200.c | ||
| tekram-sir.c | ||
| toim3232-sir.c | ||
| via-ircc.c | ||
| via-ircc.h | ||
| vlsi_ir.c | ||
| vlsi_ir.h | ||
| w83977af_ir.c | ||
| w83977af_ir.h | ||
| w83977af.h | ||