mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-11-30 17:36:41 +07:00
0ebea80880
Under some unusual context-switching patterns, it is possible to end up with multiple threads from the same mm running concurrently with different ASIDs: 1. CPU x schedules task t with mm p containing ASID a and generation g This task doesn't block and the CPU doesn't context switch. So: * per_cpu(active_asid, x) = {g,a} * p->context.id = {g,a} 2. Some other CPU generates an ASID rollover. The global generation is now (g + 1). CPU x is still running t, with no context switch and so per_cpu(reserved_asid, x) = {g,a} 3. CPU y schedules task t', which shares mm p with t. The generation mismatches, so we take the slowpath and hit the reserved ASID from CPU x. p is then updated so that p->context.id = {g + 1,a} 4. CPU y schedules some other task u, which has an mm != p. 5. Some other CPU generates *another* CPU rollover. The global generation is now (g + 2). CPU x is still running t, with no context switch and so per_cpu(reserved_asid, x) = {g,a}. 6. CPU y once again schedules task t', but now *fails* to hit the reserved ASID from CPU x because of the generation mismatch. This results in a new ASID being allocated, despite the fact that t is still running on CPU x with the same mm. Consequently, TLBIs (e.g. as a result of CoW) will not be synchronised between the two threads. This patch fixes the problem by updating all of the matching reserved ASIDs when we hit on the slowpath (i.e. in step 3 above). This keeps the reserved ASIDs in-sync with the mm and avoids the problem. Reported-by: Tony Thompson <anthony.thompson@arm.com> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
216 lines
6.0 KiB
C
216 lines
6.0 KiB
C
/*
|
|
* Based on arch/arm/mm/context.c
|
|
*
|
|
* Copyright (C) 2002-2003 Deep Blue Solutions Ltd, all rights reserved.
|
|
* Copyright (C) 2012 ARM Ltd.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/mm.h>
|
|
|
|
#include <asm/cpufeature.h>
|
|
#include <asm/mmu_context.h>
|
|
#include <asm/tlbflush.h>
|
|
|
|
static u32 asid_bits;
|
|
static DEFINE_RAW_SPINLOCK(cpu_asid_lock);
|
|
|
|
static atomic64_t asid_generation;
|
|
static unsigned long *asid_map;
|
|
|
|
static DEFINE_PER_CPU(atomic64_t, active_asids);
|
|
static DEFINE_PER_CPU(u64, reserved_asids);
|
|
static cpumask_t tlb_flush_pending;
|
|
|
|
#define ASID_MASK (~GENMASK(asid_bits - 1, 0))
|
|
#define ASID_FIRST_VERSION (1UL << asid_bits)
|
|
#define NUM_USER_ASIDS ASID_FIRST_VERSION
|
|
|
|
static void flush_context(unsigned int cpu)
|
|
{
|
|
int i;
|
|
u64 asid;
|
|
|
|
/* Update the list of reserved ASIDs and the ASID bitmap. */
|
|
bitmap_clear(asid_map, 0, NUM_USER_ASIDS);
|
|
|
|
/*
|
|
* Ensure the generation bump is observed before we xchg the
|
|
* active_asids.
|
|
*/
|
|
smp_wmb();
|
|
|
|
for_each_possible_cpu(i) {
|
|
asid = atomic64_xchg_relaxed(&per_cpu(active_asids, i), 0);
|
|
/*
|
|
* If this CPU has already been through a
|
|
* rollover, but hasn't run another task in
|
|
* the meantime, we must preserve its reserved
|
|
* ASID, as this is the only trace we have of
|
|
* the process it is still running.
|
|
*/
|
|
if (asid == 0)
|
|
asid = per_cpu(reserved_asids, i);
|
|
__set_bit(asid & ~ASID_MASK, asid_map);
|
|
per_cpu(reserved_asids, i) = asid;
|
|
}
|
|
|
|
/* Queue a TLB invalidate and flush the I-cache if necessary. */
|
|
cpumask_setall(&tlb_flush_pending);
|
|
|
|
if (icache_is_aivivt())
|
|
__flush_icache_all();
|
|
}
|
|
|
|
static bool check_update_reserved_asid(u64 asid, u64 newasid)
|
|
{
|
|
int cpu;
|
|
bool hit = false;
|
|
|
|
/*
|
|
* Iterate over the set of reserved ASIDs looking for a match.
|
|
* If we find one, then we can update our mm to use newasid
|
|
* (i.e. the same ASID in the current generation) but we can't
|
|
* exit the loop early, since we need to ensure that all copies
|
|
* of the old ASID are updated to reflect the mm. Failure to do
|
|
* so could result in us missing the reserved ASID in a future
|
|
* generation.
|
|
*/
|
|
for_each_possible_cpu(cpu) {
|
|
if (per_cpu(reserved_asids, cpu) == asid) {
|
|
hit = true;
|
|
per_cpu(reserved_asids, cpu) = newasid;
|
|
}
|
|
}
|
|
|
|
return hit;
|
|
}
|
|
|
|
static u64 new_context(struct mm_struct *mm, unsigned int cpu)
|
|
{
|
|
static u32 cur_idx = 1;
|
|
u64 asid = atomic64_read(&mm->context.id);
|
|
u64 generation = atomic64_read(&asid_generation);
|
|
|
|
if (asid != 0) {
|
|
u64 newasid = generation | (asid & ~ASID_MASK);
|
|
|
|
/*
|
|
* If our current ASID was active during a rollover, we
|
|
* can continue to use it and this was just a false alarm.
|
|
*/
|
|
if (check_update_reserved_asid(asid, newasid))
|
|
return newasid;
|
|
|
|
/*
|
|
* We had a valid ASID in a previous life, so try to re-use
|
|
* it if possible.
|
|
*/
|
|
asid &= ~ASID_MASK;
|
|
if (!__test_and_set_bit(asid, asid_map))
|
|
return newasid;
|
|
}
|
|
|
|
/*
|
|
* Allocate a free ASID. If we can't find one, take a note of the
|
|
* currently active ASIDs and mark the TLBs as requiring flushes.
|
|
* We always count from ASID #1, as we use ASID #0 when setting a
|
|
* reserved TTBR0 for the init_mm.
|
|
*/
|
|
asid = find_next_zero_bit(asid_map, NUM_USER_ASIDS, cur_idx);
|
|
if (asid != NUM_USER_ASIDS)
|
|
goto set_asid;
|
|
|
|
/* We're out of ASIDs, so increment the global generation count */
|
|
generation = atomic64_add_return_relaxed(ASID_FIRST_VERSION,
|
|
&asid_generation);
|
|
flush_context(cpu);
|
|
|
|
/* We have at least 1 ASID per CPU, so this will always succeed */
|
|
asid = find_next_zero_bit(asid_map, NUM_USER_ASIDS, 1);
|
|
|
|
set_asid:
|
|
__set_bit(asid, asid_map);
|
|
cur_idx = asid;
|
|
return asid | generation;
|
|
}
|
|
|
|
void check_and_switch_context(struct mm_struct *mm, unsigned int cpu)
|
|
{
|
|
unsigned long flags;
|
|
u64 asid;
|
|
|
|
asid = atomic64_read(&mm->context.id);
|
|
|
|
/*
|
|
* The memory ordering here is subtle. We rely on the control
|
|
* dependency between the generation read and the update of
|
|
* active_asids to ensure that we are synchronised with a
|
|
* parallel rollover (i.e. this pairs with the smp_wmb() in
|
|
* flush_context).
|
|
*/
|
|
if (!((asid ^ atomic64_read(&asid_generation)) >> asid_bits)
|
|
&& atomic64_xchg_relaxed(&per_cpu(active_asids, cpu), asid))
|
|
goto switch_mm_fastpath;
|
|
|
|
raw_spin_lock_irqsave(&cpu_asid_lock, flags);
|
|
/* Check that our ASID belongs to the current generation. */
|
|
asid = atomic64_read(&mm->context.id);
|
|
if ((asid ^ atomic64_read(&asid_generation)) >> asid_bits) {
|
|
asid = new_context(mm, cpu);
|
|
atomic64_set(&mm->context.id, asid);
|
|
}
|
|
|
|
if (cpumask_test_and_clear_cpu(cpu, &tlb_flush_pending))
|
|
local_flush_tlb_all();
|
|
|
|
atomic64_set(&per_cpu(active_asids, cpu), asid);
|
|
raw_spin_unlock_irqrestore(&cpu_asid_lock, flags);
|
|
|
|
switch_mm_fastpath:
|
|
cpu_switch_mm(mm->pgd, mm);
|
|
}
|
|
|
|
static int asids_init(void)
|
|
{
|
|
int fld = cpuid_feature_extract_field(read_cpuid(ID_AA64MMFR0_EL1), 4);
|
|
|
|
switch (fld) {
|
|
default:
|
|
pr_warn("Unknown ASID size (%d); assuming 8-bit\n", fld);
|
|
/* Fallthrough */
|
|
case 0:
|
|
asid_bits = 8;
|
|
break;
|
|
case 2:
|
|
asid_bits = 16;
|
|
}
|
|
|
|
/* If we end up with more CPUs than ASIDs, expect things to crash */
|
|
WARN_ON(NUM_USER_ASIDS < num_possible_cpus());
|
|
atomic64_set(&asid_generation, ASID_FIRST_VERSION);
|
|
asid_map = kzalloc(BITS_TO_LONGS(NUM_USER_ASIDS) * sizeof(*asid_map),
|
|
GFP_KERNEL);
|
|
if (!asid_map)
|
|
panic("Failed to allocate bitmap for %lu ASIDs\n",
|
|
NUM_USER_ASIDS);
|
|
|
|
pr_info("ASID allocator initialised with %lu entries\n", NUM_USER_ASIDS);
|
|
return 0;
|
|
}
|
|
early_initcall(asids_init);
|