Jassi Brar c7dacf5b0f mailbox: avoid timer start from callback ... If the txdone is done by polling, it is possible for msg_submit() to start the timer while txdone_hrtimer() callback is running. If the timer needs recheduling, it could already be enqueued by the time hrtimer_forward_now() is called, leading hrtimer to loudly complain. WARNING: CPU: 3 PID: 74 at kernel/time/hrtimer.c:932 hrtimer_forward+0xc4/0x110 CPU: 3 PID: 74 Comm: kworker/u8:1 Not tainted 5.9.0-rc2-00236-gd3520067d01c-dirty #5 Hardware name: Libre Computer AML-S805X-AC (DT) Workqueue: events_freezable_power_ thermal_zone_device_check pstate: 20000085 (nzCv daIf -PAN -UAO BTYPE=--) pc : hrtimer_forward+0xc4/0x110 lr : txdone_hrtimer+0xf8/0x118 [...] This can be fixed by not starting the timer from the callback path. Which requires the timer reloading as long as any message is queued on the channel, and not just when current tx is not done yet. Fixes: 0cc67945ea ("mailbox: switch to hrtimer for tx_complete polling") Reported-by: Da Xue <da@libre.computer> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> Tested-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Jerome Brunet <jbrunet@baylibre.com> Tested-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>		2020-10-16 19:09:17 -05:00
..
arm_mhu_db.c	mailbox: arm_mhu: Add ARM MHU doorbell driver	2020-10-12 21:10:34 -05:00
arm_mhu.c	mailbox: arm_mhu: Match only if compatible is "arm,mhu"	2020-10-12 21:10:34 -05:00
armada-37xx-rwtm-mailbox.c
bcm2835-mailbox.c
bcm-flexrm-mailbox.c
bcm-pdc-mailbox.c	mailbox: bcm: convert tasklets to use new tasklet_setup() API	2020-10-12 21:10:34 -05:00
hi3660-mailbox.c
hi6220-mailbox.c
imx-mailbox.c	mailbox: imx: Mark PM functions as __maybe_unused	2020-08-03 23:28:36 -05:00
Kconfig	mailbox: Add support for Qualcomm IPCC	2020-05-30 18:43:23 -05:00
mailbox-altera.c
mailbox-sti.c
mailbox-test.c
mailbox-xgene-slimpro.c
mailbox.c	mailbox: avoid timer start from callback	2020-10-16 19:09:17 -05:00
mailbox.h
Makefile	mailbox: arm_mhu: Add ARM MHU doorbell driver	2020-10-12 21:10:34 -05:00
mtk-cmdq-mailbox.c	maiblox: mediatek: Fix handling of platform_get_irq() error	2020-10-12 21:10:34 -05:00
omap-mailbox.c	mailbox: Replace HTTP links with HTTPS ones	2020-08-03 23:24:43 -05:00
pcc.c	mailbox: pcc: Put the PCCT table for error path	2020-08-03 23:25:19 -05:00
pl320-ipc.c
platform_mhu.c
qcom-apcs-ipc-mailbox.c	mailbox: qcom: Add msm8994 apcs compatible	2020-08-03 23:31:34 -05:00
qcom-ipcc.c	mailbox: Add support for Qualcomm IPCC	2020-05-30 18:43:23 -05:00
rockchip-mailbox.c
sprd-mailbox.c	mailbox: sprd: Add Spreadtrum mailbox driver	2020-05-30 18:05:33 -05:00
stm32-ipcc.c
sun6i-msgbox.c
tegra-hsp.c
ti-msgmgr.c	mailbox: Replace HTTP links with HTTPS ones	2020-08-03 23:24:43 -05:00
zynqmp-ipi-mailbox.c	mailbox: zynqmp-ipi: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()	2020-05-30 18:08:40 -05:00