AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-23 18:48:01 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity
f8f4adc1c1
linux_dsm_epyc7002/drivers/scsi
History
Arnd Bergmann f8f4adc1c1 scsi: myrb: fix sprintf buffer overflow warning 
gcc warns that the 12 byte fw_version field might not be long enough to
contain the generated firmware name string:

drivers/scsi/myrb.c: In function 'myrb_get_hba_config':
drivers/scsi/myrb.c:1052:38: error: '%02d' directive writing between 2 and 3 bytes into a region of size between 2 and 5 [-Werror=format-overflow=]
  sprintf(cb->fw_version, "%d.%02d-%c-%02d",
                                      ^~~~
drivers/scsi/myrb.c:1052:26: note: directive argument in the range [0, 255]
  sprintf(cb->fw_version, "%d.%02d-%c-%02d",
                          ^~~~~~~~~~~~~~~~~
drivers/scsi/myrb.c:1052:2: note: 'sprintf' output between 10 and 14 bytes into a destination of size 12
  sprintf(cb->fw_version, "%d.%02d-%c-%02d",
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   enquiry2->fw.major_version,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   enquiry2->fw.minor_version,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   enquiry2->fw.firmware_type,
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
   enquiry2->fw.turn_id);
   ~~~~~~~~~~~~~~~~~~~~~

I have not checked whether there are appropriate range checks before the
sprintf, but there is a range check after it that will bail out in case
of out of range version numbers. This means we can simply use snprintf()
instead of sprintf() to limit the output buffer size, and it will work
correctly.

Fixes: 081ff398c5 ("scsi: myrb: Add Mylex RAID controller (block interface)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-11-05 22:35:01 -05:00
..
aacraid SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
aic7xxx scsi: aic7xxx: remove set but not used variable 'shared_scb_data' 2018-09-17 02:34:16 -04:00
aic94xx scsi: aic94xx: fully convert to the generic DMA API 2018-10-17 21:58:51 -04:00
arcmsr scsi: arcmsr: Remove set but not used variables 'id, lun' 2018-10-16 18:13:59 -04:00
arm treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
be2iscsi SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
bfa SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
bnx2fc SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
bnx2i scsi: bnx2i: add error handling for ioremap_nocache 2018-06-19 22:02:25 -04:00
csiostor SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
cxgbi SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
cxlflash SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
device_handler
dpt
esas2r treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
fcoe SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
fnic scsi: fnic: replace gross legacy tag hack with blk-mq hack 2018-10-17 22:06:04 -04:00
hisi_sas scsi: hisi_sas: Fix NULL pointer dereference 2018-10-19 18:27:49 -04:00
ibmvscsi scsi: ibmvscsi: change strncpy+truncation to strlcpy 2018-07-30 23:17:53 -04:00
ibmvscsi_tgt SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
isci scsi: isci: Change sci_controller_start_task's return type to sci_status 2018-10-16 21:38:47 -04:00
libfc scsi: libfc: retry PRLI if we cannot analyse the payload 2018-10-15 23:53:37 -04:00
libsas scsi: libsas: fix a race condition when smp task timeout 2018-09-25 21:20:23 -04:00
lpfc SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
megaraid scsi: megaraid_sas: switch to generic DMA API 2018-10-17 21:58:52 -04:00
mpt3sas SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
mvsas scsi: mvsas: Remove set but not used variable 'id' 2018-10-23 21:36:02 -04:00
osd scsi: osd: initiator should use mq variant of request ending 2018-10-16 17:48:35 -04:00
pcmcia scsi: aha152x: rename the PCMCIA define 2018-11-02 00:15:23 +09:00
pm8001 scsi: pm8001: switch to generic DMA API 2018-10-17 21:58:52 -04:00
qedf scsi: qedf: fully convert to the generic DMA API 2018-10-17 21:58:53 -04:00
qedi SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
qla2xxx SCSI misc on 20181102 2018-11-03 10:34:03 -07:00
qla4xxx SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
smartpqi scsi: smartpqi: fully convert to the generic DMA API 2018-10-17 21:58:53 -04:00
snic scsi: snic: switch to generic DMA API 2018-10-17 21:58:53 -04:00
sym53c8xx_2 scsi: sym53c8xx: fix NULL pointer dereference panic in sym_int_sir() 2018-09-11 20:54:02 -04:00
ufs USB/PHY patches for 4.20-rc1 2018-10-26 08:14:13 -07:00
.gitignore
3w-9xxx.c scsi: 3w-sas: 3w-9xxx: Use unsigned char for cdb 2018-10-23 21:27:53 -04:00
3w-9xxx.h
3w-sas.c scsi: 3w-sas: 3w-9xxx: Use unsigned char for cdb 2018-10-23 21:27:53 -04:00
3w-sas.h
3w-xxxx.c scsi: 3w-xxx: fully convert to the generic DMA API 2018-10-17 21:58:51 -04:00
3w-xxxx.h scsi: 3w-xxx: fully convert to the generic DMA API 2018-10-17 21:58:51 -04:00
53c700_d.h_shipped
53c700.c
53c700.h scsi: 53c700: Fix spelling of 'NEGOTIATION' 2018-08-30 07:27:22 -04:00
53c700.scr
a100u2w.c scsi: a100u2w: switch to generic DMA API 2018-10-17 21:58:51 -04:00
a100u2w.h
a2091.c
a2091.h
a3000.c
a3000.h
a4000t.c
advansys.c scsi: advansys: remove unused variable 'srb_tag' in adv_isr_callback 2018-10-17 21:01:59 -04:00
aha152x.c scsi: aha152x: rename the PCMCIA define 2018-11-02 00:15:23 +09:00
aha152x.h
aha1542.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
aha1542.h
aha1740.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
aha1740.h scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
am53c974.c scsi: esp_scsi: move dma mapping into the core code 2018-10-15 23:00:38 -04:00
atari_scsi.c
atp870u.c scsi: atp870u: switch to generic DMA API 2018-10-17 21:58:52 -04:00
atp870u.h
BusLogic.c scsi: BusLogic: switch to generic DMA API 2018-10-17 21:58:51 -04:00
BusLogic.h
bvme6000_scsi.c
ch.c scsi: core: check for equality of result byte values 2018-06-26 12:27:06 -04:00
constants.c
dc395x.c scsi: dc395x: use generic DMA API 2018-10-17 21:34:20 -04:00
dc395x.h
dmx3191d.c
dpt_i2o.c
dpti.h
esp_scsi.c scsi: esp_scsi: Optimize PIO loops 2018-10-17 21:38:29 -04:00
esp_scsi.h scsi: esp_scsi: De-duplicate PIO routines 2018-10-17 21:38:20 -04:00
FlashPoint.c scsi: FlashPoint: Remove unnecessary parentheses 2018-09-25 20:45:53 -04:00
g_NCR5380.c
gdth_ioctl.h
gdth_proc.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
gdth_proc.h
gdth.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
gdth.h scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
gvp11.c
gvp11.h
hosts.c Revert "scsi: core: avoid host-wide host_busy counter for scsi_mq" 2018-08-27 13:17:00 -04:00
hpsa_cmd.h
hpsa.c SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
hpsa.h scsi: hpsa: correct enclosure sas address 2018-07-10 22:25:03 -04:00
hptiop.c
hptiop.h
imm.c scsi: don't add scsi command result bytes 2018-06-26 12:27:07 -04:00
imm.h
initio.c
initio.h
ipr.c scsi: ipr: System hung while dlpar adding primary ipr adapter back 2018-09-21 12:35:39 -04:00
ipr.h scsi: ipr: System hung while dlpar adding primary ipr adapter back 2018-09-21 12:35:39 -04:00
ips.c scsi: ips: switch to generic DMA API 2018-10-17 21:58:53 -04:00
ips.h
iscsi_boot_sysfs.c
iscsi_tcp.c scsi: iscsi_tcp: Explicitly cast param in iscsi_sw_tcp_host_get_param 2018-10-16 21:50:06 -04:00
iscsi_tcp.h
jazz_esp.c scsi: esp_scsi: move dma mapping into the core code 2018-10-15 23:00:38 -04:00
Kconfig powerpc: remove CONFIG_MCA leftovers 2018-11-02 00:15:24 +09:00
lasi700.c
libiscsi_tcp.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
libiscsi.c SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
mac53c94.c treewide: kmalloc() -> kmalloc_array() 2018-06-12 16:19:22 -07:00
mac53c94.h
mac_esp.c scsi: esp_scsi: De-duplicate PIO routines 2018-10-17 21:38:20 -04:00
mac_scsi.c
Makefile scsi: myrs: Add Mylex RAID controller (SCSI interface) 2018-10-17 21:07:54 -04:00
megaraid.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
megaraid.h scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
mesh.c scsi: mesh: switch to generic DMA API 2018-10-17 21:58:53 -04:00
mesh.h
mvme16x_scsi.c
mvme147.c
mvme147.h
mvumi.c scsi: mvumi: switch to generic DMA API 2018-10-17 21:58:52 -04:00
mvumi.h
myrb.c scsi: myrb: fix sprintf buffer overflow warning 2018-11-05 22:35:01 -05:00
myrb.h scsi: myrb: Add Mylex RAID controller (block interface) 2018-10-17 21:06:49 -04:00
myrs.c scsi: myrs: Fix the processor absent message in processor_show() 2018-10-19 18:31:37 -04:00
myrs.h scsi: myrs: Add Mylex RAID controller (SCSI interface) 2018-10-17 21:07:54 -04:00
ncr53c8xx.c scsi: ncr53c8xx: remove ScsiResult macro 2018-07-10 22:42:47 -04:00
ncr53c8xx.h
NCR5380.c scsi: NCR5380: Check for bus reset 2018-09-28 02:22:43 -04:00
NCR5380.h scsi: NCR5380: Have NCR5380_select() return a bool 2018-09-28 02:17:51 -04:00
nsp32_debug.c scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
nsp32_io.h
nsp32.c scsi: nsp32: switch to generic DMA API 2018-10-17 21:58:52 -04:00
nsp32.h
osst_detect.h
osst_options.h
osst.c treewide: Use array_size() in vmalloc() 2018-06-12 16:19:22 -07:00
osst.h
pmcraid.c treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
pmcraid.h
ppa.c
ppa.h
ps3rom.c
qla1280.c scsi: qla1280: switch to generic DMA API 2018-10-17 21:58:53 -04:00
qla1280.h
qlogicfas408.c
qlogicfas408.h
qlogicfas.c
qlogicpti.c scsi: read host_busy via scsi_host_busy() 2018-06-26 12:53:26 -04:00
qlogicpti.h
raid_class.c scsi: raid_attrs: fix unused variable warning 2018-08-30 07:21:04 -04:00
script_asm.pl
scsi_common.c
scsi_debug.c SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
scsi_debugfs.c
scsi_debugfs.h
scsi_devinfo.c
scsi_dh.c
scsi_error.c scsi: core: Remove scsi_block_when_processing_errors: message 2018-10-17 20:54:20 -04:00
scsi_ioctl.c scsi: core: check for equality of result byte values 2018-06-26 12:27:06 -04:00
scsi_lib_dma.c
scsi_lib.c SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
scsi_logging.c
scsi_logging.h
scsi_netlink.c
scsi_pm.c block: Move power management code into a new source file 2018-09-26 15:11:28 -06:00
scsi_priv.h
scsi_proc.c
scsi_sas_internal.h
scsi_scan.c scsi: core: check for equality of result byte values 2018-06-26 12:27:06 -04:00
scsi_sysctl.c
scsi_sysfs.c scsi: core: Avoid that SCSI device removal through sysfs triggers a deadlock 2018-08-02 15:53:36 -04:00
scsi_trace.c
scsi_transport_api.h
scsi_transport_fc.c SCSI misc on 20180815 2018-08-15 22:06:26 -07:00
scsi_transport_iscsi.c block: remove parent device reference from struct bsg_class_device 2018-05-29 13:00:25 -06:00
scsi_transport_sas.c scsi: libsas: delete dead code in scsi_transport_sas.c 2018-09-25 21:20:23 -04:00
scsi_transport_spi.c scsi: core: check for equality of result byte values 2018-06-26 12:27:06 -04:00
scsi_transport_srp.c for-4.18/block-20180603 2018-06-04 07:58:06 -07:00
scsi.c scsi: read host_busy via scsi_host_busy() 2018-06-26 12:53:26 -04:00
scsi.h scsi: core: remove Scsi_Cmnd typedef 2018-06-19 22:02:25 -04:00
scsicam.c
sd_dif.c block: move dif_prepare/dif_complete functions to block layer 2018-07-30 08:27:02 -06:00
sd_zbc.c block: Introduce blk_revalidate_disk_zones() 2018-10-25 11:17:40 -06:00
sd.c block: Introduce blk_revalidate_disk_zones() 2018-10-25 11:17:40 -06:00
sd.h block: Introduce blk_revalidate_disk_zones() 2018-10-25 11:17:40 -06:00
sense_codes.h
ses.c treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
sg.c scsi: sg: remove bad blk_end_request_all() call 2018-10-16 17:49:57 -04:00
sgiwd93.c
sim710.c
sni_53c710.c
sr_ioctl.c block: Switch struct packet_command to use struct scsi_sense_hdr 2018-08-02 15:22:13 -06:00
sr_vendor.c
sr.c block: genhd: add 'groups' argument to device_add_disk 2018-09-28 08:30:28 -06:00
sr.h
st_options.h
st.c scsi: st: remove redundant pointer STbuffer 2018-08-08 21:15:54 -04:00
st.h
stex.c
storvsc_drv.c use the new async probing feature for the hyperv drivers 2018-07-03 13:02:28 +02:00
sun3_scsi_vme.c
sun3_scsi.c
sun3x_esp.c scsi: esp_scsi: move dma mapping into the core code 2018-10-15 23:00:38 -04:00
sun_esp.c scsi: esp_scsi: move dma mapping into the core code 2018-10-15 23:00:38 -04:00
virtio_scsi.c scsi: virtio_scsi: fix pi_bytes{out,in} on 4 KiB block size devices 2018-07-26 15:49:43 -06:00
vmw_pvscsi.c scsi: vmw_pscsi: switch to generic DMA API 2018-10-17 21:58:53 -04:00
vmw_pvscsi.h
wd33c93.c
wd33c93.h
wd719x.c
wd719x.h
xen-scsifront.c scsi: xen-scsifront: add error handling for xenbus_printf 2018-06-19 14:54:41 +02:00
zalon.c
zorro7xx.c
zorro_esp.c scsi: esp_scsi: De-duplicate PIO routines 2018-10-17 21:38:20 -04:00