linux_dsm_epyc7002/drivers/gpu/drm/panfrost
Steven Price 5b3ec8134f drm/panfrost: Handle resetting on timeout better
Panfrost uses multiple schedulers (one for each slot, so 2 in reality),
and on a timeout has to stop all the schedulers to safely perform a
reset. However more than one scheduler can trigger a timeout at the same
time. This race condition results in jobs being freed while they are
still in use.

When stopping other slots use cancel_delayed_work_sync() to ensure that
any timeout started for that slot has completed. Also use
mutex_trylock() to obtain reset_lock. This means that only one thread
attempts the reset, the other threads will simply complete without doing
anything (the first thread will wait for this in the call to
cancel_delayed_work_sync()).

While we're here and since the function is already dependent on
sched_job not being NULL, let's remove the unnecessary checks.

Fixes: aa20236784 ("drm/panfrost: Prevent concurrent resets")
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191009094456.9704-1-steven.price@arm.com
2019-10-15 11:38:22 -05:00
..
Kconfig drm/panfrost: Require the simple_ondemand governor 2019-06-10 09:30:34 -06:00
Makefile drm/panfrost: Add madvise and shrinker support 2019-08-08 15:57:36 -06:00
panfrost_devfreq.c drm/panfrost: Remove NULL checks for regulator 2019-09-19 11:45:44 -05:00
panfrost_devfreq.h drm/panfrost: Remove opp table when unloading 2019-08-19 11:38:51 -05:00
panfrost_device.c drm/panfrost: Fix regulator_get_optional() misuse 2019-09-19 11:45:44 -05:00
panfrost_device.h drm/panfrost: Remove unnecessary hwaccess_lock spin_lock 2019-08-30 09:53:52 -05:00
panfrost_drv.c drm/panfrost: Rework runtime PM initialization 2019-08-30 09:51:41 -05:00
panfrost_features.h
panfrost_gem_shrinker.c drm/panfrost: Use mutex_trylock in panfrost_gem_purge 2019-08-28 10:02:39 -05:00
panfrost_gem.c drm/panfrost: Fix sleeping while atomic in panfrost_gem_open 2019-08-22 20:44:19 -05:00
panfrost_gem.h drm/panfrost: Implement per FD address spaces 2019-08-19 11:34:57 -05:00
panfrost_gpu.c drm/panfrost: Add missing GPU feature registers 2019-10-14 13:46:48 -05:00
panfrost_gpu.h
panfrost_issues.h
panfrost_job.c drm/panfrost: Handle resetting on timeout better 2019-10-15 11:38:22 -05:00
panfrost_job.h
panfrost_mmu.c drm fixes for 5.4-rc1 2019-09-27 11:13:35 -07:00
panfrost_mmu.h drm/panfrost: Implement per FD address spaces 2019-08-19 11:34:57 -05:00
panfrost_perfcnt.c drm/panfrost: Expose performance counters through unstable ioctls 2019-06-18 09:23:48 -06:00
panfrost_perfcnt.h drm/panfrost: Expose performance counters through unstable ioctls 2019-06-18 09:23:48 -06:00
panfrost_regs.h drm/panfrost: Expose performance counters through unstable ioctls 2019-06-18 09:23:48 -06:00
TODO drm/panfrost: Implement per FD address spaces 2019-08-19 11:34:57 -05:00