Filipe David Borba Manana f717175024 Btrfs: fix race conditions in BTRFS_IOC_FS_INFO ioctl ... The handler for the ioctl BTRFS_IOC_FS_INFO was reading the number of devices before acquiring the device list mutex. This could lead to inconsistent results because the update of the device list and the number of devices counter (amongst other counters related to the device list) are updated in volumes.c while holding the device list mutex - except for 2 places, one was volumes.c:btrfs_prepare_sprout() and the other was volumes.c:device_list_add(). For example, if we have 2 devices, with IDs 1 and 2 and then add a new device, with ID 3, and while adding the device is in progress an BTRFS_IOC_FS_INFO ioctl arrives, it could return a number of devices of 2 and a max dev id of 3. This would be incorrect. Also, this ioctl handler was reading the fsid while it can be updated concurrently. This can happen when while a new device is being added and the current filesystem is in seeding mode. Example: $ mkfs.btrfs -f /dev/sdb1 $ mkfs.btrfs -f /dev/sdb2 $ btrfstune -S 1 /dev/sdb1 $ mount /dev/sdb1 /mnt/test $ btrfs device add /dev/sdb2 /mnt/test If during the last step a BTRFS_IOC_FS_INFO ioctl was requested, it could read an fsid that was never valid (some bits part of the old fsid and others part of the new fsid). Also, it could read a number of devices that doesn't match the number of devices in the list and the max device id, as explained before. Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com> Signed-off-by: Chris Mason <chris.mason@fusionio.com>		2013-09-01 08:16:25 -04:00
..
tests	Btrfs: separate out tests into their own directory	2013-09-01 08:15:38 -04:00
acl.c	Btrfs: skip adding an acl attribute if we don't have to	2012-12-16 20:46:15 -05:00
async-thread.c	Btrfs: call the ordered free operation without any locks held	2012-07-25 16:15:07 -04:00
async-thread.h	btrfs: return void in functions without error conditions	2012-03-22 01:45:34 +01:00
backref.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
backref.h	Btrfs: cleanup backref search commit root flag stuff	2013-07-01 08:52:29 -04:00
btrfs_inode.h	Btrfs: don't cache the csum value into the extent state tree	2013-09-01 08:04:33 -04:00
check-integrity.c	Btrfs: Use %z to format size_t	2013-09-01 08:16:19 -04:00
check-integrity.h	Btrfs: add optional integrity check code	2011-12-21 19:14:09 +01:00
compat.h	Btrfs: drop remaining LINUX_KERNEL_VERSION checks and compat code	2009-01-06 09:38:55 -05:00
compression.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
compression.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
ctree.c	Btrfs: Make btrfs_header_chunk_tree_uuid() return unsigned long	2013-09-01 08:16:16 -04:00
ctree.h	Btrfs: Make btrfs_header_chunk_tree_uuid() return unsigned long	2013-09-01 08:16:16 -04:00
delayed-inode.c	Btrfs: fix printing of non NULL terminated string	2013-09-01 08:16:20 -04:00
delayed-inode.h	[readdir] convert btrfs	2013-06-29 12:57:00 +04:00
delayed-ref.c	Btrfs: get rid of sparse warnings	2013-09-01 08:15:50 -04:00
delayed-ref.h	Btrfs: handle running extent ops with skinny metadata	2013-05-17 21:40:15 -04:00
dev-replace.c	Btrfs: Make BTRFS_DEV_REPLACE_DEVID an unsigned long long constant	2013-09-01 08:16:09 -04:00
dev-replace.h	Btrfs: add new sources for device replace code	2012-12-12 17:15:41 -05:00
dir-item.c	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
disk-io.c	Btrfs: fix race between removing a dev and writing sbs	2013-09-01 08:16:24 -04:00
disk-io.h	Btrfs: introduce grab/put functions for the root of the fs/file tree	2013-06-14 11:29:38 -04:00
export.c	Btrfs: cleanup: don't check the same thing twice	2013-06-14 11:29:30 -04:00
export.h	NFS support for btrfs - v3	2008-09-25 11:04:06 -04:00
extent_io.c	Btrfs: PAGE_CACHE_SIZE is already unsigned long	2013-09-01 08:16:17 -04:00
extent_io.h	btrfs: mark some local function as 'static'	2013-09-01 08:15:51 -04:00
extent_map.c	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
extent_map.h	Btrfs: fix bad extent logging	2013-05-06 15:54:34 -04:00
extent-tree.c	Btrfs: remove ourselves from the cluster list under lock	2013-09-01 08:16:23 -04:00
file-item.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
file.c	Btrfs: avoid starting a transaction in the write path	2013-09-01 08:05:05 -04:00
free-space-cache.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
free-space-cache.h	Btrfs: separate out tests into their own directory	2013-09-01 08:15:38 -04:00
hash.h	btrfs: extended inode refs	2012-10-09 09:14:45 -04:00
inode-item.c	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
inode-map.c	Btrfs: don't use global block reservation for inode cache truncation	2013-05-17 21:40:22 -04:00
inode-map.h	Btrfs: Support reading/writing on disk free ino cache	2011-04-25 16:46:11 +08:00
inode.c	Btrfs: do not clear our orphan item runtime flag on eexist	2013-09-01 08:16:22 -04:00
ioctl.c	Btrfs: fix race conditions in BTRFS_IOC_FS_INFO ioctl	2013-09-01 08:16:25 -04:00
Kconfig	btrfs: move leak debug code to functions	2013-05-06 15:55:16 -04:00
locking.c	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
locking.h	Btrfs: remove btrfs_try_spin_lock	2013-03-14 14:57:10 -04:00
lzo.c	Btrfs: return -1 when lzo compression makes data bigger	2013-09-01 07:57:19 -04:00
Makefile	Btrfs: introduce a tree for items that map UUIDs to something	2013-09-01 08:15:52 -04:00
math.h	Btrfs: cleanup duplicated division functions	2012-12-11 13:31:30 -05:00
ordered-data.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
ordered-data.h	Btrfs: remove btrfs_sector_sum structure	2013-07-02 11:50:47 -04:00
orphan.c	btrfs: replace many BUG_ONs with proper error handling	2012-03-22 11:52:54 +01:00
print-tree.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
print-tree.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
qgroup.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
raid56.c	Btrfs, raid56: fix memory leak when allocating pages for p/q stripes failed	2013-09-01 08:04:27 -04:00
raid56.h	Btrfs: RAID5 and RAID6	2013-02-01 14:24:23 -05:00
rcu-string.h	Btrfs: use rcu to protect device->name	2012-06-14 21:29:16 -04:00
reada.c	Btrfs: fix reada debug code compilation	2013-05-06 15:54:55 -04:00
relocation.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
root-tree.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
scrub.c	Btrfs: Format mirror_num as int	2013-09-01 08:16:11 -04:00
send.c	Btrfs: fix send to deal with sparse files properly	2013-09-01 08:16:21 -04:00
send.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
struct-funcs.c	Btrfs: rewrite BTRFS_SETGET_FUNCS	2012-07-23 16:28:06 -04:00
super.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
sysfs.c	btrfs: fixup/remove module.h usage as required	2013-03-01 15:01:01 -05:00
transaction.c	Btrfs: Remove superfluous casts from u64 to unsigned long long	2013-09-01 08:16:08 -04:00
transaction.h	btrfs: mark some local function as 'static'	2013-09-01 08:15:51 -04:00
tree-defrag.c	btrfs: remove cache only arguments from defrag path	2013-02-20 12:59:36 -05:00
tree-log.c	Btrfs: don't ignore errors from btrfs_run_delayed_items	2013-09-01 08:04:54 -04:00
tree-log.h	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
ulist.c	Btrfs: fix crash regarding to ulist_add_merge	2013-07-02 11:50:59 -04:00
ulist.h	Btrfs: add a rb_tree to improve performance of ulist search	2013-05-06 15:54:44 -04:00
uuid-tree.c	Btrfs: check UUID tree during mount if required	2013-09-01 08:15:58 -04:00
volumes.c	Btrfs: fix race conditions in BTRFS_IOC_FS_INFO ioctl	2013-09-01 08:16:25 -04:00
volumes.h	Btrfs: add btrfs_alloc_device and switch to it	2013-09-01 08:16:04 -04:00
xattr.c	btrfs: make static code static & remove dead code	2013-05-06 15:55:23 -04:00
xattr.h	fs/vfs/security: pass last path component to LSM on inode creation	2011-02-01 11:12:29 -05:00
zlib.c	btrfs: fix message printing	2012-10-09 09:19:57 -04:00