Jason Wang f663dd9aaf net: core: explicitly select a txq before doing l2 forwarding ... Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The will cause several issues: - NETIF_F_LLTX were removed for macvlan, so txq lock were done for macvlan instead of lower device which misses the necessary txq synchronization for lower device such as txq stopping or frozen required by dev watchdog or control path. - dev_hard_start_xmit() was called with NULL txq which bypasses the net device watchdog. - dev_hard_start_xmit() does not check txq everywhere which will lead a crash when tso is disabled for lower device. Fix this by explicitly introducing a new param for .ndo_select_queue() for just selecting queues in the case of l2 forwarding offload. netdev_pick_tx() was also extended to accept this parameter and dev_queue_xmit_accel() was used to do l2 forwarding transmission. With this fixes, NETIF_F_LLTX could be preserved for macvlan and there's no need to check txq against NULL in dev_hard_start_xmit(). Also there's no need to keep a dedicated ndo_dfwd_start_xmit() and we can just reuse the code of dev_queue_xmit() to do the transmission. In the future, it was also required for macvtap l2 forwarding support since it provides a necessary synchronization method. Cc: John Fastabend <john.r.fastabend@intel.com> Cc: Neil Horman <nhorman@tuxdriver.com> Cc: e1000-devel@lists.sourceforge.net Signed-off-by: Jason Wang <jasowang@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: John Fastabend <john.r.fastabend@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2014-01-10 13:23:08 -05:00
..
3com	net: typhoon: remove unnecessary pci_set_drvdata()	2013-10-18 00:03:28 -04:00
8390	Revert "8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature"	2013-12-11 17:20:31 -05:00
adaptec	net: starfire: remove unnecessary pci_set_drvdata()	2013-10-18 00:03:28 -04:00
adi	adi: Remove extern from function prototypes	2013-09-24 10:09:18 -04:00
aeroflex	drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent	2013-08-29 21:55:23 -04:00
allwinner	net: allwinner: emac: Add missing free_irq	2013-12-10 18:01:10 -05:00
alteon
amd	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2013-11-13 17:40:34 +09:00
apple	macmace: add missing platform_set_drvdata() in mace_probe()	2013-11-11 14:02:08 -05:00
arc	arc_emac: fix potential use after free	2013-12-27 13:00:31 -05:00
atheros	atl1c: Check return from pci_find_ext_capability() in atl1c_reset_pcie()	2013-12-19 19:14:42 -05:00
broadcom	net: core: explicitly select a txq before doing l2 forwarding	2014-01-10 13:23:08 -05:00
brocade	Merge branch 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm	2013-11-14 07:55:21 +09:00
cadence	Remove GENERIC_HARDIRQ config option	2013-09-13 15:09:52 +02:00
calxeda	net: calxedaxgmac: Fix panic caused by MTU change of active interface	2013-11-07 19:25:53 -05:00
chelsio	cxgb4: allow large buffer size to have page size	2014-01-03 19:27:57 -05:00
cirrus	net: ep93xx_eth: use dev_get_platdata()	2013-08-30 17:43:35 -04:00
cisco	net: enic: remove unnecessary pci_set_drvdata()	2013-10-18 00:03:30 -04:00
davicom	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-10-23 16:49:34 -04:00
dec	net: tulip: use DEFINE_PCI_DEVICE_TABLE	2013-10-22 02:19:23 -04:00
dlink	net: dl2k: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:00 -04:00
emulex	be2net: fix max_evt_qs calculation for BE3 in SR-IOV config	2014-01-06 13:09:21 -05:00
faraday	drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent	2013-08-29 21:55:23 -04:00
freescale	fec: Revert "fec: Do not assume that PHY reset is active low"	2014-01-05 20:24:28 -05:00
fujitsu	net: fujitsu: Remove ISA depdendency from Kconfig	2013-10-07 15:52:54 -04:00
hp	hp100: replace hardcoded name in /proc/interrupts with interface name	2013-09-27 17:38:32 -04:00
i825xx	net:drivers/net: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO	2013-11-07 03:01:59 -05:00
ibm	net: do not pretend FRAGLIST support	2013-12-02 17:16:29 -05:00
icplus	net: icplus: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:01 -04:00
intel	net: core: explicitly select a txq before doing l2 forwarding	2014-01-10 13:23:08 -05:00
marvell	net: mvmdio: fix interrupt timeout handling	2013-12-19 19:20:44 -05:00
mellanox	net: core: explicitly select a txq before doing l2 forwarding	2014-01-10 13:23:08 -05:00
micrel	Merge branch 'next' of git://git.infradead.org/users/vkoul/slave-dma	2013-11-20 13:20:24 -08:00
microchip
moxa	ethernet: moxa: remove duplicate includes	2013-10-21 18:46:45 -04:00
myricom	net: myri10ge: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:02 -04:00
natsemi	xtsonic: add missing platform_set_drvdata() in xtsonic_probe()	2013-11-11 14:02:08 -05:00
neterion	Merge branch 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2013-11-14 16:30:30 +09:00
nuvoton	drivers:net: delete premature free_irq	2013-09-04 13:18:19 -04:00
nvidia	forcedeth: run loopback test only on chipsets that support it	2013-12-05 20:59:22 -05:00
nxp	DMA-API: net: nxp/lpc_eth: use dma_coerce_mask_and_coherent()	2013-10-31 14:48:56 +00:00
octeon	Merge branch 'for-linus-dma-masks' of git://git.linaro.org/people/rmk/linux-arm	2013-11-14 07:55:21 +09:00
oki-semi	pch_gbe: Validate hwtstamp_config completely before applying it	2013-11-14 16:22:10 -05:00
packetengines	net: packetengines: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:02 -04:00
pasemi	net: pasemi: remove unnecessary pci_set_drvdata()	2013-10-22 02:11:51 -04:00
qlogic	qlcnic: Fix bug in Tx completion path	2014-01-03 20:44:11 -05:00
rdc	net: r6040: remove unnecessary pci_set_drvdata()	2013-10-22 02:11:52 -04:00
realtek	net: 8139cp: fix a BUG_ON triggered by wrong bytes_compl	2013-11-29 16:18:23 -05:00
renesas	sh_eth: check platform data pointer	2013-11-04 15:49:28 -05:00
seeq	net: seeq: use dev_get_platdata()	2013-08-30 17:43:37 -04:00
sfc	sfc: Poll for MCDI completion once before timeout occurs	2013-12-06 22:27:55 +00:00
sgi	net:drivers/net: Miscellaneous conversions to ETH_ALEN	2013-10-02 17:04:45 -04:00
silan
sis	net: sis190: remove unnecessary pci_set_drvdata()	2013-10-22 02:11:52 -04:00
smsc	net: smc91x: Fix device tree based configuration so it's usable	2013-12-11 16:36:22 -05:00
stmicro	stmmac: Fix incorrect spinlock release and PTP cap detection.	2013-12-29 22:37:00 -05:00
sun	net: niu: remove unnecessary pci_set_drvdata()	2013-10-23 16:58:41 -04:00
tehuti	net: do not pretend FRAGLIST support	2013-12-02 17:16:29 -05:00
ti	drivers: net : cpsw: pass proper device name while requesting irq	2013-12-22 18:22:15 -05:00
tile	net: core: explicitly select a txq before doing l2 forwarding	2014-01-10 13:23:08 -05:00
toshiba	net: tc35815: remove unnecessary pci_set_drvdata()	2013-10-23 16:58:41 -04:00
tundra	net: tsi108: use dev_get_platdata()	2013-08-30 17:43:38 -04:00
via	via-velocity: fix netif_receive_skb use in irq disabled section.	2013-11-28 18:43:35 -05:00
wiznet	net: w5100: use dev_get_platdata()	2013-08-30 17:43:38 -04:00
xilinx	net: emaclite: add barriers to support Xilinx Zynq platform	2013-12-09 21:02:25 -05:00
xircom
xscale	ixp4xx_eth: Validate hwtstamp_config completely before applying it	2013-11-14 16:22:10 -05:00
dnet.c
dnet.h
ethoc.c	net: ethoc: use dev_get_platdata()	2013-08-30 17:43:35 -04:00
fealnx.c	net: fealnx: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:01 -04:00
jme.c	net: jme: remove unnecessary pci_set_drvdata()	2013-10-21 17:21:01 -04:00
jme.h	jme: Remove unused #define PFX	2013-11-07 02:14:32 -05:00
Kconfig	net: Add MOXA ART SoCs ethernet driver	2013-08-11 21:38:12 -07:00
korina.c	net:drivers/net: Miscellaneous conversions to ETH_ALEN	2013-10-02 17:04:45 -04:00
lantiq_etop.c	net: core: explicitly select a txq before doing l2 forwarding	2014-01-10 13:23:08 -05:00
Makefile	net: Add MOXA ART SoCs ethernet driver	2013-08-11 21:38:12 -07:00
netx-eth.c	net: netx-eth: remove unnecessary casting	2013-09-04 00:27:27 -04:00
s6gmac.c