mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-22 17:35:17 +07:00
cb88a05887
Corsair Strafe RGB keyboard does not respond to usb control messages sometimes and hence generates timeouts. Commitde3af5bf25("usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard") tried to fix those timeouts by adding USB_QUIRK_DELAY_INIT. Unfortunately, even with this quirk timeouts of usb_control_msg() can still be seen, but with a lower frequency (approx. 1 out of 15): [ 29.103520] usb 1-8: string descriptor 0 read error: -110 [ 34.363097] usb 1-8: can't set config #1, error -110 Adding further delays to different locations where usb control messages are issued just moves the timeouts to other locations, e.g.: [ 35.400533] usbhid 1-8:1.0: can't add hid device: -110 [ 35.401014] usbhid: probe of 1-8:1.0 failed with error -110 The only way to reliably avoid those issues is having a pause after each usb control message. In approx. 200 boot cycles no more timeouts were seen. Addionaly, keep USB_QUIRK_DELAY_INIT as it turned out to be necessary to have the delay in hub_port_connect() after hub_port_init(). The overall boot time seems not to be influenced by these additional delays, even on fast machines and lightweight distributions. Fixes:de3af5bf25("usb: quirks: add delay init quirk for Corsair Strafe RGB keyboard") Cc: stable@vger.kernel.org Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
70 lines
2.2 KiB
C
70 lines
2.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* This file holds the definitions of quirks found in USB devices.
|
|
* Only quirks that affect the whole device, not an interface,
|
|
* belong here.
|
|
*/
|
|
|
|
#ifndef __LINUX_USB_QUIRKS_H
|
|
#define __LINUX_USB_QUIRKS_H
|
|
|
|
/* string descriptors must not be fetched using a 255-byte read */
|
|
#define USB_QUIRK_STRING_FETCH_255 BIT(0)
|
|
|
|
/* device can't resume correctly so reset it instead */
|
|
#define USB_QUIRK_RESET_RESUME BIT(1)
|
|
|
|
/* device can't handle Set-Interface requests */
|
|
#define USB_QUIRK_NO_SET_INTF BIT(2)
|
|
|
|
/* device can't handle its Configuration or Interface strings */
|
|
#define USB_QUIRK_CONFIG_INTF_STRINGS BIT(3)
|
|
|
|
/* device can't be reset(e.g morph devices), don't use reset */
|
|
#define USB_QUIRK_RESET BIT(4)
|
|
|
|
/* device has more interface descriptions than the bNumInterfaces count,
|
|
and can't handle talking to these interfaces */
|
|
#define USB_QUIRK_HONOR_BNUMINTERFACES BIT(5)
|
|
|
|
/* device needs a pause during initialization, after we read the device
|
|
descriptor */
|
|
#define USB_QUIRK_DELAY_INIT BIT(6)
|
|
|
|
/*
|
|
* For high speed and super speed interupt endpoints, the USB 2.0 and
|
|
* USB 3.0 spec require the interval in microframes
|
|
* (1 microframe = 125 microseconds) to be calculated as
|
|
* interval = 2 ^ (bInterval-1).
|
|
*
|
|
* Devices with this quirk report their bInterval as the result of this
|
|
* calculation instead of the exponent variable used in the calculation.
|
|
*/
|
|
#define USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL BIT(7)
|
|
|
|
/* device can't handle device_qualifier descriptor requests */
|
|
#define USB_QUIRK_DEVICE_QUALIFIER BIT(8)
|
|
|
|
/* device generates spurious wakeup, ignore remote wakeup capability */
|
|
#define USB_QUIRK_IGNORE_REMOTE_WAKEUP BIT(9)
|
|
|
|
/* device can't handle Link Power Management */
|
|
#define USB_QUIRK_NO_LPM BIT(10)
|
|
|
|
/*
|
|
* Device reports its bInterval as linear frames instead of the
|
|
* USB 2.0 calculation.
|
|
*/
|
|
#define USB_QUIRK_LINEAR_FRAME_INTR_BINTERVAL BIT(11)
|
|
|
|
/*
|
|
* Device needs to be disconnected before suspend to prevent spurious
|
|
* wakeup.
|
|
*/
|
|
#define USB_QUIRK_DISCONNECT_SUSPEND BIT(12)
|
|
|
|
/* Device needs a pause after every control message. */
|
|
#define USB_QUIRK_DELAY_CTRL_MSG BIT(13)
|
|
|
|
#endif /* __LINUX_USB_QUIRKS_H */
|