Eric Dumazet f4ef85bbda ipv4: add a fib_type to fib_info ... commit d2d68ba9fe (ipv4: Cache input routes in fib_info nexthops.) introduced a regression for forwarding. This was hard to reproduce but the symptom was that packets were delivered to local host instead of being forwarded. David suggested to add fib_type to fib_info so that we dont inadvertently share same fib_info for different purposes. With help from Julian Anastasov who provided very helpful hints, reproduced here : <quote> Can it be a problem related to fib_info reuse from different routes. For example, when local IP address is created for subnet we have: broadcast 192.168.0.255 dev DEV proto kernel scope link src 192.168.0.1 192.168.0.0/24 dev DEV proto kernel scope link src 192.168.0.1 local 192.168.0.1 dev DEV proto kernel scope host src 192.168.0.1 The "dev DEV proto kernel scope link src 192.168.0.1" is a reused fib_info structure where we put cached routes. The result can be same fib_info for 192.168.0.255 and 192.168.0.0/24. RTN_BROADCAST is cached only for input routes. Incoming broadcast to 192.168.0.255 can be cached and can cause problems for traffic forwarded to 192.168.0.0/24. So, this patch should solve the problem because it separates the broadcast from unicast traffic. And the ip_route_input_slow caching will work for local and broadcast input routes (above routes 1 and 3) just because they differ in scope and use different fib_info. </quote> Many thanks to Chris Clayton for his patience and help. Reported-by: Chris Clayton <chris2553@googlemail.com> Bisected-by: Chris Clayton <chris2553@googlemail.com> Reported-by: Dave Jones <davej@redhat.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Julian Anastasov <ja@ssi.bg> Tested-by: Chris Clayton <chris2553@googlemail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2012-10-04 13:58:26 -04:00
..
acpi
asm-generic	So this is the LW GPIO patch stack for v3.7:	2012-10-02 16:05:10 -07:00
clocksource	arm64: Generic timers support	2012-09-17 13:42:20 +01:00
crypto
drm	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2012-10-02 11:11:09 -07:00
keys
linux	spi: Updates for v3.7	2012-10-02 17:26:42 -07:00
math-emu
media
memory
misc
mtd
net	ipv4: add a fib_type to fib_info	2012-10-04 13:58:26 -04:00
pcmcia
ras
rdma	IB/core: Add ib_find_exact_cached_pkey()	2012-09-30 20:33:30 -07:00
rxrpc
scsi	scsi_netlink: Remove dead and buggy code	2012-09-13 16:26:39 -04:00
sound	ASoC: Additional updates for 3.6	2012-08-20 21:26:04 +02:00
target	target: support zero allocation length in REQUEST SENSE	2012-09-07 11:14:21 -07:00
trace	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-10-01 09:06:36 -07:00
video	ARM: clps711x: Remove board support for CEIVA	2012-09-28 21:14:08 +02:00
xen	USB merge for 3.7-rc1	2012-10-01 13:23:01 -07:00
Kbuild