Lukas Wunner f3d752c6cd media: netup_unidvb: Don't leak SPI master in probe error path ... commit e297ddf296de35037fa97f4302782def196d350a upstream. If the call to spi_register_master() fails on probe of the NetUP Universal DVB driver, the spi_master struct is erroneously not freed. Likewise, if spi_new_device() fails, the spi_controller struct is not unregistered. Plug the leaks. While at it, fix an ordering issue in netup_spi_release() wherein spi_unregister_master() is called after fiddling with the IRQ control register. The correct order is to call spi_unregister_master() *before* this teardown step because bus accesses may still be ongoing until that function returns. Fixes: 52b1eaf4c5 ("[media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver") Signed-off-by: Lukas Wunner <lukas@wunner.de> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: <stable@vger.kernel.org> # v4.3+: 5e844cc37a: spi: Introduce device-managed SPI controller allocation Cc: <stable@vger.kernel.org> # v4.3+ Cc: Kozlov Sergey <serjk@netup.ru> Link: https://lore.kernel.org/r/c4c24f333fc7840f4a3db24789e6e10dd660bede.1607286887.git.lukas@wunner.de Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-12-30 11:54:04 +01:00
..
b2c2
bt8xx
cobalt
cx18
cx88
cx23885
cx25821
ddbridge
dm1105
dt3155
intel
ivtv
mantis
meye
netup_unidvb	media: netup_unidvb: Don't leak SPI master in probe error path	2020-12-30 11:54:04 +01:00
ngene
pluto2
pt1
pt3
saa7134
saa7146
saa7164
smipcie
solo6x10
sta2x11
ttpci
tw68
tw686x
tw5864
Kconfig
Makefile