AuxXxilium/linux_dsm_epyc7002
1
0
Fork 0
mirror of https://github.com/AuxXxilium/linux_dsm_epyc7002.git synced 2024-12-21 00:39:33 +07:00
Code Issues Actions Packages Projects Releases Wiki Activity
f2d254fac1
linux_dsm_epyc7002/drivers/net/ethernet/cavium/thunder
History
Jesper Dangaard Brouer e6dbe9397e Revert "net: thunderx: Add support for xdp redirect" 
This reverts commit aa136d0c82.

As I previously[1] pointed out this implementation of XDP_REDIRECT is
wrong.  XDP_REDIRECT is a facility that must work between different
NIC drivers.  Another NIC driver can call ndo_xdp_xmit/nicvf_xdp_xmit,
but your driver patch assumes payload data (at top of page) will
contain a queue index and a DMA addr, this is not true and worse will
likely contain garbage.

Given you have not fixed this in due time (just reached v4.16-rc1),
the only option I see is a revert.

[1] http://lkml.kernel.org/r/20171211130902.482513d3@redhat.com

Cc: Sunil Goutham <sgoutham@cavium.com>
Cc: Christina Jacob <cjacob@caviumnetworks.com>
Cc: Aleksey Makarov <aleksey.makarov@cavium.com>
Fixes: aa136d0c82 ("net: thunderx: Add support for xdp redirect")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-02-14 14:23:39 -05:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
nic_main.c net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name 2018-01-29 12:22:06 -05:00
nic_reg.h net: thunderx: add timestamping support 2018-01-16 14:31:14 -05:00
nic.h net: thunderx: add timestamping support 2018-01-16 14:31:14 -05:00
nicvf_ethtool.c net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name 2018-01-29 12:22:06 -05:00
nicvf_main.c Revert "net: thunderx: Add support for xdp redirect" 2018-02-14 14:23:39 -05:00
nicvf_queues.c Revert "net: thunderx: Add support for xdp redirect" 2018-02-14 14:23:39 -05:00
nicvf_queues.h Revert "net: thunderx: Add support for xdp redirect" 2018-02-14 14:23:39 -05:00
q_struct.h net: thunderx: Optimize RBDR descriptor handling 2017-05-02 15:41:20 -04:00
thunder_bgx.c net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name 2018-01-29 12:22:06 -05:00
thunder_bgx.h net: thunderx: add timestamping support 2018-01-16 14:31:14 -05:00
thunder_xcv.c net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name 2018-01-29 12:22:06 -05:00