linux_dsm_epyc7002/sound/isa
Lv Yunlong cc427a507f ALSA: sb: Fix two use after free in snd_sb_qsound_build
commit 4fb44dd2c1dda18606348acdfdb97e8759dde9df upstream.

In snd_sb_qsound_build, snd_ctl_add(..,p->qsound_switch...) and
snd_ctl_add(..,p->qsound_space..) are called. But the second
arguments of snd_ctl_add() could be freed via snd_ctl_add_replace()
->snd_ctl_free_one(). After the error code is returned,
snd_sb_qsound_destroy(p) is called in __error branch.

But in snd_sb_qsound_destroy(), the freed p->qsound_switch and
p->qsound_space are still used by snd_ctl_remove().

My patch set p->qsound_switch and p->qsound_space to NULL if
snd_ctl_add() failed to avoid the uaf bugs. But these codes need
to further be improved with the code style.

Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210426145541.8070-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-11 14:47:32 +02:00
..
ad1816a ALSA: Fix misspellings of "Analog Devices" 2020-04-17 11:38:03 +02:00
ad1848 treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
cs423x ALSA: isa: delete repeated words in comments 2020-08-06 09:29:25 +02:00
es1688 ALSA: es1688: Add the missed snd_card_free() 2020-06-03 11:40:55 +02:00
galaxy ALSA: Use fallthrough pseudo-keyword 2020-07-09 13:01:29 +02:00
gus ALSA: isa/gus: remove 'set but not used' warning 2020-07-07 12:02:24 +02:00
msnd ALSA: Use fallthrough pseudo-keyword 2020-07-09 13:01:29 +02:00
opti9xx ALSA: Use fallthrough pseudo-keyword 2020-07-09 13:01:29 +02:00
sb ALSA: sb: Fix two use after free in snd_sb_qsound_build 2021-05-11 14:47:32 +02:00
wavefront ALSA: isa/wavefront: prevent out of bounds write in ioctl 2020-05-01 12:25:49 +02:00
wss ALSA: wss: More constifications 2020-01-05 16:15:05 +01:00
adlib.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
als100.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
azt2320.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
cmi8328.c ALSA: cmi8328: More constifications 2020-01-05 16:14:59 +01:00
cmi8330.c ALSA: cmi8330: More constifications 2020-01-05 16:15:01 +01:00
es18xx.c ALSA: isa: delete repeated words in comments 2020-08-06 09:29:25 +02:00
Kconfig sound: Fix Kconfig indentation 2019-10-07 03:53:03 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
opl3sa2.c ALSA: isa: Constify snd_kcontrol_new items 2020-01-03 09:24:25 +01:00
sc6000.c ALSA: sc6000: More constification 2020-01-05 16:15:05 +01:00
sscape.c ALSA: isa: fix spelling mistakes in the comments 2020-08-16 09:37:01 +02:00