Alex Williamson 0885ea1d47 vfio/pci: Handle concurrent vma faults ... [ Upstream commit 6a45ece4c9af473555f01f0f8b97eba56e3c7d0d ] io_remap_pfn_range() will trigger a BUG_ON if it encounters a populated pte within the mapping range. This can occur because we map the entire vma on fault and multiple faults can be blocked behind the vma_lock. This leads to traces like the one reported below. We can use our vma_list to test whether a given vma is mapped to avoid this issue. [ 1591.733256] kernel BUG at mm/memory.c:2177! [ 1591.739515] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP [ 1591.747381] Modules linked in: vfio_iommu_type1 vfio_pci vfio_virqfd vfio pv680_mii(O) [ 1591.760536] CPU: 2 PID: 227 Comm: lcore-worker-2 Tainted: G O 5.11.0-rc3+ #1 [ 1591.770735] Hardware name: , BIOS HixxxxFPGA 1P B600 V121-1 [ 1591.778872] pstate: 40400009 (nZcv daif +PAN -UAO -TCO BTYPE=--) [ 1591.786134] pc : remap_pfn_range+0x214/0x340 [ 1591.793564] lr : remap_pfn_range+0x1b8/0x340 [ 1591.799117] sp : ffff80001068bbd0 [ 1591.803476] x29: ffff80001068bbd0 x28: 0000042eff6f0000 [ 1591.810404] x27: 0000001100910000 x26: 0000001300910000 [ 1591.817457] x25: 0068000000000fd3 x24: ffffa92f1338e358 [ 1591.825144] x23: 0000001140000000 x22: 0000000000000041 [ 1591.832506] x21: 0000001300910000 x20: ffffa92f141a4000 [ 1591.839520] x19: 0000001100a00000 x18: 0000000000000000 [ 1591.846108] x17: 0000000000000000 x16: ffffa92f11844540 [ 1591.853570] x15: 0000000000000000 x14: 0000000000000000 [ 1591.860768] x13: fffffc0000000000 x12: 0000000000000880 [ 1591.868053] x11: ffff0821bf3d01d0 x10: ffff5ef2abd89000 [ 1591.875932] x9 : ffffa92f12ab0064 x8 : ffffa92f136471c0 [ 1591.883208] x7 : 0000001140910000 x6 : 0000000200000000 [ 1591.890177] x5 : 0000000000000001 x4 : 0000000000000001 [ 1591.896656] x3 : 0000000000000000 x2 : 0168044000000fd3 [ 1591.903215] x1 : ffff082126261880 x0 : fffffc2084989868 [ 1591.910234] Call trace: [ 1591.914837] remap_pfn_range+0x214/0x340 [ 1591.921765] vfio_pci_mmap_fault+0xac/0x130 [vfio_pci] [ 1591.931200] __do_fault+0x44/0x12c [ 1591.937031] handle_mm_fault+0xcc8/0x1230 [ 1591.942475] do_page_fault+0x16c/0x484 [ 1591.948635] do_translation_fault+0xbc/0xd8 [ 1591.954171] do_mem_abort+0x4c/0xc0 [ 1591.960316] el0_da+0x40/0x80 [ 1591.965585] el0_sync_handler+0x168/0x1b0 [ 1591.971608] el0_sync+0x174/0x180 [ 1591.978312] Code: eb1b027f 540000c0 f9400022 b4fffe02 (d4210000) Fixes: 11c4cd07ba ("vfio-pci: Fault mmaps to enable vma tracking") Reported-by: Zeng Tao <prime.zeng@hisilicon.com> Suggested-by: Zeng Tao <prime.zeng@hisilicon.com> Link: https://lore.kernel.org/r/162497742783.3883260.3282953006487785034.stgit@omen Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-07-14 16:56:50 +02:00
..
accessibility
acpi	ACPI: bgrt: Fix CFI violation	2021-07-14 16:56:12 +02:00
amba	amba: Fix resource leak for drivers without .remove	2021-03-04 11:38:02 +01:00
android
ata	pata_ep93xx: fix deferred probing	2021-07-14 16:56:04 +02:00
atm	atm: idt77252: fix null-ptr-dereference	2021-03-30 14:31:50 +02:00
auxdisplay	auxdisplay: ht16k33: Fix refresh rate handling	2021-03-04 11:38:00 +01:00
base	drivers: base: Fix device link removal	2021-06-03 09:00:34 +02:00
bcma
block	loop: Fix missing discard support when using LOOP_CONFIGURE	2021-07-14 16:55:46 +02:00
bluetooth	Bluetooth: btqca: Don't modify firmware contents in-place	2021-07-14 16:55:34 +02:00
bus	bus: mhi: Wait for M2 state during system resume	2021-07-14 16:55:42 +02:00
cdrom	cdrom: gdrom: initialize global variable at init time	2021-05-26 12:06:55 +02:00
char	char: pcmcia: error out if 'num_bytes_read' is greater than 4 in set_protocol()	2021-07-14 16:56:39 +02:00
clk	clk: si5341: Update initialization magic	2021-07-14 16:56:31 +02:00
clocksource	clocksource/drivers/timer-ti-dm: Save and restore timer TIOCP_CFG	2021-07-14 16:56:12 +02:00
connector
counter	counter: stm32-timer-cnt: fix ceiling miss-alignment with reload register	2021-03-25 09:04:16 +01:00
cpufreq	cpufreq: Make cpufreq_online() call driver->offline() on errors	2021-07-14 16:56:13 +02:00
cpuidle	cpuidle: Fix ARM_QCOM_SPM_CPUIDLE configuration	2021-05-14 09:50:16 +02:00
crypto	crypto: nx - Fix RCU warning in nx842_OF_upd_status	2021-07-14 16:56:10 +02:00
dax	device-dax: Fix default return code of range_parse()	2021-03-04 11:38:15 +01:00
dca
devfreq	PM / devfreq: Add missing error code in devfreq_add_device()	2021-07-14 16:56:11 +02:00
dio
dma	dmaengine: mediatek: use GFP_NOWAIT instead of GFP_ATOMIC in prep_dma	2021-06-30 08:47:20 -04:00
dma-buf
edac	EDAC/Intel: Do not load EDAC driver when running as a guest	2021-07-14 16:56:00 +02:00
eisa
extcon	extcon: max8997: Add missing modalias string	2021-07-14 16:56:47 +02:00
firewire	firewire: nosy: Fix a use-after-free bug in nosy_ioctl()	2021-04-07 15:00:11 +02:00
firmware	firmware: stratix10-svc: Fix a resource leak in an error handling path	2021-07-14 16:56:39 +02:00
fpga	fpga: fpga-mgr: xilinx-spi: fix error messages on -EPROBE_DEFER	2021-05-14 09:50:06 +02:00
fsi	fsi/sbefifo: Fix reset timeout	2021-07-14 16:56:41 +02:00
gnss
gpio	gpio: AMD8111 and TQMX86 require HAS_IOPORT_MAP	2021-07-07 08:22:46 -04:00
gpu	drm/msm/dpu: Fix error return code in dpu_mdss_init()	2021-07-14 16:56:26 +02:00
greybus
hid	HID: wacom: Correct base usage for capacitive ExpressKey status bits	2021-07-14 16:56:01 +02:00
hsi	HSI: core: fix resource leaks in hsi_add_client_from_dt()	2021-05-14 09:50:28 +02:00
hv	drivers: hv: Fix missing error code in vmbus_connect()	2021-07-14 16:55:59 +02:00
hwmon	hwmon: (max31790) Fix fan speed reporting for fan7..12	2021-07-14 16:56:08 +02:00
hwspinlock
hwtracing	coresight: core: Fix use of uninitialized pointer	2021-07-14 16:56:46 +02:00
i2c	i2c: robotfuzz-osif: fix control-request directions	2021-06-30 08:47:25 -04:00
i3c	Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"	2021-05-14 09:50:05 +02:00
ide	ide/falconide: Fix module unload	2021-03-04 11:38:21 +01:00
idle
iio	iio: prox: isl29501: Fix buffer alignment in iio_push_to_buffers_with_timestamp()	2021-07-14 16:56:46 +02:00
infiniband	RDMA/core: Always release restrack object	2021-07-14 16:56:32 +02:00
input	Input: hil_kbd - fix error return code in hil_dev_connect()	2021-07-14 16:56:38 +02:00
interconnect	interconnect: qcom: Add missing MODULE_DEVICE_TABLE	2021-06-03 09:00:46 +02:00
iommu	iommu/dma: Fix IOVA reserve dma ranges	2021-07-14 16:56:42 +02:00
ipack
irqchip	irqchip/gic-v3: Workaround inconsistent PMR setting on NMI entry	2021-06-23 14:42:49 +02:00
isdn	isdn: mISDN: netjet: Fix crash in nj_probe:	2021-06-16 12:01:36 +02:00
leds	leds: ktd2692: Fix an error handling path	2021-07-14 16:56:48 +02:00
lightnvm
macintosh	macintosh/adb-iop: Use big-endian autopoll mask	2021-03-04 11:37:42 +01:00
mailbox	mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device	2021-07-14 16:56:01 +02:00
mcb
md	dm verity: fix require_signatures module_param permissions	2021-06-16 12:01:37 +02:00
media	media: video-mux: Skip dangling endpoints	2021-07-14 16:56:11 +02:00
memory	memory: samsung: exynos5422-dmc: handle clk_set_parent() failure	2021-05-14 09:50:19 +02:00
memstick	memstick: rtsx_usb_ms: fix UAF	2021-07-14 16:55:53 +02:00
message
mfd	mfd: rn5t618: Fix IRQ trigger by changing it to level mode	2021-07-14 16:56:40 +02:00
misc	habanalabs: Fix an error handling path in 'hl_pci_probe()'	2021-07-14 16:56:47 +02:00
mmc	mmc: usdhi6rol0: fix error return code in usdhi6_probe()	2021-07-14 16:56:06 +02:00
most
mtd	mtd: rawnand: marvell: add missing clk_disable_unprepare() on error in marvell_nfc_resume()	2021-07-14 16:56:47 +02:00
mux
net	mwifiex: re-fix for unaligned accesses	2021-07-14 16:56:34 +02:00
nfc	nfc: pn533: prevent potential memory corruption	2021-05-14 09:50:32 +02:00
ntb
nubus
nvdimm	libnvdimm/region: Fix nvdimm_has_flush() to handle ND_REGION_ASYNC	2021-04-21 13:00:55 +02:00
nvme	nvme-pci: look for StorageD3Enable on companion ACPI device instead	2021-07-14 16:56:11 +02:00
nvmem	drivers: nvmem: Fix voltage settings for QTI qfprom-efuse	2021-05-14 09:50:14 +02:00
of	of: Fix truncation of memory sizes on 32-bit platforms	2021-07-14 16:56:46 +02:00
opp	opp: Correct debug message in _opp_add_static_v2()	2021-03-04 11:37:27 +01:00
oprofile
parisc
parport
pci	PCI: hv: Add check for hyperv_initialized in init_hv_pci_drv()	2021-07-14 16:56:00 +02:00
pcmcia
perf	perf/arm-cmn: Fix invalid pointer when access dtc object sharing the same IRQ number	2021-07-14 16:56:08 +02:00
phy	phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe()	2021-07-14 16:56:47 +02:00
pinctrl	pinctrl: renesas: r8a77990: JTAG pins do not have pull-down capabilities	2021-07-14 16:56:16 +02:00
platform	platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard()	2021-07-14 16:56:00 +02:00
pnp
power	power: supply: bq25980: Move props from battery node	2021-05-14 09:50:25 +02:00
powercap
pps
ps3
ptp	ptp: improve max_adj check against unreasonable values	2021-06-23 14:42:45 +02:00
pwm	pwm: atmel: Fix duty cycle calculation in .get_state()	2021-05-19 10:13:04 +02:00
rapidio	rapidio: handle create_workqueue() failure	2021-05-26 12:06:52 +02:00
ras	RAS/CEC: Correct ce_add_elem()'s returned values	2021-04-14 08:42:12 +02:00
regulator	regulator: hi655x: Fix pass wrong pointer to config.driver_data	2021-07-14 16:56:09 +02:00
remoteproc	remoteproc: qcom_q6v5_mss: Validate p_filesz in ELF loader	2021-05-19 10:13:01 +02:00
reset
rpmsg	rpmsg: qcom_glink_native: fix error return code of qcom_glink_rx_data()	2021-05-19 10:13:02 +02:00
rtc	rtc: stm32: Fix unbalanced clk_disable_unprepare() on probe error path	2021-07-14 16:55:44 +02:00
s390	s390/cio: dont call css_wait_for_slow_path() inside a lock	2021-07-14 16:55:43 +02:00
sbus
scsi	scsi: mpt3sas: Fix error return value in _scsih_expander_add()	2021-07-14 16:56:47 +02:00
sfi
sh
siox
slimbus
soc	soc: aspeed: fix a ternary sign expansion bug	2021-05-14 09:50:21 +02:00
soundwire	soundwire: stream: Fix test for DP prepare complete	2021-07-14 16:56:47 +02:00
spi	spi: spi-sun6i: Fix chipselect/clock bug	2021-07-14 16:56:10 +02:00
spmi	spmi: spmi-pmic-arb: Fix hw_irq overflow	2021-03-04 11:38:40 +01:00
ssb	ssb: Fix error return code in ssb_bus_scan()	2021-07-14 16:56:21 +02:00
staging	staging: mt7621-dts: fix pci address for PCI memory range	2021-07-14 16:56:46 +02:00
target	scsi: target: core: Fix warning on realtime kernels	2021-06-18 10:00:04 +02:00
tc
tee	optee: use export_uuid() to copy client UUID	2021-06-10 13:39:21 +02:00
thermal	thermal/cpufreq_cooling: Update offline CPUs per-cpu thermal_pressure	2021-07-14 16:55:47 +02:00
thunderbolt	thunderbolt: Bond lanes only when dual_link_port != NULL in alloc_dev_default()	2021-07-14 16:56:44 +02:00
tty	serial: mvebu-uart: correctly calculate minimal possible baudrate	2021-07-14 16:56:50 +02:00
uio	uio_hv_generic: Fix a memory leak in error handling paths	2021-05-26 12:06:52 +02:00
usb	usb: dwc2: Don't reset the core after setting turnaround time	2021-07-14 16:56:43 +02:00
vdpa	{net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table	2021-06-03 09:00:36 +02:00
vfio	vfio/pci: Handle concurrent vma faults	2021-07-14 16:56:50 +02:00
vhost	vhost-vdpa: fix vm_flags for virtqueue doorbell mapping	2021-05-11 14:47:12 +02:00
video	backlight: lm3630a_bl: Put fwnode in error case during ->probe()	2021-07-14 16:56:38 +02:00
virt	nitro_enclaves: Fix stale file descriptors on failed usercopy	2021-05-11 14:47:11 +02:00
virtio
visorbus	visorbus: fix error return code in visorchipset_init()	2021-07-14 16:56:41 +02:00
vlynq
vme
w1	w1: w1_therm: Fix conversion result for negative temperatures	2021-03-04 11:37:18 +01:00
watchdog	watchdog: mei_wdt: request stop on unregister	2021-03-04 11:38:36 +01:00
xen	xen/events: reset active flag for lateeoi events later	2021-07-11 12:53:31 +02:00
zorro
Kconfig
Makefile