mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-22 15:45:09 +07:00
96d4f267e4
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
97 lines
3.0 KiB
C
97 lines
3.0 KiB
C
/*
|
|
* 32-bit ioctl compatibility routines for the i915 DRM.
|
|
*
|
|
* Copyright (C) Paul Mackerras 2005
|
|
* Copyright (C) Alan Hourihane 2005
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
|
|
* WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
* Author: Alan Hourihane <alanh@fairlite.demon.co.uk>
|
|
*/
|
|
#include <linux/compat.h>
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/i915_drm.h>
|
|
#include "i915_drv.h"
|
|
|
|
struct drm_i915_getparam32 {
|
|
s32 param;
|
|
/*
|
|
* We screwed up the generic ioctl struct here and used a variable-sized
|
|
* pointer. Use u32 in the compat struct to match the 32bit pointer
|
|
* userspace expects.
|
|
*/
|
|
u32 value;
|
|
};
|
|
|
|
static int compat_i915_getparam(struct file *file, unsigned int cmd,
|
|
unsigned long arg)
|
|
{
|
|
struct drm_i915_getparam32 req32;
|
|
drm_i915_getparam_t __user *request;
|
|
|
|
if (copy_from_user(&req32, (void __user *)arg, sizeof(req32)))
|
|
return -EFAULT;
|
|
|
|
request = compat_alloc_user_space(sizeof(*request));
|
|
if (!access_ok(request, sizeof(*request)) ||
|
|
__put_user(req32.param, &request->param) ||
|
|
__put_user((void __user *)(unsigned long)req32.value,
|
|
&request->value))
|
|
return -EFAULT;
|
|
|
|
return drm_ioctl(file, DRM_IOCTL_I915_GETPARAM,
|
|
(unsigned long)request);
|
|
}
|
|
|
|
static drm_ioctl_compat_t *i915_compat_ioctls[] = {
|
|
[DRM_I915_GETPARAM] = compat_i915_getparam,
|
|
};
|
|
|
|
/**
|
|
* i915_compat_ioctl - handle the mistakes of the past
|
|
* @filp: the file pointer
|
|
* @cmd: the ioctl command (and encoded flags)
|
|
* @arg: the ioctl argument (from userspace)
|
|
*
|
|
* Called whenever a 32-bit process running under a 64-bit kernel
|
|
* performs an ioctl on /dev/dri/card<n>.
|
|
*/
|
|
long i915_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
|
|
{
|
|
unsigned int nr = DRM_IOCTL_NR(cmd);
|
|
drm_ioctl_compat_t *fn = NULL;
|
|
int ret;
|
|
|
|
if (nr < DRM_COMMAND_BASE || nr >= DRM_COMMAND_END)
|
|
return drm_compat_ioctl(filp, cmd, arg);
|
|
|
|
if (nr < DRM_COMMAND_BASE + ARRAY_SIZE(i915_compat_ioctls))
|
|
fn = i915_compat_ioctls[nr - DRM_COMMAND_BASE];
|
|
|
|
if (fn != NULL)
|
|
ret = (*fn) (filp, cmd, arg);
|
|
else
|
|
ret = drm_ioctl(filp, cmd, arg);
|
|
|
|
return ret;
|
|
}
|