linux_dsm_epyc7002/drivers/gpu/drm/v3d
Marek Szyprowski e96418da0a drm: v3d: fix common struct sg_table related issues
The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function
returns the number of the created entries in the DMA address space.
However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and
dma_unmap_sg must be called with the original number of the entries
passed to the dma_map_sg().

struct sg_table is a common structure used for describing a non-contiguous
memory buffer, used commonly in the DRM and graphics subsystems. It
consists of a scatterlist with memory pages and DMA addresses (sgl entry),
as well as the number of scatterlist entries: CPU pages (orig_nents entry)
and DMA mapped pages (nents entry).

It turned out that it was a common mistake to misuse nents and orig_nents
entries, calling DMA-mapping functions with a wrong number of entries or
ignoring the number of mapped entries returned by the dma_map_sg()
function.

To avoid such issues, lets use a common dma-mapping wrappers operating
directly on the struct sg_table objects and use scatterlist page
iterators where possible. This, almost always, hides references to the
nents and orig_nents entries, making the code robust, easier to follow
and copy/paste safe.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
2020-09-10 08:18:35 +02:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
v3d_bo.c drm/v3d: remove _unlocked suffix in drm_gem_object_put_unlocked 2020-05-19 22:31:35 +01:00
v3d_debugfs.c drm/v3d: Delete v3d_dev->dev 2020-04-28 15:15:52 +02:00
v3d_drv.c drm/v3d: Delete v3d_dev->pdev 2020-04-28 15:15:59 +02:00
v3d_drv.h drm/v3d: Delete v3d_dev->pdev 2020-04-28 15:15:59 +02:00
v3d_fence.c drm/v3d: Add support for compute shader dispatch. 2019-04-18 09:54:10 -07:00
v3d_gem.c drm/v3d: remove _unlocked suffix in drm_gem_object_put_unlocked 2020-05-19 22:31:35 +01:00
v3d_irq.c drm/v3d: remove _unlocked suffix in drm_gem_object_put_unlocked 2020-05-19 22:31:35 +01:00
v3d_mmu.c drm: v3d: fix common struct sg_table related issues 2020-09-10 08:18:35 +02:00
v3d_regs.h drm/v3d: Fix and extend MMU error handling. 2019-05-16 09:24:52 -07:00
v3d_sched.c drm/v3d: Delete v3d_dev->dev 2020-04-28 15:15:52 +02:00
v3d_trace_points.c
v3d_trace.h drm/v3d: Add support for compute shader dispatch. 2019-04-18 09:54:10 -07:00