Nathan Chancellor e6d701dca9 ACPI: sysfs: Fix pm_profile_attr type ... When running a kernel with Clang's Control Flow Integrity implemented, there is a violation that happens when accessing /sys/firmware/acpi/pm_profile: $ cat /sys/firmware/acpi/pm_profile 0 $ dmesg ... [ 17.352564] ------------[ cut here ]------------ [ 17.352568] CFI failure (target: acpi_show_profile+0x0/0x8): [ 17.352572] WARNING: CPU: 3 PID: 497 at kernel/cfi.c:29 __cfi_check_fail+0x33/0x40 [ 17.352573] Modules linked in: [ 17.352575] CPU: 3 PID: 497 Comm: cat Tainted: G W 5.7.0-microsoft-standard+ #1 [ 17.352576] RIP: 0010:__cfi_check_fail+0x33/0x40 [ 17.352577] Code: 48 c7 c7 50 b3 85 84 48 c7 c6 50 0a 4e 84 e8 a4 d8 60 00 85 c0 75 02 5b c3 48 c7 c7 dc 5e 49 84 48 89 de 31 c0 e8 7d 06 eb ff <0f> 0b 5b c3 00 00 cc cc 00 00 cc cc 00 85 f6 74 25 41 b9 ea ff ff [ 17.352577] RSP: 0018:ffffaa6dc3c53d30 EFLAGS: 00010246 [ 17.352578] RAX: 331267e0c06cee00 RBX: ffffffff83d85890 RCX: ffffffff8483a6f8 [ 17.352579] RDX: ffff9cceabbb37c0 RSI: 0000000000000082 RDI: ffffffff84bb9e1c [ 17.352579] RBP: ffffffff845b2bc8 R08: 0000000000000001 R09: ffff9cceabbba200 [ 17.352579] R10: 000000000000019d R11: 0000000000000000 R12: ffff9cc947766f00 [ 17.352580] R13: ffffffff83d6bd50 R14: ffff9ccc6fa80000 R15: ffffffff845bd328 [ 17.352582] FS: 00007fdbc8d13580(0000) GS:ffff9cce91ac0000(0000) knlGS:0000000000000000 [ 17.352582] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 17.352583] CR2: 00007fdbc858e000 CR3: 00000005174d0000 CR4: 0000000000340ea0 [ 17.352584] Call Trace: [ 17.352586] ? rev_id_show+0x8/0x8 [ 17.352587] ? __cfi_check+0x45bac/0x4b640 [ 17.352589] ? kobj_attr_show+0x73/0x80 [ 17.352590] ? sysfs_kf_seq_show+0xc1/0x140 [ 17.352592] ? ext4_seq_options_show.cfi_jt+0x8/0x8 [ 17.352593] ? seq_read+0x180/0x600 [ 17.352595] ? sysfs_create_file_ns.cfi_jt+0x10/0x10 [ 17.352596] ? tlbflush_read_file+0x8/0x8 [ 17.352597] ? __vfs_read+0x6b/0x220 [ 17.352598] ? handle_mm_fault+0xa23/0x11b0 [ 17.352599] ? vfs_read+0xa2/0x130 [ 17.352599] ? ksys_read+0x6a/0xd0 [ 17.352601] ? __do_sys_getpgrp+0x8/0x8 [ 17.352602] ? do_syscall_64+0x72/0x120 [ 17.352603] ? entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 17.352604] ---[ end trace 7b1fa81dc897e419 ]--- When /sys/firmware/acpi/pm_profile is read, sysfs_kf_seq_show is called, which in turn calls kobj_attr_show, which gets the ->show callback member by calling container_of on attr (casting it to struct kobj_attribute) then calls it. There is a CFI violation because pm_profile_attr is of type struct device_attribute but kobj_attr_show calls ->show expecting it to be from struct kobj_attribute. CFI checking ensures that function pointer types match when doing indirect calls. Fix pm_profile_attr to be defined in terms of kobj_attribute so there is no violation or mismatch. Fixes: 362b646062 ("ACPI: Export FADT pm_profile integer value to userspace") Link: https://github.com/ClangBuiltLinux/linux/issues/1051 Reported-by: yuu ichii <byahu140@heisei.be> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Cc: 3.10+ <stable@vger.kernel.org> # 3.10+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2020-06-22 17:13:38 +02:00
..
acpica	ACPICA: iASL: add new OperationRegion subtype keyword PlatformRtMechanism	2020-06-05 13:34:23 +02:00
apei	ACPI updates for 5.8-rc1	2020-06-02 13:25:52 -07:00
arm64	ACPI/IORT: Remove the unused __get_pci_rid()	2020-05-26 20:43:33 +01:00
dptf	ACPI: DPTF: Add battery participant driver	2020-05-25 12:05:26 +02:00
nfit	libnvdimm for 5.8	2020-06-13 13:04:36 -07:00
numa	virtio-mem: Allow to specify an ACPI PXM as nid	2020-06-04 15:36:52 -04:00
pmic	ACPI / PMIC: Add i2c address for thermal control	2020-05-18 12:57:24 +02:00
x86	ACPI: Convert to new X86 CPU match macros	2020-03-24 21:30:50 +01:00
ac.c	ACPI / AC: Cleanup DMI quirk table	2020-03-04 10:32:50 +01:00
acpi_adxl.c	ACPI/ADXL: Add address translation interface using an ACPI DSM	2018-10-16 10:03:00 +02:00
acpi_amba.c	Merge 5.2-rc6 into char-misc-next	2019-06-23 09:23:33 +02:00
acpi_apd.c	ACPI / APD: Add clock frequency for Hisilicon Hip08-Lite I2C controller	2020-02-03 12:03:18 +01:00
acpi_cmos_rtc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
acpi_configfs.c	ACPICA: make acpi_load_table() return table index	2019-10-28 22:12:46 +01:00
acpi_dbg.c	ACPI: debug: Make two functions static	2020-05-09 11:33:07 +02:00
acpi_extlog.c	EDAC: Drop the EDAC report status checks	2020-04-14 16:01:01 +02:00
acpi_ipmi.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
acpi_lpat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
acpi_lpit.c	ACPI: LPIT: Put the low power idle table after using it	2020-05-09 11:29:16 +02:00
acpi_lpss.c	PM: sleep: core: Rename dev_pm_smart_suspend_and_suspended()	2020-04-24 21:32:41 +02:00
acpi_memhotplug.c	mm/memory_hotplug: rename walk_memory_range() and pass start+size instead of pfns	2019-07-18 17:08:06 -07:00
acpi_pad.c	ACPI, x86: Add Zhaoxin processors support for NONSTOP TSC	2019-06-22 11:45:57 +02:00
acpi_platform.c	ACPI: platform: Unregister stale platform devices	2019-10-17 23:48:39 +02:00
acpi_pnp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
acpi_processor.c	ACPI: processor: Export acpi_processor_evaluate_cst()	2019-12-27 11:02:07 +01:00
acpi_tad.c	PM: sleep: core: Rename DPM_FLAG_LEAVE_SUSPENDED	2020-04-24 21:34:22 +02:00
acpi_video.c	ACPI: video: remove redundant assignments to variable result	2020-03-04 10:43:04 +01:00
acpi_watchdog.c	ACPI: watchdog: Put the watchdog action table after parsing	2020-05-09 11:29:17 +02:00
battery.c	ACPI / battery: Cleanup Lenovo Ideapad Miix 320 DMI table entry	2020-03-04 10:32:50 +01:00
bgrt.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
blacklist.c	ACPI: blacklist: fix clang warning for unused DMI table	2019-07-11 22:45:00 +02:00
bus.c	ACPI: bus: Fix NULL pointer check in acpi_bus_get_private_data()	2019-11-29 11:42:10 +01:00
button.c	ACPI: Delete unused proc filename macros	2020-05-14 13:49:33 +02:00
cm_sbs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
container.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
cppc_acpi.c	ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe()	2020-05-28 13:47:53 +02:00
custom_method.c	Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2019-09-28 08:14:15 -07:00
debugfs.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
device_pm.c	Merge branches 'pm-cpufreq' and 'pm-acpi'	2020-06-10 17:10:40 +02:00
device_sysfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
dock.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
ec_sys.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 482	2019-06-19 17:09:52 +02:00
ec.c	ACPI updates for 5.8-rc1	2020-06-02 13:25:52 -07:00
event.c	ACPI: event: replace strcpy() by strscpy()	2019-04-23 10:54:26 +02:00
evged.c	ACPI: GED: use correct trigger type field in _Exx / _Lxx handling	2020-05-27 17:51:49 +02:00
fan.c	ACPI: fan: Use scnprintf() for avoiding potential buffer overflow	2020-03-14 11:11:58 +01:00
glue.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
hed.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
internal.h	ACPI: EC: PM: Avoid premature returns from acpi_s2idle_wake()	2020-05-11 10:11:38 +02:00
ioapic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
irq.c	Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-07-08 11:01:13 -07:00
Kconfig	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
Makefile	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
nvs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428	2019-06-05 17:37:16 +02:00
osi.c	ACPI: OSI: Shoot duplicate word	2019-11-13 11:12:08 +01:00
osl.c	ACPI: OSL: Add missing __acquires/__releases annotations	2020-03-04 10:40:48 +01:00
pci_irq.c	ACPI / PCI: fix acpi_pci_irq_enable() memory leak	2019-09-03 09:41:25 +02:00
pci_link.c	ACPI: Delete unused proc filename macros	2020-05-14 13:49:33 +02:00
pci_mcfg.c	PCI: Constify struct pci_ecam_ops	2020-05-01 16:28:59 +01:00
pci_root.c	Merge branch 'pci/misc'	2020-06-04 12:59:11 -05:00
pci_slot.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 491	2019-06-19 17:09:52 +02:00
power.c	ACPI: Delete unused proc filename macros	2020-05-14 13:49:33 +02:00
pptt.c	ACPI: PPTT: Consistently use unsigned int as parameter type	2020-01-07 11:46:36 +01:00
proc.c	ACPI: list_for_each_safe() -> list_for_each_entry_safe()	2020-03-04 10:48:00 +01:00
processor_core.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
processor_driver.c	cpufreq: Use per-policy frequency QoS	2019-10-21 02:05:21 +02:00
processor_idle.c	ACPI: processor: idle: Allow probing on platforms with one ACPI C-state	2020-04-27 10:32:44 +02:00
processor_pdc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
processor_perflib.c	ACPI: processor: Add QoS requests for all CPUs	2019-10-25 11:33:48 +02:00
processor_thermal.c	ACPI: processor: Add QoS requests for all CPUs	2019-10-25 11:33:48 +02:00
processor_throttling.c	x86: ACPI: fix CPU hotplug deadlock	2020-04-04 16:28:24 +02:00
property.c	device property: Add a function to obtain a node's prefix	2019-10-11 11:26:55 +02:00
reboot.c	ACPI: Allow CONFIG_PCI to be unset for reboot	2018-12-20 10:19:49 +01:00
resource.c	acpi: Use pr_warn instead of pr_warning	2019-10-18 15:00:19 +02:00
sbs.c	ACPI: Delete unused proc filename macros	2020-05-14 13:49:33 +02:00
sbshc.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 372	2019-06-05 17:37:10 +02:00
sbshc.h	ACPI: SBS: remove unused const variable 'SMBUS_PEC'	2019-08-23 12:55:09 +02:00
scan.c	More power management updates for 5.8-rc1	2020-06-10 14:04:39 -07:00
sleep.c	ACPI updates for 5.8-rc1	2020-06-02 13:25:52 -07:00
sleep.h	ACPI: PM: Add acpi_[un]register_wakeup_handler()	2020-04-04 19:45:18 +02:00
spcr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sysfs.c	ACPI: sysfs: Fix pm_profile_attr type	2020-06-22 17:13:38 +02:00
tables.c	ACPICA: Add NHLT table signature	2020-03-30 14:52:33 +02:00
thermal.c	ACPI: thermal: switch to use <linux/units.h> helpers	2020-01-31 10:30:39 -08:00
tiny-power-button.c	ACPI: Add new tiny-power-button driver to directly signal init	2020-02-13 23:36:23 +01:00
utils.c	ACPI: utils: Add acpi_evaluate_reg() helper	2020-05-09 11:40:25 +02:00
video_detect.c	ACPI: video: Use native backlight on Acer TravelMate 5735Z	2020-05-25 11:58:51 +02:00
wakeup.c	ACPI: PM: Add acpi_[un]register_wakeup_handler()	2020-04-04 19:45:18 +02:00