linux_dsm_epyc7002/arch/alpha/lib
Mathieu Desnoyers 3ddc5b46a8 kernel-wide: fix missing validations on __get/__put/__copy_to/__copy_from_user()
I found the following pattern that leads in to interesting findings:

  grep -r "ret.*|=.*__put_user" *
  grep -r "ret.*|=.*__get_user" *
  grep -r "ret.*|=.*__copy" *

The __put_user() calls in compat_ioctl.c, ptrace compat, signal compat,
since those appear in compat code, we could probably expect the kernel
addresses not to be reachable in the lower 32-bit range, so I think they
might not be exploitable.

For the "__get_user" cases, I don't think those are exploitable: the worse
that can happen is that the kernel will copy kernel memory into in-kernel
buffers, and will fail immediately afterward.

The alpha csum_partial_copy_from_user() seems to be missing the
access_ok() check entirely.  The fix is inspired from x86.  This could
lead to information leak on alpha.  I also noticed that many architectures
map csum_partial_copy_from_user() to csum_partial_copy_generic(), but I
wonder if the latter is performing the access checks on every
architectures.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-09-11 15:58:18 -07:00
..
callback_srm.S Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00
checksum.c spelling fixes: arch/alpha/ 2007-10-20 01:04:37 +02:00
clear_page.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
clear_user.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
copy_page.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
copy_user.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
csum_ipv6_magic.S alpha: fix alignment problem in csum_ipv6_magic() 2007-06-24 08:59:11 -07:00
csum_partial_copy.c kernel-wide: fix missing validations on __get/__put/__copy_to/__copy_from_user() 2013-09-11 15:58:18 -07:00
dbg_current.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dbg_stackcheck.S fix file specification in comments 2006-10-03 23:01:26 +02:00
dbg_stackkill.S fix file specification in comments 2006-10-03 23:01:26 +02:00
dec_and_lock.c atomic: use <linux/atomic.h> 2011-07-26 16:49:47 -07:00
divide.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-clear_page.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-clear_user.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-copy_page.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-copy_user.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-csum_ipv6_magic.S alpha: fix alignment problem in csum_ipv6_magic() 2007-06-24 08:59:11 -07:00
ev6-divide.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-memchr.S [PATCH] bitops: alpha: use config options instead of __alpha_fix__ and __alpha_cix__ 2006-03-26 08:57:09 -08:00
ev6-memcpy.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-memset.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-stxcpy.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev6-stxncpy.S alpha: strncpy/strncat fixes 2007-12-17 19:28:15 -08:00
ev67-strcat.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev67-strchr.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev67-strlen.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev67-strncat.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ev67-strrchr.S Fix common misspellings 2011-03-31 11:26:23 -03:00
fls.c Fix common misspellings 2011-03-31 11:26:23 -03:00
fpreg.c [PATCH] bitops: alpha: use config options instead of __alpha_fix__ and __alpha_cix__ 2006-03-26 08:57:09 -08:00
Makefile alpha: Use new generic strncpy_from_user() and strnlen_user() 2012-08-19 08:41:18 -07:00
memchr.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
memcpy.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
memmove.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
memset.S fix file specification in comments 2006-10-03 23:01:26 +02:00
srm_printk.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
srm_puts.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
stacktrace.c Disintegrate asm/system.h for Alpha 2012-03-28 18:11:12 +01:00
strcat.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
strchr.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
strcpy.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
strlen.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
strncat.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
strncpy.S alpha: strncpy/strncat fixes 2007-12-17 19:28:15 -08:00
strrchr.S Fix common misspellings 2011-03-31 11:26:23 -03:00
stxcpy.S Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
stxncpy.S alpha: strncpy/strncat fixes 2007-12-17 19:28:15 -08:00
udelay.c Remove obsolete #include <linux/config.h> 2006-06-30 19:25:36 +02:00