mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-17 22:36:43 +07:00
db6711b7a1
In power7_marked_instr_event() there is a switch case that is missing a break or an explicit fallthrough, it's not immediately clear which it should be. The function determines based on the PMU event code, whether the event is a "marked" event (which then requires us to configure the PMU in a certain way). On Power7 there is no specific bit(s) in the event to tell us that, we just have to know. Rather than having a full list of every event and whether they are marked, we pull apart the event code and for events with certain values of certain fields we can say that those are all marked events. We take the psel (bits 0-7) of the event, and look at bits 4-7. For a value of 6 we say that if the entire psel == 0x64 then if the pmc == 3 the event is marked, else not, and otherwise we continue. It is then that we fallthrough to the 8 case, where we return true if the unit == 0xd. The question is should the 6 case also fallthrough and check for unit == 0xd, or should it return. Looking at the full list of events we see that there are zero events where (psel >> 4) == 0x6 and unit == 0xd. So the answer is it doesn't really matter, there are no valid event codes that will return a different result whether we fallthrough or break. But equally, testing the 6 case events against unit == 0xd is slightly bogus, as there are no such events. So to make the code clearer, and avoid any future confusion, have the 6 case break rather than falling through. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> |
||
|---|---|---|
| .. | ||
| req-gen | ||
| 8xx-pmu.c | ||
| bhrb.S | ||
| callchain.c | ||
| core-book3s.c | ||
| core-fsl-emb.c | ||
| e500-pmu.c | ||
| e6500-pmu.c | ||
| hv-24x7-catalog.h | ||
| hv-24x7-domains.h | ||
| hv-24x7.c | ||
| hv-24x7.h | ||
| hv-common.c | ||
| hv-common.h | ||
| hv-gpci-requests.h | ||
| hv-gpci.c | ||
| hv-gpci.h | ||
| imc-pmu.c | ||
| isa207-common.c | ||
| isa207-common.h | ||
| Makefile | ||
| mpc7450-pmu.c | ||
| perf_regs.c | ||
| power5-pmu.c | ||
| power5+-pmu.c | ||
| power6-pmu.c | ||
| power7-events-list.h | ||
| power7-pmu.c | ||
| power8-events-list.h | ||
| power8-pmu.c | ||
| power9-events-list.h | ||
| power9-pmu.c | ||
| ppc970-pmu.c | ||