mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-26 21:35:20 +07:00
3c6b8625dd
When unloading the bochs-drm driver, a warning message is printed by
drm_mode_config_cleanup() because a reference is still held to one of
the drm_connector structs.
Correct this by calling drm_atomic_helper_shutdown() in
bochs_pci_remove().
Fixes: 6579c39594
("drm/bochs: atomic: switch planes to atomic, wire up helpers.")
Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
Link: http://patchwork.freedesktop.org/patch/msgid/93b363ad62f4938d9ddf3e05b2a61e3f66b2dcd3.1558416473.git.sbobroff@linux.ibm.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
219 lines
4.8 KiB
C
219 lines
4.8 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
|
|
#include "bochs.h"
|
|
|
|
static int bochs_modeset = -1;
|
|
module_param_named(modeset, bochs_modeset, int, 0444);
|
|
MODULE_PARM_DESC(modeset, "enable/disable kernel modesetting");
|
|
|
|
/* ---------------------------------------------------------------------- */
|
|
/* drm interface */
|
|
|
|
static void bochs_unload(struct drm_device *dev)
|
|
{
|
|
struct bochs_device *bochs = dev->dev_private;
|
|
|
|
bochs_kms_fini(bochs);
|
|
bochs_mm_fini(bochs);
|
|
bochs_hw_fini(dev);
|
|
kfree(bochs);
|
|
dev->dev_private = NULL;
|
|
}
|
|
|
|
static int bochs_load(struct drm_device *dev)
|
|
{
|
|
struct bochs_device *bochs;
|
|
int ret;
|
|
|
|
bochs = kzalloc(sizeof(*bochs), GFP_KERNEL);
|
|
if (bochs == NULL)
|
|
return -ENOMEM;
|
|
dev->dev_private = bochs;
|
|
bochs->dev = dev;
|
|
|
|
ret = bochs_hw_init(dev);
|
|
if (ret)
|
|
goto err;
|
|
|
|
ret = bochs_mm_init(bochs);
|
|
if (ret)
|
|
goto err;
|
|
|
|
ret = bochs_kms_init(bochs);
|
|
if (ret)
|
|
goto err;
|
|
|
|
return 0;
|
|
|
|
err:
|
|
bochs_unload(dev);
|
|
return ret;
|
|
}
|
|
|
|
static const struct file_operations bochs_fops = {
|
|
.owner = THIS_MODULE,
|
|
DRM_VRAM_MM_FILE_OPERATIONS
|
|
};
|
|
|
|
static struct drm_driver bochs_driver = {
|
|
.driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC |
|
|
DRIVER_PRIME,
|
|
.fops = &bochs_fops,
|
|
.name = "bochs-drm",
|
|
.desc = "bochs dispi vga interface (qemu stdvga)",
|
|
.date = "20130925",
|
|
.major = 1,
|
|
.minor = 0,
|
|
DRM_GEM_VRAM_DRIVER,
|
|
DRM_GEM_VRAM_DRIVER_PRIME,
|
|
};
|
|
|
|
/* ---------------------------------------------------------------------- */
|
|
/* pm interface */
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
static int bochs_pm_suspend(struct device *dev)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(dev);
|
|
struct drm_device *drm_dev = pci_get_drvdata(pdev);
|
|
|
|
return drm_mode_config_helper_suspend(drm_dev);
|
|
}
|
|
|
|
static int bochs_pm_resume(struct device *dev)
|
|
{
|
|
struct pci_dev *pdev = to_pci_dev(dev);
|
|
struct drm_device *drm_dev = pci_get_drvdata(pdev);
|
|
|
|
return drm_mode_config_helper_resume(drm_dev);
|
|
}
|
|
#endif
|
|
|
|
static const struct dev_pm_ops bochs_pm_ops = {
|
|
SET_SYSTEM_SLEEP_PM_OPS(bochs_pm_suspend,
|
|
bochs_pm_resume)
|
|
};
|
|
|
|
/* ---------------------------------------------------------------------- */
|
|
/* pci interface */
|
|
|
|
static int bochs_pci_probe(struct pci_dev *pdev,
|
|
const struct pci_device_id *ent)
|
|
{
|
|
struct drm_device *dev;
|
|
unsigned long fbsize;
|
|
int ret;
|
|
|
|
fbsize = pci_resource_len(pdev, 0);
|
|
if (fbsize < 4 * 1024 * 1024) {
|
|
DRM_ERROR("less than 4 MB video memory, ignoring device\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev, 0, "bochsdrmfb");
|
|
if (ret)
|
|
return ret;
|
|
|
|
dev = drm_dev_alloc(&bochs_driver, &pdev->dev);
|
|
if (IS_ERR(dev))
|
|
return PTR_ERR(dev);
|
|
|
|
ret = pci_enable_device(pdev);
|
|
if (ret)
|
|
goto err_free_dev;
|
|
|
|
dev->pdev = pdev;
|
|
pci_set_drvdata(pdev, dev);
|
|
|
|
ret = bochs_load(dev);
|
|
if (ret)
|
|
goto err_free_dev;
|
|
|
|
ret = drm_dev_register(dev, 0);
|
|
if (ret)
|
|
goto err_unload;
|
|
|
|
drm_fbdev_generic_setup(dev, 32);
|
|
return ret;
|
|
|
|
err_unload:
|
|
bochs_unload(dev);
|
|
err_free_dev:
|
|
drm_dev_put(dev);
|
|
return ret;
|
|
}
|
|
|
|
static void bochs_pci_remove(struct pci_dev *pdev)
|
|
{
|
|
struct drm_device *dev = pci_get_drvdata(pdev);
|
|
|
|
drm_atomic_helper_shutdown(dev);
|
|
drm_dev_unregister(dev);
|
|
bochs_unload(dev);
|
|
drm_dev_put(dev);
|
|
}
|
|
|
|
static const struct pci_device_id bochs_pci_tbl[] = {
|
|
{
|
|
.vendor = 0x1234,
|
|
.device = 0x1111,
|
|
.subvendor = PCI_SUBVENDOR_ID_REDHAT_QUMRANET,
|
|
.subdevice = PCI_SUBDEVICE_ID_QEMU,
|
|
.driver_data = BOCHS_QEMU_STDVGA,
|
|
},
|
|
{
|
|
.vendor = 0x1234,
|
|
.device = 0x1111,
|
|
.subvendor = PCI_ANY_ID,
|
|
.subdevice = PCI_ANY_ID,
|
|
.driver_data = BOCHS_UNKNOWN,
|
|
},
|
|
{ /* end of list */ }
|
|
};
|
|
|
|
static struct pci_driver bochs_pci_driver = {
|
|
.name = "bochs-drm",
|
|
.id_table = bochs_pci_tbl,
|
|
.probe = bochs_pci_probe,
|
|
.remove = bochs_pci_remove,
|
|
.driver.pm = &bochs_pm_ops,
|
|
};
|
|
|
|
/* ---------------------------------------------------------------------- */
|
|
/* module init/exit */
|
|
|
|
static int __init bochs_init(void)
|
|
{
|
|
if (vgacon_text_force() && bochs_modeset == -1)
|
|
return -EINVAL;
|
|
|
|
if (bochs_modeset == 0)
|
|
return -EINVAL;
|
|
|
|
return pci_register_driver(&bochs_pci_driver);
|
|
}
|
|
|
|
static void __exit bochs_exit(void)
|
|
{
|
|
pci_unregister_driver(&bochs_pci_driver);
|
|
}
|
|
|
|
module_init(bochs_init);
|
|
module_exit(bochs_exit);
|
|
|
|
MODULE_DEVICE_TABLE(pci, bochs_pci_tbl);
|
|
MODULE_AUTHOR("Gerd Hoffmann <kraxel@redhat.com>");
|
|
MODULE_LICENSE("GPL");
|