Pablo Neira Ayuso db3b665dd7 netfilter: nft_set_rbtree: bogus lookup/get on consecutive elements in named sets ... The existing rbtree implementation might store consecutive elements where the closing element and the opening element might overlap, eg. [ a, a+1) [ a+1, a+2) This patch removes the optimization for non-anonymous sets in the exact matching case, where it is assumed to stop searching in case that the closing element is found. Instead, invalidate candidate interval and keep looking further in the tree. The lookup/get operation might return false, while there is an element in the rbtree. Moreover, the get operation returns true as if a+2 would be in the tree. This happens with named sets after several set updates. The existing lookup optimization (that only works for the anonymous sets) might not reach the opening [ a+1,... element if the closing ...,a+1) is found in first place when walking over the rbtree. Hence, walking the full tree in that case is needed. This patch fixes the lookup and get operations. Fixes: e701001e7c ("netfilter: nft_rbtree: allow adjacent intervals with dynamic updates") Fixes: ba0e4d9917 ("netfilter: nf_tables: get set elements via netlink") Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2019-12-09 13:13:25 +01:00
..
6lowpan	6lowpan: no need to check return value of debugfs_create functions	2019-07-06 12:50:01 +02:00
9p	9p pull request for inclusion in 5.4	2019-09-27 15:10:34 -07:00
802	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
8021q	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
appletalk	appletalk: enforce CAP_NET_RAW for raw sockets	2019-09-24 16:37:18 +02:00
atm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-22 16:27:24 -08:00
ax25	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
batman-adv	batman-adv: Drop lockdep.h include for soft-interface.c	2019-11-03 08:30:58 +01:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
bpf	bpf: Fix memory leak on object 'data'	2019-11-18 19:32:59 -08:00
bpfilter	Kbuild updates for v5.3	2019-07-12 16:03:16 -07:00
bridge	bridge: implement get_link_ksettings ethtool method	2019-11-12 19:52:15 -08:00
caif	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-02 13:54:56 -07:00
can	can: j1939: warn if resources are still linked on destroy	2019-11-13 10:42:34 +01:00
ceph	libceph: use ceph_kvmalloc() for osdmap arrays	2019-09-16 12:06:25 +02:00
core	net: skmsg: fix TLS 1.3 crash with full sk_msg	2019-11-28 22:40:29 -08:00
dcb	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201	2019-05-30 11:29:52 -07:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-09 11:04:37 -08:00
decnet	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
dns_resolver	Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"	2019-07-10 18:43:43 -07:00
dsa	net: phylink: rename mac_link_state() op to mac_pcs_get_state()	2019-11-23 16:13:39 -08:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2019-11-07 20:07:30 -08:00
hsr	hsr: switch ->dellink() to ->ndo_uninit()	2019-07-11 14:37:45 -07:00
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-02 13:54:56 -07:00
ife	net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
ipv4	net: skmsg: fix TLS 1.3 crash with full sk_msg	2019-11-28 22:40:29 -08:00
ipv6	net: port < inet_prot_sock(net) --> inet_port_requires_bind_service(net, port)	2019-11-26 13:20:46 -08:00
iucv	net/af_iucv: mark expected switch fall-throughs	2019-07-29 10:26:14 -07:00
kcm	kcm: disable preemption in kcm_parse_func_strparser()	2019-09-27 10:27:14 +02:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
l2tp	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
l3mdev	ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF	2019-06-23 13:24:17 -07:00
lapb	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 20:20:36 -07:00
llc	net: silence data-races on sk_backlog.tail	2019-11-06 21:35:34 -08:00
mac80211	Driver core patches for 5.5-rc1	2019-11-27 11:06:20 -08:00
mac802154	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174	2019-05-30 11:26:41 -07:00
mpls	ipv4: mpls: fix mpls_xmit for iptunnel	2019-08-25 14:34:08 -07:00
ncsi	net/ncsi: Disable global multicast filter	2019-09-19 18:04:40 -07:00
netfilter	netfilter: nft_set_rbtree: bogus lookup/get on consecutive elements in named sets	2019-12-09 13:13:25 +01:00
netlabel	netlabel: remove redundant assignment to pointer iter	2019-09-01 11:45:02 -07:00
netlink	genetlink: do not parse attributes for families with zero maxattr	2019-10-13 11:20:03 -07:00
netrom	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
nfc	net: Fix Kconfig indentation, continued	2019-11-21 12:00:21 -08:00
nsh	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
openvswitch	openvswitch: fix flow command message size	2019-11-26 15:13:46 -08:00
packet	packet: fix data-race in fanout_flow_is_huge()	2019-11-08 14:06:19 -08:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-10-28 13:33:41 -07:00
psample	net: psample: fix skb_over_panic	2019-11-26 14:40:13 -08:00
qrtr	net: qrtr: Simplify 'qrtr_tun_release()'	2019-10-30 17:58:23 -07:00
rds	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-16 21:51:42 -08:00
rfkill	rfkill: allocate static minor	2019-11-05 18:25:54 +01:00
rose	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
rxrpc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
sched	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-11-26 15:42:43 -08:00
sctp	net: port < inet_prot_sock(net) --> inet_port_requires_bind_service(net, port)	2019-11-26 13:20:46 -08:00
smc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-16 21:51:42 -08:00
strparser	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
sunrpc	SUNRPC: Destroy the back channel when we destroy the host transport	2019-10-30 12:04:35 -04:00
switchdev	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
tipc	tipc: fix link name length check	2019-11-26 10:03:12 -08:00
tls	net/tls: use sg_next() to walk sg entries	2019-11-28 22:40:29 -08:00
unix	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-02 13:54:56 -07:00
vmw_vsock	vsock: avoid to assign transport if its initialization fails	2019-11-21 11:37:16 -08:00
wimax	wimax: no need to check return value of debugfs_create functions	2019-08-10 15:25:47 -07:00
wireless	Some relatively small changes:	2019-11-08 11:36:48 -08:00
x25	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
xdp	xsk: Fix xsk_poll()'s return type	2019-11-24 16:58:44 -08:00
xfrm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
compat.c	uio: make import_iovec()/compat_import_iovec() return bytes on success	2019-05-31 15:30:03 -06:00
Kconfig	net: Fix Kconfig indentation, continued	2019-11-21 12:00:21 -08:00
Makefile
socket.c	net: disallow ancillary data for __sys_{send,recv}msg_file()	2019-11-26 15:02:53 -07:00
sysctl_net.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00