Dag Moxnes d8d9ec7dc5 RDMA/core: Fix race when resolving IP address ... Use the neighbour lock when copying the MAC address from the neighbour data struct in dst_fetch_ha. When not using the lock, it is possible for the function to race with neigh_update(), causing it to copy an torn MAC address: rdma_resolve_addr() rdma_resolve_ip() addr_resolve() addr_resolve_neigh() fetch_ha() dst_fetch_ha() memcpy(dev_addr->dst_dev_addr, n->ha, MAX_ADDR_LEN) and net_ioctl() arp_ioctl() arp_rec_delete() arp_invalidate() neigh_update() __neigh_update() memcpy(&neigh->ha, lladdr, dev->addr_len) It is possible to provoke this error by calling rdma_resolve_addr() in a tight loop, while deleting the corresponding ARP entry in another tight loop. Fixes: 51d4597451 ("infiniband: addr: Consolidate code to fetch neighbour hardware address from dst.") Signed-off-by: Dag Moxnes <dag.moxnes@oracle.com> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Reviewed-by: Jason Gunthorpe <jgg@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>		2019-07-09 16:27:04 -03:00
..
core	RDMA/core: Fix race when resolving IP address	2019-07-09 16:27:04 -03:00
hw	RDMA/mlx5: Set RDMA DIM to be enabled by default	2019-07-08 16:37:22 -03:00
sw	RDMA/rxe: Fill in wc byte_len with IB_WC_RECV_RDMA_WITH_IMM	2019-07-08 16:40:15 -03:00
ulp	IB/ipoib: Add child to parent list only if device initialized	2019-07-04 14:20:54 -03:00
Kconfig	RDMA/nldev: Added configuration of RDMA dynamic interrupt moderation to netlink	2019-07-08 16:37:22 -03:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00