Martin Willi 8dc08a2962 can: dev: Move device back to init netns on owning netns delete ... commit 3a5ca857079ea022e0b1b17fc154f7ad7dbc150f upstream. When a non-initial netns is destroyed, the usual policy is to delete all virtual network interfaces contained, but move physical interfaces back to the initial netns. This keeps the physical interface visible on the system. CAN devices are somewhat special, as they define rtnl_link_ops even if they are physical devices. If a CAN interface is moved into a non-initial netns, destroying that netns lets the interface vanish instead of moving it back to the initial netns. default_device_exit() skips CAN interfaces due to having rtnl_link_ops set. Reproducer: ip netns add foo ip link set can0 netns foo ip netns delete foo WARNING: CPU: 1 PID: 84 at net/core/dev.c:11030 ops_exit_list+0x38/0x60 CPU: 1 PID: 84 Comm: kworker/u4:2 Not tainted 5.10.19 #1 Workqueue: netns cleanup_net [<c010e700>] (unwind_backtrace) from [<c010a1d8>] (show_stack+0x10/0x14) [<c010a1d8>] (show_stack) from [<c086dc10>] (dump_stack+0x94/0xa8) [<c086dc10>] (dump_stack) from [<c086b938>] (__warn+0xb8/0x114) [<c086b938>] (__warn) from [<c086ba10>] (warn_slowpath_fmt+0x7c/0xac) [<c086ba10>] (warn_slowpath_fmt) from [<c0629f20>] (ops_exit_list+0x38/0x60) [<c0629f20>] (ops_exit_list) from [<c062a5c4>] (cleanup_net+0x230/0x380) [<c062a5c4>] (cleanup_net) from [<c0142c20>] (process_one_work+0x1d8/0x438) [<c0142c20>] (process_one_work) from [<c0142ee4>] (worker_thread+0x64/0x5a8) [<c0142ee4>] (worker_thread) from [<c0148a98>] (kthread+0x148/0x14c) [<c0148a98>] (kthread) from [<c0100148>] (ret_from_fork+0x14/0x2c) To properly restore physical CAN devices to the initial netns on owning netns exit, introduce a flag on rtnl_link_ops that can be set by drivers. For CAN devices setting this flag, default_device_exit() considers them non-virtual, applying the usual namespace move. The issue was introduced in the commit mentioned below, as at that time CAN devices did not have a dellink() operation. Fixes: e008b5fc8d ("net: Simplfy default_device_exit and improve batching.") Link: https://lore.kernel.org/r/20210302122423.872326-1-martin@strongswan.org Signed-off-by: Martin Willi <martin@strongswan.org> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-03-30 14:32:08 +02:00
..
9p	net: 9p: drop duplicate word in comment	2020-07-15 20:34:11 -07:00
bluetooth	Bluetooth: Add new HCI_QUIRK_NO_SUSPEND_NOTIFIER quirk	2021-03-07 12:34:10 +01:00
caif	net: caif: Remove unused caif SPI driver	2020-09-29 14:02:53 -07:00
iucv	net/af_iucv: clean up function prototypes	2020-05-19 12:50:14 -07:00
netfilter	netfilter: nftables: allow to update flowtable flags	2021-03-30 14:32:01 +02:00
netns	can: remove obsolete version strings	2020-10-12 10:06:39 +02:00
nfc
phonet
sctp	net: sctp: Fix IPv6 ancestor_size calc in sctp_copy_descendant	2020-09-20 14:15:12 -07:00
tc_act	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-10-15 12:43:21 -07:00
6lowpan.h
act_api.h	net_sched: fix RTNL deadlock again caused by request_module()	2021-03-04 11:38:47 +01:00
addrconf.h	ipv6: some fixes for ipv6_dev_find()	2020-08-18 15:58:53 -07:00
af_ieee802154.h
af_rxrpc.h	rxrpc: Make rxrpc_kernel_get_srtt() indicate validity	2020-08-20 18:21:28 +01:00
af_unix.h
af_vsock.h
ah.h
arp.h
atmclip.h
ax25.h
ax88796.h
bareudp.h	bareudp: Reverted support to enable & disable rx metadata collection	2020-07-21 18:30:47 -07:00
bond_3ad.h
bond_alb.h	bonding/alb: Add helper functions to get the xmit slave	2020-05-01 12:15:37 -07:00
bond_options.h
bonding.h	bonding: fix feature flag setting at init time	2020-12-08 11:26:08 -08:00
bpf_sk_storage.h	bpf: Change bpf_sk_storage_*() to accept ARG_PTR_TO_BTF_ID_SOCK_COMMON	2020-09-25 13:58:01 -07:00
busy_poll.h	net: Avoid overwriting valid skb->napi_id	2020-06-20 17:30:59 -07:00
calipso.h
cfg80211-wext.h
cfg80211.h	mac80211: fix kernel-doc markups	2020-10-30 10:06:09 +01:00
cfg802154.h
checksum.h	saner calling conventions for csum_and_copy_..._user()	2020-08-20 15:45:15 -04:00
cipso_ipv4.h	cipso: Remove unused inline functions	2020-07-15 07:45:24 -07:00
cls_cgroup.h	bpf: Allow to retrieve cgroup v1 classid from v2 hooks	2020-03-27 19:40:38 -07:00
codel_impl.h
codel_qdisc.h
codel.h
compat.h	net: simplify cBPF setsockopt compat handling	2020-07-19 18:16:40 -07:00
datalink.h
dcbevent.h
dcbnl.h
devlink.h	devlink: Add enable_remote_dev_reset generic parameter	2020-10-09 12:06:53 -07:00
dn_dev.h
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
dsa.h	net: dsa: propagate switchdev vlan_filtering prepare phase to drivers	2020-10-05 05:56:48 -07:00
dsfield.h
dst_cache.h
dst_metadata.h
dst_ops.h	net/dst: use a smaller percpu_counter batch for dst entries accounting	2020-05-08 21:33:33 -07:00
dst.h	net: Consolidate common blackhole dst ops	2021-03-30 14:32:05 +02:00
erspan.h	erspan: Add type I version 0 support.	2020-05-05 13:23:29 -07:00
esp.h
espintcp.h	xfrm: espintcp: save and call old ->sk_destruct	2020-04-20 07:34:16 +02:00
ethoc.h
failover.h
fib_notifier.h
fib_rules.h	fib: use indirect call wrappers in the most common fib_rules_ops	2020-07-28 17:42:31 -07:00
firewire.h
flow_dissector.h	net/flow_dissector: add packet hash dissection	2020-07-24 15:23:31 -07:00
flow_offload.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2020-08-05 20:13:21 -07:00
flow.h	ipv4: Initialize flowi4_multipath_hash in data path	2020-09-14 14:54:56 -07:00
fou.h
fq_impl.h	net/fq_impl: use skb_get_hash instead of skb_get_hash_perturb	2020-07-31 09:24:24 +02:00
fq.h	net/fq_impl: use skb_get_hash instead of skb_get_hash_perturb	2020-07-31 09:24:24 +02:00
garp.h
gen_stats.h
genetlink.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-10-05 18:40:01 -07:00
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h	GUE: Fix a typo	2020-06-22 21:12:44 -07:00
hwbm.h
icmp.h	net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending	2021-03-04 11:38:46 +01:00
ieee80211_radiotap.h	mac80211: add radiotap flag to prevent sequence number overwrite	2020-07-31 09:27:00 +02:00
ieee802154_netdev.h
if_inet6.h	ipv6: Replace zero-length array with flexible-array	2020-05-11 13:18:54 -07:00
ife.h
ila.h
inet6_connection_sock.h
inet6_hashtables.h	net: Track socket refcounts in skb_steal_sock()	2020-03-30 13:45:04 -07:00
inet_common.h	bpf: Allow any port in bpf_bind helper	2020-05-09 00:48:20 +02:00
inet_connection_sock.h	tcp: relookup sock for RST+ACK packets handled by obsolete req sock	2021-03-30 14:31:59 +02:00
inet_ecn.h	inet_ecn: Fix endianness of checksum update when setting ECT(1)	2020-12-01 17:16:54 -08:00
inet_frag.h
inet_hashtables.h	tcp: fix race condition when creating child sockets from syncookies	2020-11-23 16:32:33 -08:00
inet_sock.h	inet: remove inet_sk_copy_descendant()	2020-08-26 07:33:19 -07:00
inet_timewait_sock.h
inetpeer.h
ip6_checksum.h	tcp: remove indirect calls for icsk->icsk_af_ops->send_check	2020-06-20 17:47:53 -07:00
ip6_fib.h	net: ip6_fib.h: drop duplicate word in comment	2020-07-15 20:34:11 -07:00
ip6_route.h	ipv6: lift copy_from_user out of ipv6_route_ioctl	2020-05-18 17:35:02 -07:00
ip6_tunnel.h
ip_fib.h	ipv4: nexthop version of fib_info_nh_uses_dev	2020-05-26 16:06:07 -07:00
ip_tunnels.h	ip_tunnels: Set tunnel option flag when tunnel metadata is present	2020-11-13 16:58:10 -08:00
ip_vs.h	ipvs: remove dependency on ip6_tables	2020-08-31 23:06:51 +02:00
ip.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-10-05 18:40:01 -07:00
ipcomp.h
ipconfig.h
ipv6_frag.h	ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module	2020-11-19 10:49:50 -08:00
ipv6_stubs.h	ipv6: add ipv6_fragment hook in ipv6_stub	2020-08-31 12:26:39 -07:00
ipv6.h	ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module	2020-11-19 10:49:50 -08:00
ipx.h
iw_handler.h
kcm.h
l3mdev.h	l3mdev: add infrastructure for table to VRF mapping	2020-06-20 17:22:22 -07:00
lag.h
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h
lwtunnel.h	net: add net available in build_state	2020-03-29 22:30:57 -07:00
mac80211.h	mac80211: fix kernel-doc markups	2020-10-30 10:06:09 +01:00
mac802154.h
macsec.h	net: macsec: add support for getting offloaded stats	2020-03-26 20:17:36 -07:00
mip6.h
mld.h
mpls_iptunnel.h
mpls.h	net: Make mpls_entry_encode() available for generic users	2020-05-29 21:20:20 -07:00
mptcp.h	net: tcp: drop unused function argument from mptcp_incoming_options	2020-09-24 20:17:01 -07:00
mrp.h
ncsi.h
ndisc.h	ipv6: ndisc: adjust ndisc_ifinfo_sysctl_change prototype	2020-08-24 06:40:07 -07:00
neighbour.h	net: Exempt multicast addresses from five-second neighbor lifetime	2020-11-13 14:24:39 -08:00
net_failover.h
net_namespace.h	bpf, net: Rework cookie generator as per-cpu one	2020-09-30 11:50:35 -07:00
net_ratelimit.h
netevent.h
netlabel.h
netlink.h	netlink: export policy in extended ACK	2020-10-09 20:22:32 -07:00
netprio_cgroup.h
netrom.h
nexthop.h	ipv6: fix suspecious RCU usage warning	2021-03-30 14:31:57 +02:00
nl802154.h
nsh.h
p8022.h
page_pool.h
pie.h
ping.h
pkt_cls.h	net: sched: Do not drop root lock in tcf_qevent_handle()	2020-07-16 16:48:34 -07:00
pkt_sched.h	net/sched: get rid of qdisc->padded	2020-10-09 08:08:08 -07:00
pptp.h
protocol.h
psample.h
psnap.h
raw.h
rawv6.h
red.h	net: sched: validate stab values	2021-03-30 14:31:57 +02:00
regulatory.h	net/wireless: regulatory.h: drop duplicate word in comment	2020-07-31 09:24:23 +02:00
request_sock.h	tcp: bpf: Optionally store mac header in TCP_SAVE_SYN	2020-08-24 14:35:00 -07:00
rose.h
route.h
rpl.h	net: ipv6: Use struct_size() helper and kcalloc()	2020-06-23 20:27:09 -07:00
rsi_91x.h
rtnetlink.h	can: dev: Move device back to init netns on owning netns delete	2021-03-30 14:32:08 +02:00
rtnh.h
sch_generic.h	net: sched: replaced invalid qdisc tree flush helper in qdisc_replace	2021-02-10 09:29:23 +01:00
scm.h	fs: Move __scm_install_fd() to __receive_fd()	2020-07-13 11:03:44 -07:00
secure_seq.h
seg6_hmac.h
seg6_local.h
seg6.h	seg6: fix seg6_validate_srh() to avoid slab-out-of-bounds	2020-06-04 15:39:32 -07:00
slhc_vj.h
smc.h	net/smc: introduce CHID callback for ISM devices	2020-09-28 15:19:03 -07:00
snmp.h
sock_reuseport.h
sock.h	tcp: fix TCP socket rehash stats mis-accounting	2021-01-27 11:55:23 +01:00
Space.h
stp.h
strparser.h
switchdev.h	switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT	2021-02-17 11:02:29 +01:00
tcp_states.h
tcp.h	tcp: fix SO_RCVLOWAT related hangs under mem pressure	2021-03-04 11:37:33 +01:00
timewait_sock.h
tipc.h
tls_toe.h
tls.h	net/tls: Protect from calling tls_dev_del for TLS RX twice	2020-11-25 17:31:06 -08:00
transp_v6.h	tcp: move ipv4_specific to tcp include file	2020-06-23 20:10:15 -07:00
tso.h	net: tso: cache transport header length	2020-06-18 20:46:23 -07:00
tun_proto.h
udp_tunnel.h	udp_tunnel: add the ability to share port tables	2020-09-28 12:50:12 -07:00
udp.h	udp: ipv4: manipulate network header of NATed UDP GRO fraglist	2021-02-10 09:29:23 +01:00
udplite.h
vsock_addr.h
vxlan.h	net: sched: only keep the available bits when setting vxlan md->gbp	2020-09-14 16:49:39 -07:00
wext.h
wimax.h	net: wimax: fix duplicate words in comments	2020-07-15 20:34:02 -07:00
x25.h
x25device.h
xdp_priv.h
xdp_sock_drv.h	xsk: i40e: ice: ixgbe: mlx5: Test for dma_need_sync earlier for better performance	2020-08-31 21:15:04 +02:00
xdp_sock.h	xsk: Fix race in SKB mode transmit with shared cq	2021-01-17 14:17:05 +01:00
xdp.h	xdp: Remove the xdp_attachment_flags_ok() callback	2020-12-09 16:27:42 +01:00
xfrm.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-10-05 18:40:01 -07:00
xsk_buff_pool.h	xsk: Fix race in SKB mode transmit with shared cq	2021-01-17 14:17:05 +01:00