linux_dsm_epyc7002/drivers/gpu/drm/qxl
Gustavo A. R. Silva 0f0658636d drm/qxl: replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20200212193344.GA27929@embeddedor
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2020-02-13 11:11:59 +01:00
..
Kconfig drm/qxl: Fix randbuild error 2019-10-17 14:31:50 +02:00
Makefile
qxl_cmd.c drm/qxl: replace zero-length array with flexible-array member 2020-02-13 11:11:59 +01:00
qxl_debugfs.c
qxl_dev.h
qxl_display.c drm/qxl: Remove sending of vblank event 2020-01-30 09:00:45 +01:00
qxl_draw.c
qxl_drv.c drm/qxl: add drm_driver.release callback. 2020-02-11 11:45:51 +01:00
qxl_drv.h drm/qxl: stop using TTM to call driver internal functions 2019-10-25 11:40:51 +02:00
qxl_dumb.c
qxl_gem.c
qxl_image.c
qxl_ioctl.c
qxl_irq.c
qxl_kms.c drm/qxl: reorder calls in qxl_device_fini(). 2020-02-11 11:45:51 +01:00
qxl_object.c drm/qxl: stop using TTM to call driver internal functions 2019-10-25 11:40:51 +02:00
qxl_object.h
qxl_prime.c
qxl_release.c drm/ttm: remove pointers to globals 2019-10-25 11:40:51 +02:00
qxl_ttm.c drm/ttm: nuke invalidate_caches callback 2020-01-16 16:35:07 +01:00