mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-21 08:37:37 +07:00
e0c274472d
Mel Gorman reports a hackbench regression with psi that would prohibit shipping the suse kernel with it default-enabled, but he'd still like users to be able to opt in at little to no cost to others. With the current combination of CONFIG_PSI and the psi_disabled bool set from the commandline, this is a challenge. Do the following things to make it easier: 1. Add a config option CONFIG_PSI_DEFAULT_DISABLED that allows distros to enable CONFIG_PSI in their kernel but leave the feature disabled unless a user requests it at boot-time. To avoid double negatives, rename psi_disabled= to psi=. 2. Make psi_disabled a static branch to eliminate any branch costs when the feature is disabled. In terms of numbers before and after this patch, Mel says: : The following is a comparision using CONFIG_PSI=n as a baseline against : your patch and a vanilla kernel : : 4.20.0-rc4 4.20.0-rc4 4.20.0-rc4 : kconfigdisable-v1r1 vanilla psidisable-v1r1 : Amean 1 1.3100 ( 0.00%) 1.3923 ( -6.28%) 1.3427 ( -2.49%) : Amean 3 3.8860 ( 0.00%) 4.1230 * -6.10%* 3.8860 ( -0.00%) : Amean 5 6.8847 ( 0.00%) 8.0390 * -16.77%* 6.7727 ( 1.63%) : Amean 7 9.9310 ( 0.00%) 10.8367 * -9.12%* 9.9910 ( -0.60%) : Amean 12 16.6577 ( 0.00%) 18.2363 * -9.48%* 17.1083 ( -2.71%) : Amean 18 26.5133 ( 0.00%) 27.8833 * -5.17%* 25.7663 ( 2.82%) : Amean 24 34.3003 ( 0.00%) 34.6830 ( -1.12%) 32.0450 ( 6.58%) : Amean 30 40.0063 ( 0.00%) 40.5800 ( -1.43%) 41.5087 ( -3.76%) : Amean 32 40.1407 ( 0.00%) 41.2273 ( -2.71%) 39.9417 ( 0.50%) : : It's showing that the vanilla kernel takes a hit (as the bisection : indicated it would) and that disabling PSI by default is reasonably : close in terms of performance for this particular workload on this : particular machine so; Link: http://lkml.kernel.org/r/20181127165329.GA29728@cmpxchg.org Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Tested-by: Mel Gorman <mgorman@techsingularity.net> Reported-by: Mel Gorman <mgorman@techsingularity.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
55 lines
1.2 KiB
C
55 lines
1.2 KiB
C
#ifndef _LINUX_PSI_H
|
|
#define _LINUX_PSI_H
|
|
|
|
#include <linux/jump_label.h>
|
|
#include <linux/psi_types.h>
|
|
#include <linux/sched.h>
|
|
|
|
struct seq_file;
|
|
struct css_set;
|
|
|
|
#ifdef CONFIG_PSI
|
|
|
|
extern struct static_key_false psi_disabled;
|
|
|
|
void psi_init(void);
|
|
|
|
void psi_task_change(struct task_struct *task, int clear, int set);
|
|
|
|
void psi_memstall_tick(struct task_struct *task, int cpu);
|
|
void psi_memstall_enter(unsigned long *flags);
|
|
void psi_memstall_leave(unsigned long *flags);
|
|
|
|
int psi_show(struct seq_file *s, struct psi_group *group, enum psi_res res);
|
|
|
|
#ifdef CONFIG_CGROUPS
|
|
int psi_cgroup_alloc(struct cgroup *cgrp);
|
|
void psi_cgroup_free(struct cgroup *cgrp);
|
|
void cgroup_move_task(struct task_struct *p, struct css_set *to);
|
|
#endif
|
|
|
|
#else /* CONFIG_PSI */
|
|
|
|
static inline void psi_init(void) {}
|
|
|
|
static inline void psi_memstall_enter(unsigned long *flags) {}
|
|
static inline void psi_memstall_leave(unsigned long *flags) {}
|
|
|
|
#ifdef CONFIG_CGROUPS
|
|
static inline int psi_cgroup_alloc(struct cgroup *cgrp)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline void psi_cgroup_free(struct cgroup *cgrp)
|
|
{
|
|
}
|
|
static inline void cgroup_move_task(struct task_struct *p, struct css_set *to)
|
|
{
|
|
rcu_assign_pointer(p->cgroups, to);
|
|
}
|
|
#endif
|
|
|
|
#endif /* CONFIG_PSI */
|
|
|
|
#endif /* _LINUX_PSI_H */
|