mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-25 23:05:23 +07:00
89958b7cd9
The drm panel bridge creates a connector using a connector type explicitly passed by the display controller or bridge driver that instantiates the panel bridge. Now that drm_panel reports its connector type, we can use it to avoid passing an explicit (and often incorrect) connector type to drm_panel_bridge_add() and devm_drm_panel_bridge_add(). Several drivers report incorrect or unknown connector types to userspace. Reporting a different type may result in a breakage. For that reason, rename (devm_)drm_panel_bridge_add() to (devm_)drm_panel_bridge_add_typed(), and add new (devm_)drm_panel_bridge_add() functions that use the panel connector type. Update all callers of (devm_)drm_panel_bridge_add() to the _typed function, they will be converted one by one after testing. The panel drivers have been updated with the following Coccinelle semantic patch, with manual inspection and fixes to indentation. @@ expression bridge; expression dev; expression panel; identifier type; @@ ( -bridge = drm_panel_bridge_add(panel, type); +bridge = drm_panel_bridge_add_typed(panel, type); | -bridge = devm_drm_panel_bridge_add(dev, panel, type); +bridge = devm_drm_panel_bridge_add_typed(dev, panel, type); ) Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Link: https://patchwork.freedesktop.org/patch/msgid/20190904132804.29680-3-laurent.pinchart@ideasonboard.com
168 lines
3.9 KiB
C
168 lines
3.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) Fuzhou Rockchip Electronics Co.Ltd
|
|
* Author:
|
|
* Sandy Huang <hjc@rock-chips.com>
|
|
*/
|
|
|
|
#include <linux/component.h>
|
|
#include <linux/of_graph.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_dp_helper.h>
|
|
#include <drm/drm_of.h>
|
|
#include <drm/drm_panel.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
#include "rockchip_drm_drv.h"
|
|
#include "rockchip_drm_vop.h"
|
|
|
|
#define encoder_to_rgb(c) container_of(c, struct rockchip_rgb, encoder)
|
|
|
|
struct rockchip_rgb {
|
|
struct device *dev;
|
|
struct drm_device *drm_dev;
|
|
struct drm_bridge *bridge;
|
|
struct drm_encoder encoder;
|
|
int output_mode;
|
|
};
|
|
|
|
static int
|
|
rockchip_rgb_encoder_atomic_check(struct drm_encoder *encoder,
|
|
struct drm_crtc_state *crtc_state,
|
|
struct drm_connector_state *conn_state)
|
|
{
|
|
struct rockchip_crtc_state *s = to_rockchip_crtc_state(crtc_state);
|
|
struct drm_connector *connector = conn_state->connector;
|
|
struct drm_display_info *info = &connector->display_info;
|
|
u32 bus_format;
|
|
|
|
if (info->num_bus_formats)
|
|
bus_format = info->bus_formats[0];
|
|
else
|
|
bus_format = MEDIA_BUS_FMT_RGB888_1X24;
|
|
|
|
switch (bus_format) {
|
|
case MEDIA_BUS_FMT_RGB666_1X18:
|
|
s->output_mode = ROCKCHIP_OUT_MODE_P666;
|
|
break;
|
|
case MEDIA_BUS_FMT_RGB565_1X16:
|
|
s->output_mode = ROCKCHIP_OUT_MODE_P565;
|
|
break;
|
|
case MEDIA_BUS_FMT_RGB888_1X24:
|
|
case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
|
|
default:
|
|
s->output_mode = ROCKCHIP_OUT_MODE_P888;
|
|
break;
|
|
}
|
|
|
|
s->output_type = DRM_MODE_CONNECTOR_LVDS;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const
|
|
struct drm_encoder_helper_funcs rockchip_rgb_encoder_helper_funcs = {
|
|
.atomic_check = rockchip_rgb_encoder_atomic_check,
|
|
};
|
|
|
|
static const struct drm_encoder_funcs rockchip_rgb_encoder_funcs = {
|
|
.destroy = drm_encoder_cleanup,
|
|
};
|
|
|
|
struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
|
|
struct drm_crtc *crtc,
|
|
struct drm_device *drm_dev)
|
|
{
|
|
struct rockchip_rgb *rgb;
|
|
struct drm_encoder *encoder;
|
|
struct device_node *port, *endpoint;
|
|
u32 endpoint_id;
|
|
int ret = 0, child_count = 0;
|
|
struct drm_panel *panel;
|
|
struct drm_bridge *bridge;
|
|
|
|
rgb = devm_kzalloc(dev, sizeof(*rgb), GFP_KERNEL);
|
|
if (!rgb)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
rgb->dev = dev;
|
|
rgb->drm_dev = drm_dev;
|
|
|
|
port = of_graph_get_port_by_id(dev->of_node, 0);
|
|
if (!port)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
for_each_child_of_node(port, endpoint) {
|
|
if (of_property_read_u32(endpoint, "reg", &endpoint_id))
|
|
endpoint_id = 0;
|
|
|
|
if (rockchip_drm_endpoint_is_subdriver(endpoint) > 0)
|
|
continue;
|
|
|
|
child_count++;
|
|
ret = drm_of_find_panel_or_bridge(dev->of_node, 0, endpoint_id,
|
|
&panel, &bridge);
|
|
if (!ret) {
|
|
of_node_put(endpoint);
|
|
break;
|
|
}
|
|
}
|
|
|
|
of_node_put(port);
|
|
|
|
/* if the rgb output is not connected to anything, just return */
|
|
if (!child_count)
|
|
return NULL;
|
|
|
|
if (ret < 0) {
|
|
if (ret != -EPROBE_DEFER)
|
|
DRM_DEV_ERROR(dev, "failed to find panel or bridge %d\n", ret);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
encoder = &rgb->encoder;
|
|
encoder->possible_crtcs = drm_crtc_mask(crtc);
|
|
|
|
ret = drm_encoder_init(drm_dev, encoder, &rockchip_rgb_encoder_funcs,
|
|
DRM_MODE_ENCODER_NONE, NULL);
|
|
if (ret < 0) {
|
|
DRM_DEV_ERROR(drm_dev->dev,
|
|
"failed to initialize encoder: %d\n", ret);
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
drm_encoder_helper_add(encoder, &rockchip_rgb_encoder_helper_funcs);
|
|
|
|
if (panel) {
|
|
bridge = drm_panel_bridge_add_typed(panel,
|
|
DRM_MODE_CONNECTOR_LVDS);
|
|
if (IS_ERR(bridge))
|
|
return ERR_CAST(bridge);
|
|
}
|
|
|
|
rgb->bridge = bridge;
|
|
|
|
ret = drm_bridge_attach(encoder, rgb->bridge, NULL);
|
|
if (ret) {
|
|
DRM_DEV_ERROR(drm_dev->dev,
|
|
"failed to attach bridge: %d\n", ret);
|
|
goto err_free_encoder;
|
|
}
|
|
|
|
return rgb;
|
|
|
|
err_free_encoder:
|
|
drm_encoder_cleanup(encoder);
|
|
return ERR_PTR(ret);
|
|
}
|
|
EXPORT_SYMBOL_GPL(rockchip_rgb_init);
|
|
|
|
void rockchip_rgb_fini(struct rockchip_rgb *rgb)
|
|
{
|
|
drm_panel_bridge_remove(rgb->bridge);
|
|
drm_encoder_cleanup(&rgb->encoder);
|
|
}
|
|
EXPORT_SYMBOL_GPL(rockchip_rgb_fini);
|