mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-18 18:57:47 +07:00
d6124d6ba6
the following script: # tc qdisc add dev crash0 clsact # tc filter add dev crash0 egress matchall \ > action police rate 3mbit burst 250k pass index 90 # tc actions replace action police \ > rate 3mbit burst 250k goto chain 42 index 90 cookie c1a0c1a0 # tc actions show action police rate 3mbit burst had the following output: Error: Failed to init TC action chain. We have an error talking to the kernel total acts 1 action order 0: police 0x5a rate 3Mbit burst 250Kb mtu 2Kb action goto chain 42 overhead 0b ref 2 bind 1 cookie c1a0c1a0 Then, when crash0 starts transmitting more than 3Mbit/s, the following kernel crash is observed: BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 #PF error: [normal kernel read fault] PGD 800000007a779067 P4D 800000007a779067 PUD 2ad96067 PMD 0 Oops: 0000 [#1] SMP PTI CPU: 3 PID: 5032 Comm: netperf Not tainted 5.0.0-rc4.gotochain_crash+ #533 Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 RIP: 0010:tcf_action_exec+0xb8/0x100 Code: 00 00 00 20 74 1d 83 f8 03 75 09 49 83 c4 08 4d 39 ec 75 bc 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 49 8b 97 a8 00 00 00 <48> 8b 12 48 89 55 00 48 83 c4 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 RSP: 0018:ffffb0e04064fa60 EFLAGS: 00010246 RAX: 000000002000002a RBX: ffff93bb3322cce0 RCX: 0000000000000005 RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff93bb3322cce0 RBP: ffffb0e04064fb00 R08: 0000000000000022 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000001 R12: ffff93bb3beed300 R13: ffff93bb3beed308 R14: 0000000000000001 R15: ffff93bb3b64d000 FS: 00007f0bc6be5740(0000) GS:ffff93bb3db80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000000 CR3: 00000000746a8001 CR4: 00000000001606e0 Call Trace: tcf_classify+0x58/0x120 __dev_queue_xmit+0x40a/0x890 ? ipt_do_table+0x31c/0x420 [ip_tables] ? ip_finish_output2+0x16f/0x430 ip_finish_output2+0x16f/0x430 ? ip_output+0x69/0xe0 ip_output+0x69/0xe0 ? ip_forward_options+0x1a0/0x1a0 __tcp_transmit_skb+0x563/0xa40 tcp_write_xmit+0x243/0xfa0 __tcp_push_pending_frames+0x32/0xf0 tcp_sendmsg_locked+0x404/0xd30 tcp_sendmsg+0x27/0x40 sock_sendmsg+0x36/0x40 __sys_sendto+0x10e/0x140 ? __sys_connect+0x87/0xf0 ? syscall_trace_enter+0x1df/0x2e0 ? __audit_syscall_exit+0x216/0x260 __x64_sys_sendto+0x24/0x30 do_syscall_64+0x5b/0x180 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x7f0bc5ffbafd Code: 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 8b 05 ae c4 2c 00 85 c0 75 2d 45 31 c9 45 31 c0 4c 63 d1 48 63 ff b8 2c 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 8b 15 63 63 2c 00 f7 d8 64 89 02 48 RSP: 002b:00007fffef94b7f8 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 0000000000004000 RCX: 00007f0bc5ffbafd RDX: 0000000000004000 RSI: 00000000017e5420 RDI: 0000000000000004 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004 R13: 00000000017e51d0 R14: 0000000000000010 R15: 0000000000000006 Modules linked in: act_police veth ip6table_filter ip6_tables iptable_filter binfmt_misc ext4 snd_hda_codec_generic mbcache crct10dif_pclmul jbd2 crc32_pclmul ghash_clmulni_intel snd_hda_intel snd_hda_codec snd_hwdep snd_hda_core snd_seq snd_seq_device snd_pcm aesni_intel crypto_simd cryptd glue_helper snd_timer snd joydev pcspkr virtio_balloon soundcore i2c_piix4 nfsd auth_rpcgss nfs_acl lockd grace sunrpc ip_tables xfs ata_generic pata_acpi qxl drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm drm virtio_blk virtio_net virtio_console net_failover failover crc32c_intel ata_piix libata serio_raw virtio_pci virtio_ring virtio floppy dm_mirror dm_region_hash dm_log dm_mod CR2: 0000000000000000 Validating the control action within tcf_police_init() proved to fix the above issue. A TDC selftest is added to verify the correct behavior. Fixes: |
||
---|---|---|
.. | ||
bpf | ||
creating-plugins | ||
creating-testcases | ||
plugin-lib | ||
plugins | ||
tc-tests | ||
.gitignore | ||
config | ||
README | ||
tdc_batch.py | ||
tdc_config_local_template.py | ||
tdc_config.py | ||
tdc_helper.py | ||
tdc_multibatch.py | ||
tdc.py | ||
TdcPlugin.py | ||
TdcResults.py | ||
TODO.txt |
tdc - Linux Traffic Control (tc) unit testing suite Author: Lucas Bates - lucasb@mojatatu.com tdc is a Python script to load tc unit tests from a separate JSON file and execute them inside a network namespace dedicated to the task. REQUIREMENTS ------------ * Minimum Python version of 3.4. Earlier 3.X versions may work but are not guaranteed. * The kernel must have network namespace support * The kernel must have veth support available, as a veth pair is created prior to running the tests. * The kernel must have the appropriate infrastructure enabled to run all tdc unit tests. See the config file in this directory for minimum required features. As new tests will be added, config options list will be updated. * All tc-related features being tested must be built in or available as modules. To check what is required in current setup run: ./tdc.py -c Note: In the current release, tdc run will abort due to a failure in setup or teardown commands - which includes not being able to run a test simply because the kernel did not support a specific feature. (This will be handled in a future version - the current workaround is to run the tests on specific test categories that your kernel supports) BEFORE YOU RUN -------------- The path to the tc executable that will be most commonly tested can be defined in the tdc_config.py file. Find the 'TC' entry in the NAMES dictionary and define the path. If you need to test a different tc executable on the fly, you can do so by using the -p option when running tdc: ./tdc.py -p /path/to/tc RUNNING TDC ----------- To use tdc, root privileges are required. This is because the commands being tested must be run as root. The code that enforces execution by root uid has been moved into a plugin (see PLUGIN ARCHITECTURE, below). If nsPlugin is linked, all tests are executed inside a network namespace to prevent conflicts within the host. Running tdc without any arguments will run all tests. Refer to the section on command line arguments for more information, or run: ./tdc.py -h tdc will list the test names as they are being run, and print a summary in TAP (Test Anything Protocol) format when they are done. If tests fail, output captured from the failing test will be printed immediately following the failed test in the TAP output. OVERVIEW OF TDC EXECUTION ------------------------- One run of tests is considered a "test suite" (this will be refined in the future). A test suite has one or more test cases in it. A test case has four stages: - setup - execute - verify - teardown The setup and teardown stages can run zero or more commands. The setup stage does some setup if the test needs it. The teardown stage undoes the setup and returns the system to a "neutral" state so any other test can be run next. These two stages require any commands run to return success, but do not otherwise verify the results. The execute and verify stages each run one command. The execute stage tests the return code against one or more acceptable values. The verify stage checks the return code for success, and also compares the stdout with a regular expression. Each of the commands in any stage will run in a shell instance. USER-DEFINED CONSTANTS ---------------------- The tdc_config.py file contains multiple values that can be altered to suit your needs. Any value in the NAMES dictionary can be altered without affecting the tests to be run. These values are used in the tc commands that will be executed as part of the test. More will be added as test cases require. Example: $TC qdisc add dev $DEV1 ingress The NAMES values are used to substitute into the commands in the test cases. COMMAND LINE ARGUMENTS ---------------------- Run tdc.py -h to see the full list of available arguments. usage: tdc.py [-h] [-p PATH] [-D DIR [DIR ...]] [-f FILE [FILE ...]] [-c [CATG [CATG ...]]] [-e ID [ID ...]] [-l] [-s] [-i] [-v] [-N] [-d DEVICE] [-P] [-n] [-V] Linux TC unit tests optional arguments: -h, --help show this help message and exit -p PATH, --path PATH The full path to the tc executable to use -v, --verbose Show the commands that are being run -N, --notap Suppress tap results for command under test -d DEVICE, --device DEVICE Execute the test case in flower category -P, --pause Pause execution just before post-suite stage selection: select which test cases: files plus directories; filtered by categories plus testids -D DIR [DIR ...], --directory DIR [DIR ...] Collect tests from the specified directory(ies) (default [tc-tests]) -f FILE [FILE ...], --file FILE [FILE ...] Run tests from the specified file(s) -c [CATG [CATG ...]], --category [CATG [CATG ...]] Run tests only from the specified category/ies, or if no category/ies is/are specified, list known categories. -e ID [ID ...], --execute ID [ID ...] Execute the specified test cases with specified IDs action: select action to perform on selected test cases -l, --list List all test cases, or those only within the specified category -s, --show Display the selected test cases -i, --id Generate ID numbers for new test cases netns: options for nsPlugin (run commands in net namespace) -n, --namespace Run commands in namespace as specified in tdc_config.py valgrind: options for valgrindPlugin (run command under test under Valgrind) -V, --valgrind Run commands under valgrind PLUGIN ARCHITECTURE ------------------- There is now a plugin architecture, and some of the functionality that was in the tdc.py script has been moved into the plugins. The plugins are in the directory plugin-lib. The are executed from directory plugins. Put symbolic links from plugins to plugin-lib, and name them according to the order you want them to run. Example: bjb@bee:~/work/tc-testing$ ls -l plugins total 4 lrwxrwxrwx 1 bjb bjb 27 Oct 4 16:12 10-rootPlugin.py -> ../plugin-lib/rootPlugin.py lrwxrwxrwx 1 bjb bjb 25 Oct 12 17:55 20-nsPlugin.py -> ../plugin-lib/nsPlugin.py -rwxr-xr-x 1 bjb bjb 0 Sep 29 15:56 __init__.py The plugins are a subclass of TdcPlugin, defined in TdcPlugin.py and must be called "SubPlugin" so tdc can find them. They are distinguished from each other in the python program by their module name. This base class supplies "hooks" to run extra functions. These hooks are as follows: pre- and post-suite pre- and post-case pre- and post-execute stage adjust-command (runs in all stages and receives the stage name) The pre-suite hook receives the number of tests and an array of test ids. This allows you to dump out the list of skipped tests in the event of a failure during setup or teardown stage. The pre-case hook receives the ordinal number and test id of the current test. The adjust-command hook receives the stage id (see list below) and the full command to be executed. This allows for last-minute adjustment of the command. The stages are identified by the following strings: - pre (pre-suite) - setup - command - verify - teardown - post (post-suite) To write a plugin, you need to inherit from TdcPlugin in TdcPlugin.py. To use the plugin, you have to put the implementation file in plugin-lib, and add a symbolic link to it from plugins. It will be detected at run time and invoked at the appropriate times. There are a few examples in the plugin-lib directory: - rootPlugin.py: implements the enforcement of running as root - nsPlugin.py: sets up a network namespace and runs all commands in that namespace - valgrindPlugin.py runs each command in the execute stage under valgrind, and checks for leaks. This plugin will output an extra test for each test in the test file, one is the existing output as to whether the test passed or failed, and the other is a test whether the command leaked memory or not. (This one is a preliminary version, it may not work quite right yet, but the overall template is there and it should only need tweaks.) - buildebpfPlugin.py: builds all programs in $EBPFDIR. ACKNOWLEDGEMENTS ---------------- Thanks to: Jamal Hadi Salim, for providing valuable test cases Keara Leibovitz, who wrote the CLI test driver that I used as a base for the first version of the tc testing suite. This work was presented at Netdev 1.2 Tokyo in October 2016. Samir Hussain, for providing help while I dove into Python for the first time and being a second eye for this code.