mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-21 23:01:04 +07:00
e824de8ae2
The bonding driver saves a copy of slaves' original mac address and then assigns whatever mac as needed to the slave, depending on mode. In at least modes 5 and 6 (balance-tlb, balance-alb), it often ends up being the mac address of another slave. On release from the bond, the original mac address is supposed to get restored via a dev_set_mac_address() call in the bonding driver's __bond_release_one() function, which calls the slave's ndo_set_mac_address function, which for qlcnic, is qlcnic_set_mac(). Now, this function tries to be somewhat intelligent and exit early if you're trying to set the mac address to the same thing that is already set. The problem here is that adapter->mac_addr isn't in sync with netdev->dev_addr. The qlcnic driver still has the original mac stored in adapter->mac_addr, while the bonding driver has updated netdev->dev_addr, so qlcnic thinks we're trying to set the same address it already has. I think the way to go here, since the function updates both netdev and adapter's stored mac addresses, is to check if either of them doesn't match the newly requested mac. Simply checking netdev's value only could result in a similar mismatch and non-update, so look at both. CC: Dept-GELinuxNICDev@qlogic.com CC: netdev@vger.kernel.org CC: Manish Chopra <manish.chopra@qlogic.com> Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| qlcnic_83xx_hw.c | ||
| qlcnic_83xx_hw.h | ||
| qlcnic_83xx_init.c | ||
| qlcnic_83xx_vnic.c | ||
| qlcnic_ctx.c | ||
| qlcnic_dcb.c | ||
| qlcnic_dcb.h | ||
| qlcnic_ethtool.c | ||
| qlcnic_hdr.h | ||
| qlcnic_hw.c | ||
| qlcnic_hw.h | ||
| qlcnic_init.c | ||
| qlcnic_io.c | ||
| qlcnic_main.c | ||
| qlcnic_minidump.c | ||
| qlcnic_sriov_common.c | ||
| qlcnic_sriov_pf.c | ||
| qlcnic_sriov.h | ||
| qlcnic_sysfs.c | ||
| qlcnic.h | ||