Chris Wilson 833521ebc6 e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails ... An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 00000011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2 [ 430.955458] PM: Device 0000:00:19.0 failed to suspend async: error -2 [ 430.955581] PM: Some devices failed to suspend, or early wake event detected [ 430.957709] ACPI : EC: event unblocked lead to complete failure: [ 432.585002] ------------[ cut here ]------------ [ 432.585013] WARNING: CPU: 3 PID: 8372 at kernel/irq/manage.c:1478 __free_irq+0x9f/0x280 [ 432.585015] Trying to free already-free IRQ 20 [ 432.585016] Modules linked in: cdc_ncm usbnet x86_pkg_temp_thermal intel_powerclamp coretemp mii crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep lpc_ich snd_hda_core snd_pcm mei_me mei sdhci_pci sdhci i915 mmc_core e1000e ptp pps_core prime_numbers [ 432.585042] CPU: 3 PID: 8372 Comm: kworker/u16:40 Tainted: G U 4.10.0-rc8-CI-Patchwork_3870+ #1 [ 432.585044] Hardware name: LENOVO 2356GCG/2356GCG, BIOS G7ET31WW (1.13 ) 07/02/2012 [ 432.585050] Workqueue: events_unbound async_run_entry_fn [ 432.585051] Call Trace: [ 432.585058] dump_stack+0x67/0x92 [ 432.585062] __warn+0xc6/0xe0 [ 432.585065] warn_slowpath_fmt+0x4a/0x50 [ 432.585070] ? _raw_spin_lock_irqsave+0x49/0x60 [ 432.585072] __free_irq+0x9f/0x280 [ 432.585075] free_irq+0x34/0x80 [ 432.585089] e1000_free_irq+0x65/0x70 [e1000e] [ 432.585098] e1000e_pm_freeze+0x7a/0xb0 [e1000e] [ 432.585106] e1000e_pm_suspend+0x21/0x30 [e1000e] [ 432.585113] pci_pm_suspend+0x71/0x140 [ 432.585118] dpm_run_callback+0x6f/0x330 [ 432.585122] ? pci_pm_freeze+0xe0/0xe0 [ 432.585125] __device_suspend+0xea/0x330 [ 432.585128] async_suspend+0x1a/0x90 [ 432.585132] async_run_entry_fn+0x34/0x160 [ 432.585137] process_one_work+0x1f4/0x6d0 [ 432.585140] ? process_one_work+0x16e/0x6d0 [ 432.585143] worker_thread+0x49/0x4a0 [ 432.585145] kthread+0x107/0x140 [ 432.585148] ? process_one_work+0x6d0/0x6d0 [ 432.585150] ? kthread_create_on_node+0x40/0x40 [ 432.585154] ret_from_fork+0x2e/0x40 [ 432.585156] ---[ end trace 6712df7f8c4b9124 ]--- The unwind failures stems from commit 2800209994 ("e1000e: Refactor PM flows"), but it may be a later patch that introduced the non-recoverable behaviour. Fixes: 2800209994 ("e1000e: Refactor PM flows") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>		2017-06-07 20:45:58 -07:00
..
80003es2lan.c	e1000e: use BIT() macro for bit defines	2016-05-13 15:15:36 -07:00
80003es2lan.h	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
82571.c	e1000e: factor out systim sanitization	2016-08-16 10:46:19 -07:00
82571.h	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
defines.h	e1000e: Adds hardware supported cross timestamp on e1000e nic	2016-03-03 14:28:46 -08:00
e1000.h	e1000e: add statistic indicating number of skipped Tx timestamps	2017-06-06 01:01:27 -07:00
ethtool.c	e1000e: Don't return uninitialized stats	2017-06-06 01:05:13 -07:00
hw.h	e1000e: Initial Support for CannonLake	2017-04-30 05:15:08 -07:00
ich8lan.c	e1000e: Add Support for CannonLake	2017-04-30 05:18:30 -07:00
ich8lan.h	e1000e: mark shifted values as unsigned	2016-05-13 15:19:05 -07:00
mac.c	e1000e: use BIT() macro for bit defines	2016-05-13 15:15:36 -07:00
mac.h	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
Makefile	e1000e: Cleanup - Update GPL header and Copyright	2014-03-07 21:55:27 -08:00
manage.c	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
manage.h	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
netdev.c	e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails	2017-06-07 20:45:58 -07:00
nvm.c	e1000e: use BIT() macro for bit defines	2016-05-13 15:15:36 -07:00
nvm.h	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
param.c	e1000e: Bump the version to 3.2.5	2015-06-03 04:13:39 -07:00
phy.c	e1000e: use BIT() macro for bit defines	2016-05-13 15:15:36 -07:00
phy.h	e1000e: use BIT() macro for bit defines	2016-05-13 15:15:36 -07:00
ptp.c	e1000e: Add Support for CannonLake	2017-04-30 05:18:30 -07:00
regs.h	e1000e: Adds hardware supported cross timestamp on e1000e nic	2016-03-03 14:28:46 -08:00