Du Cheng 6a07cf3606 cfg80211: call cfg80211_leave_ocb when switching away from OCB ... [ Upstream commit a64b6a25dd9f984ed05fade603a00e2eae787d2f ] If the userland switches back-and-forth between NL80211_IFTYPE_OCB and NL80211_IFTYPE_ADHOC via send_msg(NL80211_CMD_SET_INTERFACE), there is a chance where the cleanup cfg80211_leave_ocb() is not called. This leads to initialization of in-use memory (e.g. init u.ibss while in-use by u.ocb) due to a shared struct/union within ieee80211_sub_if_data: struct ieee80211_sub_if_data { ... union { struct ieee80211_if_ap ap; struct ieee80211_if_vlan vlan; struct ieee80211_if_managed mgd; struct ieee80211_if_ibss ibss; // <- shares address struct ieee80211_if_mesh mesh; struct ieee80211_if_ocb ocb; // <- shares address struct ieee80211_if_mntr mntr; struct ieee80211_if_nan nan; } u; ... } Therefore add handling of otype == NL80211_IFTYPE_OCB, during cfg80211_change_iface() to perform cleanup when leaving OCB mode. link to syzkaller bug: https://syzkaller.appspot.com/bug?id=0612dbfa595bf4b9b680ff7b4948257b8e3732d5 Reported-by: syzbot+105896fac213f26056f9@syzkaller.appspotmail.com Signed-off-by: Du Cheng <ducheng2@gmail.com> Link: https://lore.kernel.org/r/20210428063941.105161-1-ducheng2@gmail.com Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-06-30 08:47:19 -04:00
..
certs
.gitignore
ap.c
chan.c
core.c
core.h
debugfs.c
debugfs.h
ethtool.c
ibss.c
Kconfig	cfg80211: select CONFIG_CRC32	2021-01-19 18:27:28 +01:00
lib80211_crypt_ccmp.c
lib80211_crypt_tkip.c
lib80211_crypt_wep.c
lib80211.c
Makefile	cfg80211: make certificate generation more robust	2021-06-23 14:42:53 +02:00
mesh.c
mlme.c
nl80211.c	nl80211: fix potential leak of ACL params	2021-04-14 08:42:02 +02:00
nl80211.h
ocb.c
of.c
pmsr.c	cfg80211: avoid double free of PMSR request	2021-06-23 14:42:53 +02:00
radiotap.c
rdev-ops.h
reg.c
reg.h
scan.c	cfg80211: scan: drop entry from hidden_list on overflow	2021-05-14 09:50:00 +02:00
sme.c	cfg80211: remove WARN_ON() in cfg80211_sme_connect	2021-04-14 08:42:13 +02:00
sysfs.c
sysfs.h
trace.c
trace.h
util.c	cfg80211: call cfg80211_leave_ocb when switching away from OCB	2021-06-30 08:47:19 -04:00
wext-compat.c
wext-compat.h
wext-core.c	wext: fix NULL-ptr-dereference with cfg80211's lack of commit()	2021-02-03 23:28:38 +01:00
wext-priv.c
wext-proc.c
wext-sme.c
wext-spy.c