mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-03 21:36:41 +07:00
2213fb142f
When eeh is not enabled, and hotplug two pci devices on the same bus, eeh related sysfs would be added twice for the first added pci device. Since the eeh_dev is not created when eeh is not enabled. This patch adds the check, if eeh is not enabled, eeh sysfs will not be created. After applying this patch, following warnings are reduced: sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:00.0/eeh_mode' sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:00.0/eeh_config_addr' sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:00.0/eeh_pe_config_addr' Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
99 lines
3.3 KiB
C
99 lines
3.3 KiB
C
/*
|
|
* Sysfs entries for PCI Error Recovery for PAPR-compliant platform.
|
|
* Copyright IBM Corporation 2007
|
|
* Copyright Linas Vepstas <linas@austin.ibm.com> 2007
|
|
*
|
|
* All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or (at
|
|
* your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
|
|
* NON INFRINGEMENT. See the GNU General Public License for more
|
|
* details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*
|
|
* Send comments and feedback to Linas Vepstas <linas@austin.ibm.com>
|
|
*/
|
|
#include <linux/pci.h>
|
|
#include <linux/stat.h>
|
|
#include <asm/ppc-pci.h>
|
|
#include <asm/pci-bridge.h>
|
|
|
|
/**
|
|
* EEH_SHOW_ATTR -- Create sysfs entry for eeh statistic
|
|
* @_name: name of file in sysfs directory
|
|
* @_memb: name of member in struct pci_dn to access
|
|
* @_format: printf format for display
|
|
*
|
|
* All of the attributes look very similar, so just
|
|
* auto-gen a cut-n-paste routine to display them.
|
|
*/
|
|
#define EEH_SHOW_ATTR(_name,_memb,_format) \
|
|
static ssize_t eeh_show_##_name(struct device *dev, \
|
|
struct device_attribute *attr, char *buf) \
|
|
{ \
|
|
struct pci_dev *pdev = to_pci_dev(dev); \
|
|
struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev); \
|
|
\
|
|
if (!edev) \
|
|
return 0; \
|
|
\
|
|
return sprintf(buf, _format "\n", edev->_memb); \
|
|
} \
|
|
static DEVICE_ATTR(_name, S_IRUGO, eeh_show_##_name, NULL);
|
|
|
|
EEH_SHOW_ATTR(eeh_mode, mode, "0x%x");
|
|
EEH_SHOW_ATTR(eeh_config_addr, config_addr, "0x%x");
|
|
EEH_SHOW_ATTR(eeh_pe_config_addr, pe_config_addr, "0x%x");
|
|
|
|
void eeh_sysfs_add_device(struct pci_dev *pdev)
|
|
{
|
|
struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev);
|
|
int rc=0;
|
|
|
|
if (!eeh_enabled())
|
|
return;
|
|
|
|
if (edev && (edev->mode & EEH_DEV_SYSFS))
|
|
return;
|
|
|
|
rc += device_create_file(&pdev->dev, &dev_attr_eeh_mode);
|
|
rc += device_create_file(&pdev->dev, &dev_attr_eeh_config_addr);
|
|
rc += device_create_file(&pdev->dev, &dev_attr_eeh_pe_config_addr);
|
|
|
|
if (rc)
|
|
printk(KERN_WARNING "EEH: Unable to create sysfs entries\n");
|
|
else if (edev)
|
|
edev->mode |= EEH_DEV_SYSFS;
|
|
}
|
|
|
|
void eeh_sysfs_remove_device(struct pci_dev *pdev)
|
|
{
|
|
struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev);
|
|
|
|
/*
|
|
* The parent directory might have been removed. We needn't
|
|
* continue for that case.
|
|
*/
|
|
if (!pdev->dev.kobj.sd) {
|
|
if (edev)
|
|
edev->mode &= ~EEH_DEV_SYSFS;
|
|
return;
|
|
}
|
|
|
|
device_remove_file(&pdev->dev, &dev_attr_eeh_mode);
|
|
device_remove_file(&pdev->dev, &dev_attr_eeh_config_addr);
|
|
device_remove_file(&pdev->dev, &dev_attr_eeh_pe_config_addr);
|
|
|
|
if (edev)
|
|
edev->mode &= ~EEH_DEV_SYSFS;
|
|
}
|