Peter Chen cc7f1a3242 usb: cdns3: imx: fix writing read-only memory issue ... commit 92cbdb923c17544684c2dd3be9f8636617898a44 upstream. The memory for struct clk_bulk_data should not be static which will be written during the clk_bulk_get. It fixed below oops when loading cdns3-imx as module. [ 17.272605] Unable to handle kernel write to read-only memory at virtual address ffff8000092a5398 [ 17.299730] Mem abort info: [ 17.313542] unregister ISI channel: mxc_isi.4 [ 17.324076] ESR = 0x9600004f [ 17.344658] EC = 0x25: DABT (current EL), IL = 32 bits [ 17.402055] SET = 0, FnV = 0 [ 17.404321] mxs_phy 5b100000.usbphy: supply phy-3p0 not found, using dummy regulator [ 17.405121] EA = 0, S1PTW = 0 [ 17.405133] Data abort info: [ 17.496231] ISV = 0, ISS = 0x0000004f [ 17.510871] CM = 0, WnR = 1 [ 17.533542] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000081ea5000 [ 17.545709] [ffff8000092a5398] pgd=00000008bffff003, p4d=00000008bffff003, pud=00000008bfffe003, pmd=0000000885041003, pte=006000088513b783 [ 17.573521] Internal error: Oops: 9600004f [#1] PREEMPT SMP [ 17.579113] Modules linked in: usbmisc_imx phy_mxs_usb phy_cadence_salvo cdns3_imx(+) tcpci imx8_media_dev(C) caam error [ 17.590044] CPU: 2 PID: 253 Comm: systemd-udevd Tainted: G C 5.10.0-rc4-04445-g11f3c3a29d0-dirty #19 [ 17.600488] Hardware name: Freescale i.MX8QXP MEK (DT) [ 17.605633] pstate: 20000005 (nzCv daif -PAN -UAO -TCO BTYPE=--) [ 17.611662] pc : __clk_bulk_get+0x48/0x130 [ 17.615786] lr : clk_bulk_get+0x18/0x20 [ 17.619634] sp : ffff80001369b880 [ 17.622953] x29: ffff80001369b880 x28: 0000000000000013 [ 17.628277] x27: 0000000000000100 x26: ffff00080553b100 [ 17.633602] x25: ffff80001229b4d8 x24: 0000000000000000 [ 17.638928] x23: ffff000800665410 x22: 0000000000000005 [ 17.644275] x21: ffff8000092a5390 x20: ffff000800665400 [ 17.649605] x19: ffff000804e6f980 x18: 000000005b110000 [ 17.654946] x17: 0000000000000000 x16: 0000000000000000 [ 17.660274] x15: ffff800011989100 x14: 0000000000000000 [ 17.665599] x13: ffff800013ce1000 x12: ffff800013ca1000 [ 17.670924] x11: 000000005b110000 x10: 0000000000000000 [ 17.676249] x9 : ffff8000106c5a30 x8 : ffff000804e6fa00 [ 17.681575] x7 : 0000000000000000 x6 : 000000000000003f [ 17.686901] x5 : 0000000000000040 x4 : ffff80001369b8b0 [ 17.692228] x3 : ffff8000092a5398 x2 : ffff8000092a5390 [ 17.697574] x1 : ffff8000092a53e8 x0 : 0000000000000004 [ 17.702905] Call trace: [ 17.705366] __clk_bulk_get+0x48/0x130 [ 17.709125] clk_bulk_get+0x18/0x20 [ 17.712620] devm_clk_bulk_get+0x58/0xb8 [ 17.716563] cdns_imx_probe+0x84/0x1f0 [cdns3_imx] [ 17.721363] platform_drv_probe+0x58/0xa8 [ 17.725381] really_probe+0xec/0x4c8 [ 17.728967] driver_probe_device+0xf4/0x160 [ 17.733160] device_driver_attach+0x74/0x80 [ 17.737355] __driver_attach+0xa4/0x170 [ 17.741202] bus_for_each_dev+0x74/0xc8 [ 17.745043] driver_attach+0x28/0x30 [ 17.748620] bus_add_driver+0x144/0x228 [ 17.752462] driver_register+0x68/0x118 [ 17.756308] __platform_driver_register+0x4c/0x58 [ 17.761022] cdns_imx_driver_init+0x24/0x1000 [cdns3_imx] [ 17.766434] do_one_initcall+0x48/0x2c0 [ 17.770280] do_init_module+0x5c/0x220 [ 17.774029] load_module+0x210c/0x2858 [ 17.777784] __do_sys_finit_module+0xb8/0x120 [ 17.782148] __arm64_sys_finit_module+0x24/0x30 [ 17.786691] el0_svc_common.constprop.0+0x70/0x168 [ 17.791497] do_el0_svc+0x28/0x88 [ 17.794822] el0_sync_handler+0x158/0x160 [ 17.798833] el0_sync+0x140/0x180 [ 17.802158] Code: aa0203f5 91002043 8b205021 a90153f3 (f801047f) Cc: <stable@vger.kernel.org> Fixes: 1e056efab9 ("usb: cdns3: add NXP imx8qm glue layer") Signed-off-by: Peter Chen <peter.chen@nxp.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-27 11:55:17 +01:00
..
atm	usb: atm: don't use snprintf() for sysfs attrs	2020-08-25 19:11:18 +02:00
c67x00	Linux 5.9-rc3	2020-08-31 07:11:45 +02:00
cdns3	usb: cdns3: imx: fix writing read-only memory issue	2021-01-27 11:55:17 +01:00
chipidea	usb: chipidea: ci_hdrc_imx: add missing put_device() call in usbmisc_get_init_data()	2021-01-12 20:18:19 +01:00
class	USB: usblp: fix DMA to stack	2021-01-12 20:18:20 +01:00
common	usb: common: usb-conn-gpio: Print error on failure to get VBUS	2020-08-18 12:13:44 +02:00
core	USB: add RESET_RESUME quirk for Snapscan 1212	2020-12-21 13:30:07 +01:00
dwc2	usb: dwc2: Avoid leaving the error_debugfs label unused	2020-10-27 11:33:53 +02:00
dwc3	usb: dwc3: ulpi: Fix USB2.0 HS/FS/LS PHY suspend regression	2021-01-12 20:18:19 +01:00
early	usb: early: ehci-dbgp: convert to readl_poll_timeout_atomic()	2020-09-25 16:29:09 +02:00
gadget	usb: bdc: Make bdc pci driver depend on BROKEN	2021-01-27 11:55:17 +01:00
host	USB: ehci: fix an interrupt calltrace error	2021-01-27 11:55:16 +01:00
image	USB: microtek: use set_host_byte()	2020-09-16 12:42:10 +02:00
isp1760	usb: isp1760-hcd: convert to readl_poll_timeout_atomic()	2020-09-25 16:30:05 +02:00
misc	USB: yurex: fix control-URB timeout handling	2021-01-12 20:18:20 +01:00
mon	USB: mon: Use scnprintf() for avoiding potential buffer overflow	2020-03-12 09:49:28 +01:00
mtu3	usb: mtu3: fix memory corruption in mtu3_debugfs_regset()	2020-12-26 16:02:38 +01:00
musb	Revert "usb: musb: convert to devm_platform_ioremap_resource_byname"	2020-11-13 14:30:23 +01:00
phy	usb: phy: phy-ab8500-usb: fix spello of "function"	2020-10-02 09:57:41 +03:00
renesas_usbhs	usb: Use fallthrough pseudo-keyword	2020-07-10 08:55:17 +02:00
roles	device connection: Remove struct device_connection	2020-09-07 11:14:09 +02:00
serial	USB: serial: keyspan_pda: remove unused variable	2021-01-12 20:18:22 +01:00
storage	usb: uas: Add PNY USB Portable SSD to unusual_uas	2021-01-12 20:18:19 +01:00
typec	usb: typec: Fix copy paste error for NVIDIA alt-mode description	2021-01-19 18:27:27 +01:00
usbip	usb: usbip: vhci_hcd: protect shift size	2021-01-12 20:18:19 +01:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile
usb-skeleton.c	USB: usb-skeleton: drop redundant in-urb check	2019-10-10 12:41:19 +02:00