Paolo Abeni c9f2c1ae12 udp6: fix socket leak on early demux ... When an early demuxed packet reaches __udp6_lib_lookup_skb(), the sk reference is retrieved and used, but the relevant reference count is leaked and the socket destructor is never called. Beyond leaking the sk memory, if there are pending UDP packets in the receive queue, even the related accounted memory is leaked. In the long run, this will cause persistent forward allocation errors and no UDP skbs (both ipv4 and ipv6) will be able to reach the user-space. Fix this by explicitly accessing the early demux reference before the lookup, and properly decreasing the socket reference count after usage. Also drop the skb_steal_sock() in __udp6_lib_lookup_skb(), and the now obsoleted comment about "socket cache". The newly added code is derived from the current ipv4 code for the similar path. v1 -> v2: fixed the __udp6_lib_rcv() return code for resubmission, as suggested by Eric Reported-by: Sam Edwards <CFSworks@gmail.com> Reported-by: Marc Haber <mh+netdev@zugschlus.de> Fixes: 5425077d73 ("net: ipv6: Add early demux handler for UDP unicast") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-07-29 14:19:03 -07:00
..
9p	9p: Implement show_options	2017-07-11 06:08:58 -04:00
bluetooth	Bluetooth: Set LE Default PHY preferences	2017-05-18 13:52:49 +02:00
caif
irda
iucv
netfilter	net: convert nf_bridge_info.use from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
netns	tcp: Namespaceify sysctl_tcp_timestamps	2017-06-08 10:53:29 -04:00
nfc
phonet
sctp	sctp: fix the check for _sctp_walk_params and _sctp_walk_errors	2017-07-27 00:03:12 -07:00
tc_act	net: sched: introduce helper to identify gact trap action	2017-06-06 12:45:23 -04:00
6lowpan.h
act_api.h	net: sched: add termination action to allow goto chain	2017-05-17 15:22:13 -04:00
addrconf.h	net, ipv6: convert inet6_ifaddr.refcnt from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
af_ieee802154.h
af_rxrpc.h	rxrpc: Provide a cmsg to specify the amount of Tx data for a call	2017-06-07 17:15:46 +01:00
af_unix.h	Now that IPC and other changes have landed, enable manual markings for	2017-07-19 08:55:18 -07:00
af_vsock.h
ah.h
arp.h	net: convert neighbour.refcnt from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
atmclip.h
ax25.h	net, ax25: convert ax25_cb.refcount from atomic_t to refcount_t	2017-07-04 22:35:19 +01:00
ax88796.h
bond_3ad.h
bond_alb.h
bond_options.h	bonding: Prevent duplicate userspace notification	2017-05-27 18:51:41 -04:00
bonding.h
busy_poll.h
calipso.h	net, calipso: convert calipso_doi.refcount from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
cfg80211-wext.h
cfg80211.h	nl80211: add authorized flag to ROAM event	2017-06-13 11:04:37 +02:00
cfg802154.h
checksum.h
cipso_ipv4.h	net, ipv4: convert cipso_v4_doi.refcount from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
cls_cgroup.h
codel_impl.h
codel_qdisc.h
codel.h
compat.h
datalink.h
dcbevent.h
dcbnl.h
devlink.h
dn_dev.h
dn_fib.h	net, decnet: convert dn_fib_info.fib_clntref from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
dn_neigh.h
dn_nsp.h
dn_route.h
dn.h
dsa.h	net: dsa: Associate slave network device with CPU port	2017-06-13 16:35:03 -04:00
dsfield.h
dst_cache.h
dst_metadata.h	net: store port/representator id in metadata_dst	2017-06-25 11:42:01 -04:00
dst_ops.h
dst.h	net: add debug atomic_inc_not_zero() in dst_hold()	2017-06-17 22:54:01 -04:00
esp.h
ethoc.h
fib_rules.h	net: convert fib_rule.refcnt from atomic_t to refcount_t	2017-07-01 07:39:09 -07:00
firewire.h
flow_dissector.h	net/flow_dissector: add support for dissection of misc ip header fields	2017-06-04 18:12:23 -04:00
flow.h
flowcache.h
fou.h
fq_impl.h
fq.h
garp.h
gen_stats.h
genetlink.h	genetlink: remove ops_list from genetlink header.	2017-06-05 10:54:55 -04:00
geneve.h
gre.h
gro_cells.h
gtp.h
gue.h
hwbm.h
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h	net, ipv6: convert ifacaddr6.aca_refcnt from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
ife.h
ila.h
inet6_connection_sock.h
inet6_hashtables.h
inet_common.h
inet_connection_sock.h	tcp: ULP infrastructure	2017-06-15 12:12:40 -04:00
inet_ecn.h
inet_frag.h	Merge branch 'for-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu	2017-07-06 08:59:41 -07:00
inet_hashtables.h	net: make sk_ehashfn() static	2017-07-03 03:29:14 -07:00
inet_sock.h
inet_timewait_sock.h
inetpeer.h	net: convert inet_peer.refcnt from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
ip6_checksum.h
ip6_fib.h	net: remove DST_NOCACHE flag	2017-06-17 22:54:01 -04:00
ip6_route.h	net: ipv6: Compare lwstate in detecting duplicate nexthops	2017-07-06 10:48:01 +01:00
ip6_tunnel.h
ip_fib.h	net, ipv4: convert fib_info.fib_clntref from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
ip_tunnels.h
ip_vs.h	ipvs: remove unused function ip_vs_set_state_timeout	2017-04-28 12:00:10 +02:00
ip.h
ipcomp.h
ipconfig.h
ipv6.h	net, ipv6: convert ipv6_txoptions.refcnt from atomic_t to refcount_t	2017-07-04 01:29:03 -07:00
ipx.h	net, ipx: convert ipx_route.refcnt from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
iw_handler.h
kcm.h
l3mdev.h
lapb.h	net, lapb: convert lapb_cb.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h	net, llc: convert llc_sap.refcnt from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
lwtunnel.h	net: add extack arg to lwtunnel build state	2017-05-30 11:55:32 -04:00
mac80211.h	mac80211: manage RX BA session offload without SKB queue	2017-06-08 14:16:29 +02:00
mac802154.h
mip6.h
mld.h
mpls_iptunnel.h
mpls.h
mrp.h
ncsi.h
ndisc.h	net: convert neighbour.refcnt from atomic_t to refcount_t	2017-07-01 07:39:07 -07:00
neighbour.h	Now that IPC and other changes have landed, enable manual markings for	2017-07-19 08:55:18 -07:00
net_namespace.h	Now that IPC and other changes have landed, enable manual markings for	2017-07-19 08:55:18 -07:00
net_ratelimit.h
netevent.h
netlabel.h	net: convert netlbl_lsm_cache.refcount from atomic_t to refcount_t	2017-07-01 07:39:09 -07:00
netlink.h	netlink: correctly document nla_put_u64_64bit()	2017-07-13 09:26:27 -07:00
netprio_cgroup.h
netrom.h	net, netrom: convert nr_node.refcount from atomic_t to refcount_t	2017-07-04 22:35:17 +01:00
nexthop.h
nl802154.h
p8022.h
ping.h
pkt_cls.h	sched: add helper for updating statistics on all actions	2017-05-31 17:58:13 -04:00
pkt_sched.h	net: sched: move tc_classify function to cls_api.c	2017-05-17 15:22:13 -04:00
pptp.h
protocol.h
psample.h
psnap.h
raw.h
rawv6.h
red.h
regulatory.h
request_sock.h	net: convert sock.sk_refcnt from atomic_t to refcount_t	2017-07-01 07:39:08 -07:00
rose.h
route.h	ipv4: call dst_hold_safe() properly	2017-06-17 22:54:00 -04:00
rtnetlink.h	net: add netlink_ext_ack argument to rtnl_link_ops.slave_validate	2017-06-26 23:13:22 -04:00
sch_generic.h	net, sched: convert Qdisc.refcnt from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
scm.h
secure_seq.h	tcp: Namespaceify sysctl_tcp_timestamps	2017-06-08 10:53:29 -04:00
seg6_hmac.h
seg6.h
slhc_vj.h
smc.h
snmp.h
sock_reuseport.h
sock.h	Now that IPC and other changes have landed, enable manual markings for	2017-07-19 08:55:18 -07:00
Space.h
stp.h
strparser.h
switchdev.h	net: switchdev: add SET_SWITCHDEV_OPS helper	2017-07-01 08:51:32 -07:00
tcp_states.h
tcp.h	bpf: Add support for changing congestion control	2017-07-01 16:15:14 -07:00
timewait_sock.h
tls.h	tls: kernel TLS support	2017-06-15 12:12:40 -04:00
transp_v6.h
tso.h
udp_tunnel.h
udp.h	udp6: fix socket leak on early demux	2017-07-29 14:19:03 -07:00
udplite.h	udp: use a separate rx queue for packet reception	2017-05-16 15:41:29 -04:00
vsock_addr.h
vxlan.h	net, vxlan: convert vxlan_sock.refcnt from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
wext.h	dev_ioctl: copy only the smaller struct iwreq for wext	2017-06-14 13:52:44 +02:00
wimax.h
x25.h	net, x25: convert x25_neigh.refcnt from atomic_t to refcount_t	2017-07-04 22:35:18 +01:00
x25device.h
xfrm.h	net, xfrm: convert sec_path.refcnt from atomic_t to refcount_t	2017-07-04 22:35:18 +01:00