Kuninori Morimoto a027e6155b ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init() ... [ Upstream commit a122a116fc6d8fcf2f202dcd185173a54268f239 ] Current rsnd needs to call .prepare (P) for clock settings, .trigger for playback start (S) and stop (E). It should be called as below from SSI point of view. P -> S -> E -> P -> S -> E -> ... But, if you used MIXer, below case might happen (2) 1: P -> S ---> E -> ... 2: P ----> S -> ... (1) (3) P(1) setups clock, but E(2) resets it. and starts playback (3). In such case, it will reports "SSI parent/child should use same rate". rsnd_ssi_master_clk_start() which is the main function at (P) was called from rsnd_ssi_init() (= S) before, but was moved by below patch to rsnd_soc_dai_prepare() (= P) to avoid using clk_get_rate() which shouldn't be used under atomic context. commit 4d230d1271 ("ASoC: rsnd: fixup not to call clk_get/set under non-atomic") Because of above patch, rsnd_ssi_master_clk_start() is now called at (P) which is for non atomic context. But (P) is assuming that spin lock is *not* used. One issue now is rsnd_ssi_master_clk_start() is checking ssi->xxx which should be protected by spin lock. After above patch, adg.c had below patch for other reasons. commit 06e8f5c842 ("ASoC: rsnd: don't call clk_get_rate() under atomic context") clk_get_rate() is used at probe() timing by this patch. In other words, rsnd_ssi_master_clk_start() is no longer using clk_get_rate() any more. This means we can call it from rsnd_ssi_init() (= S) again which is protected by spin lock. This patch re-move it to under spin lock, and solves 1. checking ssi->xxx without spin lock issue. 2. clk setting / device start / device stop race condition. Reported-by: Linh Phung T. Y. <linh.phung.jy@renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Link: https://lore.kernel.org/r/875z0x1jt5.wl-kuninori.morimoto.gx@renesas.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-19 10:12:56 +02:00
..
ac97	ALSA: ac97: (cosmetic) align argument names	2020-09-03 09:27:27 +02:00
aoa	ALSA: aoa: i2sbus: use DECLARE_COMPLETION_ONSTACK() macro	2020-09-03 09:26:52 +02:00
arm
atmel	ALSA: atmel: ac97: clarify operator precedence	2020-09-03 09:27:34 +02:00
core	ALSA: core: remove redundant spin_lock pair in snd_card_disconnect	2021-05-14 09:50:31 +02:00
drivers	ALSA: aloop: Fix initialization of controls	2021-04-14 08:41:56 +02:00
firewire	ALSA: bebob: enable to deliver MIDI messages for multiple ports	2021-05-19 10:12:53 +02:00
hda	ALSA: hda: ignore invalid NHLT table	2021-03-30 14:31:48 +02:00
i2c
isa	ALSA: sb: Fix two use after free in snd_sb_qsound_build	2021-05-11 14:47:32 +02:00
mips	hal2: convert to dma_alloc_noncoherent	2020-09-25 06:20:44 +02:00
oss	ALSA: Use fallthrough pseudo-keyword	2020-07-09 13:01:29 +02:00
parisc
pci	ALSA: rme9652: don't disable if not enabled	2021-05-19 10:12:53 +02:00
pcmcia	ALSA: Use fallthrough pseudo-keyword	2020-07-09 13:01:29 +02:00
ppc	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
sh
soc	ASoC: rsnd: call rsnd_ssi_master_clk_start() from rsnd_ssi_init()	2021-05-19 10:12:56 +02:00
sparc	ALSA: sparc: dbri: fix repeated word 'the'	2020-10-17 09:58:35 +02:00
spi
synth
usb	ALSA: usb: midi: don't return -ENOMEM when usb_urb_ep_type_check fails	2021-05-14 09:50:40 +02:00
x86	ALSA: hda: use consistent HDAudio spelling in comments/docs	2020-09-02 19:31:32 +02:00
xen	ALSA: xen: Remove superfluous fall through comments	2020-07-09 19:10:37 +02:00
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c