mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-19 19:17:48 +07:00
b28c69dd3d
If output is NULL it is not permissable to dereference it. So we should leave the respective function in this case. The inconsistency was indicated by cppcheck. No actual NULL pointer dereference was observed. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Message-id: 1471813566-5324-1-git-send-email-xypron.glpk@gmx.de Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
239 lines
7.2 KiB
C
239 lines
7.2 KiB
C
/*
|
|
* Copyright (C) 2015 Red Hat, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining
|
|
* a copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sublicense, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial
|
|
* portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
* IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
|
|
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
|
|
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
|
|
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "virtgpu_drv.h"
|
|
#include <drm/drm_plane_helper.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
|
|
static const uint32_t virtio_gpu_formats[] = {
|
|
DRM_FORMAT_XRGB8888,
|
|
DRM_FORMAT_ARGB8888,
|
|
DRM_FORMAT_BGRX8888,
|
|
DRM_FORMAT_BGRA8888,
|
|
DRM_FORMAT_RGBX8888,
|
|
DRM_FORMAT_RGBA8888,
|
|
DRM_FORMAT_XBGR8888,
|
|
DRM_FORMAT_ABGR8888,
|
|
};
|
|
|
|
static const uint32_t virtio_gpu_cursor_formats[] = {
|
|
DRM_FORMAT_ARGB8888,
|
|
};
|
|
|
|
static void virtio_gpu_plane_destroy(struct drm_plane *plane)
|
|
{
|
|
kfree(plane);
|
|
}
|
|
|
|
static const struct drm_plane_funcs virtio_gpu_plane_funcs = {
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
.destroy = virtio_gpu_plane_destroy,
|
|
.reset = drm_atomic_helper_plane_reset,
|
|
.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
|
|
};
|
|
|
|
static int virtio_gpu_plane_atomic_check(struct drm_plane *plane,
|
|
struct drm_plane_state *state)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void virtio_gpu_primary_plane_update(struct drm_plane *plane,
|
|
struct drm_plane_state *old_state)
|
|
{
|
|
struct drm_device *dev = plane->dev;
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_output *output = NULL;
|
|
struct virtio_gpu_framebuffer *vgfb;
|
|
struct virtio_gpu_object *bo;
|
|
uint32_t handle;
|
|
|
|
if (plane->state->crtc)
|
|
output = drm_crtc_to_virtio_gpu_output(plane->state->crtc);
|
|
if (old_state->crtc)
|
|
output = drm_crtc_to_virtio_gpu_output(old_state->crtc);
|
|
if (WARN_ON(!output))
|
|
return;
|
|
|
|
if (plane->state->fb) {
|
|
vgfb = to_virtio_gpu_framebuffer(plane->state->fb);
|
|
bo = gem_to_virtio_gpu_obj(vgfb->obj);
|
|
handle = bo->hw_res_handle;
|
|
if (bo->dumb) {
|
|
virtio_gpu_cmd_transfer_to_host_2d
|
|
(vgdev, handle, 0,
|
|
cpu_to_le32(plane->state->src_w >> 16),
|
|
cpu_to_le32(plane->state->src_h >> 16),
|
|
plane->state->src_x >> 16,
|
|
plane->state->src_y >> 16, NULL);
|
|
}
|
|
} else {
|
|
handle = 0;
|
|
}
|
|
|
|
DRM_DEBUG("handle 0x%x, crtc %dx%d+%d+%d, src %dx%d+%d+%d\n", handle,
|
|
plane->state->crtc_w, plane->state->crtc_h,
|
|
plane->state->crtc_x, plane->state->crtc_y,
|
|
plane->state->src_w >> 16,
|
|
plane->state->src_h >> 16,
|
|
plane->state->src_x >> 16,
|
|
plane->state->src_y >> 16);
|
|
virtio_gpu_cmd_set_scanout(vgdev, output->index, handle,
|
|
plane->state->src_w >> 16,
|
|
plane->state->src_h >> 16,
|
|
plane->state->src_x >> 16,
|
|
plane->state->src_y >> 16);
|
|
virtio_gpu_cmd_resource_flush(vgdev, handle,
|
|
plane->state->src_x >> 16,
|
|
plane->state->src_y >> 16,
|
|
plane->state->src_w >> 16,
|
|
plane->state->src_h >> 16);
|
|
}
|
|
|
|
static void virtio_gpu_cursor_plane_update(struct drm_plane *plane,
|
|
struct drm_plane_state *old_state)
|
|
{
|
|
struct drm_device *dev = plane->dev;
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_output *output = NULL;
|
|
struct virtio_gpu_framebuffer *vgfb;
|
|
struct virtio_gpu_fence *fence = NULL;
|
|
struct virtio_gpu_object *bo = NULL;
|
|
uint32_t handle;
|
|
int ret = 0;
|
|
|
|
if (plane->state->crtc)
|
|
output = drm_crtc_to_virtio_gpu_output(plane->state->crtc);
|
|
if (old_state->crtc)
|
|
output = drm_crtc_to_virtio_gpu_output(old_state->crtc);
|
|
if (WARN_ON(!output))
|
|
return;
|
|
|
|
if (plane->state->fb) {
|
|
vgfb = to_virtio_gpu_framebuffer(plane->state->fb);
|
|
bo = gem_to_virtio_gpu_obj(vgfb->obj);
|
|
handle = bo->hw_res_handle;
|
|
} else {
|
|
handle = 0;
|
|
}
|
|
|
|
if (bo && bo->dumb && (plane->state->fb != old_state->fb)) {
|
|
/* new cursor -- update & wait */
|
|
virtio_gpu_cmd_transfer_to_host_2d
|
|
(vgdev, handle, 0,
|
|
cpu_to_le32(plane->state->crtc_w),
|
|
cpu_to_le32(plane->state->crtc_h),
|
|
0, 0, &fence);
|
|
ret = virtio_gpu_object_reserve(bo, false);
|
|
if (!ret) {
|
|
reservation_object_add_excl_fence(bo->tbo.resv,
|
|
&fence->f);
|
|
fence_put(&fence->f);
|
|
fence = NULL;
|
|
virtio_gpu_object_unreserve(bo);
|
|
virtio_gpu_object_wait(bo, false);
|
|
}
|
|
}
|
|
|
|
if (plane->state->fb != old_state->fb) {
|
|
DRM_DEBUG("update, handle %d, pos +%d+%d, hot %d,%d\n", handle,
|
|
plane->state->crtc_x,
|
|
plane->state->crtc_y,
|
|
plane->state->fb ? plane->state->fb->hot_x : 0,
|
|
plane->state->fb ? plane->state->fb->hot_y : 0);
|
|
output->cursor.hdr.type =
|
|
cpu_to_le32(VIRTIO_GPU_CMD_UPDATE_CURSOR);
|
|
output->cursor.resource_id = cpu_to_le32(handle);
|
|
if (plane->state->fb) {
|
|
output->cursor.hot_x =
|
|
cpu_to_le32(plane->state->fb->hot_x);
|
|
output->cursor.hot_y =
|
|
cpu_to_le32(plane->state->fb->hot_y);
|
|
} else {
|
|
output->cursor.hot_x = cpu_to_le32(0);
|
|
output->cursor.hot_y = cpu_to_le32(0);
|
|
}
|
|
} else {
|
|
DRM_DEBUG("move +%d+%d\n",
|
|
plane->state->crtc_x,
|
|
plane->state->crtc_y);
|
|
output->cursor.hdr.type =
|
|
cpu_to_le32(VIRTIO_GPU_CMD_MOVE_CURSOR);
|
|
}
|
|
output->cursor.pos.x = cpu_to_le32(plane->state->crtc_x);
|
|
output->cursor.pos.y = cpu_to_le32(plane->state->crtc_y);
|
|
virtio_gpu_cursor_ping(vgdev, output);
|
|
}
|
|
|
|
static const struct drm_plane_helper_funcs virtio_gpu_primary_helper_funcs = {
|
|
.atomic_check = virtio_gpu_plane_atomic_check,
|
|
.atomic_update = virtio_gpu_primary_plane_update,
|
|
};
|
|
|
|
static const struct drm_plane_helper_funcs virtio_gpu_cursor_helper_funcs = {
|
|
.atomic_check = virtio_gpu_plane_atomic_check,
|
|
.atomic_update = virtio_gpu_cursor_plane_update,
|
|
};
|
|
|
|
struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev,
|
|
enum drm_plane_type type,
|
|
int index)
|
|
{
|
|
struct drm_device *dev = vgdev->ddev;
|
|
const struct drm_plane_helper_funcs *funcs;
|
|
struct drm_plane *plane;
|
|
const uint32_t *formats;
|
|
int ret, nformats;
|
|
|
|
plane = kzalloc(sizeof(*plane), GFP_KERNEL);
|
|
if (!plane)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
if (type == DRM_PLANE_TYPE_CURSOR) {
|
|
formats = virtio_gpu_cursor_formats;
|
|
nformats = ARRAY_SIZE(virtio_gpu_cursor_formats);
|
|
funcs = &virtio_gpu_cursor_helper_funcs;
|
|
} else {
|
|
formats = virtio_gpu_formats;
|
|
nformats = ARRAY_SIZE(virtio_gpu_formats);
|
|
funcs = &virtio_gpu_primary_helper_funcs;
|
|
}
|
|
ret = drm_universal_plane_init(dev, plane, 1 << index,
|
|
&virtio_gpu_plane_funcs,
|
|
formats, nformats,
|
|
type, NULL);
|
|
if (ret)
|
|
goto err_plane_init;
|
|
|
|
drm_plane_helper_add(plane, funcs);
|
|
return plane;
|
|
|
|
err_plane_init:
|
|
kfree(plane);
|
|
return ERR_PTR(ret);
|
|
}
|