David Hildenbrand 641fe2e938 drivers/base/memory.c: don't access uninitialized memmaps in soft_offline_page_store() ... Uninitialized memmaps contain garbage and in the worst case trigger kernel BUGs, especially with CONFIG_PAGE_POISONING. They should not get touched. Right now, when trying to soft-offline a PFN that resides on a memory block that was never onlined, one gets a misleading error with CONFIG_PAGE_POISONING: :/# echo 5637144576 > /sys/devices/system/memory/soft_offline_page [ 23.097167] soft offline: 0x150000 page already poisoned But the actual result depends on the garbage in the memmap. soft_offline_page() can only work with online pages, it returns -EIO in case of ZONE_DEVICE. Make sure to only forward pages that are online (iow, managed by the buddy) and, therefore, have an initialized memmap. Add a check against pfn_to_online_page() and similarly return -EIO. Link: http://lkml.kernel.org/r/20191010141200.8985-1-david@redhat.com Fixes: f1dd2cd13c ("mm, memory_hotplug: do not associate hotadded memory to zones until online") [visible after d0dc12e86b] Signed-off-by: David Hildenbrand <david@redhat.com> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: <stable@vger.kernel.org> [4.13+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2019-10-19 06:32:31 -04:00
..
firmware_loader
power
regmap
test
arch_topology.c
attribute_container.c
base.h
bus.c
cacheinfo.c
class.c
component.c
container.c
core.c	cpufreq: Avoid cpufreq_suspend() deadlock on system shutdown	2019-10-10 11:11:17 +02:00
cpu.c
dd.c
devcon.c
devcoredump.c
devres.c
devtmpfs.c
driver.c
firmware.c
hypervisor.c
init.c
isa.c
Kconfig
Makefile
map.c
memory.c	drivers/base/memory.c: don't access uninitialized memmaps in soft_offline_page_store()	2019-10-19 06:32:31 -04:00
module.c
node.c	mm,thp: stats for file backed THP	2019-09-24 15:54:11 -07:00
pinctrl.c
platform-msi.c
platform.c	driver core: platform: Add platform_get_irq_byname_optional()	2019-10-07 12:52:44 +02:00
property.c
soc.c
swnode.c
syscore.c
topology.c
transport_class.c