mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-28 11:18:45 +07:00
a25b988ff8
Most bridge drivers create a DRM connector to model the connector at the output of the bridge. This model is historical and has worked pretty well so far, but causes several issues: - It prevents supporting more complex display pipelines where DRM connector operations are split over multiple components. For instance a pipeline with a bridge connected to the DDC signals to read EDID data, and another one connected to the HPD signal to detect connection and disconnection, will not be possible to support through this model. - It requires every bridge driver to implement similar connector handling code, resulting in code duplication. - It assumes that a bridge will either be wired to a connector or to another bridge, but doesn't support bridges that can be used in both positions very well (although there is some ad-hoc support for this in the analogix_dp bridge driver). In order to solve these issues, ownership of the connector should be moved to the display controller driver (where it can be implemented using helpers provided by the core). Extend the bridge API to allow disabling connector creation in bridge drivers as a first step towards the new model. The new flags argument to the bridge .attach() operation allows instructing the bridge driver to skip creating a connector. Unconditionally set the new flags argument to 0 for now to keep the existing behaviour, and modify all existing bridge drivers to return an error when connector creation is not requested as they don't support this feature yet. The change is based on the following semantic patch, with manual review and edits. @ rule1 @ identifier funcs; identifier fn; @@ struct drm_bridge_funcs funcs = { ..., .attach = fn }; @ depends on rule1 @ identifier rule1.fn; identifier bridge; statement S, S1; @@ int fn( struct drm_bridge *bridge + , enum drm_bridge_attach_flags flags ) { ... when != S + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { + DRM_ERROR("Fix bridge driver to make connector optional!"); + return -EINVAL; + } + S1 ... } @ depends on rule1 @ identifier rule1.fn; identifier bridge, flags; expression E1, E2, E3; @@ int fn( struct drm_bridge *bridge, enum drm_bridge_attach_flags flags ) { <... drm_bridge_attach(E1, E2, E3 + , flags ) ...> } @@ expression E1, E2, E3; @@ drm_bridge_attach(E1, E2, E3 + , 0 ) Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Acked-by: Sam Ravnborg <sam@ravnborg.org> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200226112514.12455-10-laurent.pinchart@ideasonboard.com
271 lines
6.6 KiB
C
271 lines
6.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) 2015 Free Electrons
|
|
* Copyright (C) 2015 NextThing Co
|
|
*
|
|
* Maxime Ripard <maxime.ripard@free-electrons.com>
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
#include <drm/drm_of.h>
|
|
#include <drm/drm_panel.h>
|
|
#include <drm/drm_print.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
#include "sun4i_crtc.h"
|
|
#include "sun4i_tcon.h"
|
|
#include "sun4i_rgb.h"
|
|
|
|
struct sun4i_rgb {
|
|
struct drm_connector connector;
|
|
struct drm_encoder encoder;
|
|
|
|
struct sun4i_tcon *tcon;
|
|
struct drm_panel *panel;
|
|
struct drm_bridge *bridge;
|
|
};
|
|
|
|
static inline struct sun4i_rgb *
|
|
drm_connector_to_sun4i_rgb(struct drm_connector *connector)
|
|
{
|
|
return container_of(connector, struct sun4i_rgb,
|
|
connector);
|
|
}
|
|
|
|
static inline struct sun4i_rgb *
|
|
drm_encoder_to_sun4i_rgb(struct drm_encoder *encoder)
|
|
{
|
|
return container_of(encoder, struct sun4i_rgb,
|
|
encoder);
|
|
}
|
|
|
|
static int sun4i_rgb_get_modes(struct drm_connector *connector)
|
|
{
|
|
struct sun4i_rgb *rgb =
|
|
drm_connector_to_sun4i_rgb(connector);
|
|
|
|
return drm_panel_get_modes(rgb->panel, connector);
|
|
}
|
|
|
|
/*
|
|
* VESA DMT defines a tolerance of 0.5% on the pixel clock, while the
|
|
* CVT spec reuses that tolerance in its examples, so it looks to be a
|
|
* good default tolerance for the EDID-based modes. Define it to 5 per
|
|
* mille to avoid floating point operations.
|
|
*/
|
|
#define SUN4I_RGB_DOTCLOCK_TOLERANCE_PER_MILLE 5
|
|
|
|
static enum drm_mode_status sun4i_rgb_mode_valid(struct drm_encoder *crtc,
|
|
const struct drm_display_mode *mode)
|
|
{
|
|
struct sun4i_rgb *rgb = drm_encoder_to_sun4i_rgb(crtc);
|
|
struct sun4i_tcon *tcon = rgb->tcon;
|
|
u32 hsync = mode->hsync_end - mode->hsync_start;
|
|
u32 vsync = mode->vsync_end - mode->vsync_start;
|
|
unsigned long long rate = mode->clock * 1000;
|
|
unsigned long long lowest, highest;
|
|
unsigned long long rounded_rate;
|
|
|
|
DRM_DEBUG_DRIVER("Validating modes...\n");
|
|
|
|
if (hsync < 1)
|
|
return MODE_HSYNC_NARROW;
|
|
|
|
if (hsync > 0x3ff)
|
|
return MODE_HSYNC_WIDE;
|
|
|
|
if ((mode->hdisplay < 1) || (mode->htotal < 1))
|
|
return MODE_H_ILLEGAL;
|
|
|
|
if ((mode->hdisplay > 0x7ff) || (mode->htotal > 0xfff))
|
|
return MODE_BAD_HVALUE;
|
|
|
|
DRM_DEBUG_DRIVER("Horizontal parameters OK\n");
|
|
|
|
if (vsync < 1)
|
|
return MODE_VSYNC_NARROW;
|
|
|
|
if (vsync > 0x3ff)
|
|
return MODE_VSYNC_WIDE;
|
|
|
|
if ((mode->vdisplay < 1) || (mode->vtotal < 1))
|
|
return MODE_V_ILLEGAL;
|
|
|
|
if ((mode->vdisplay > 0x7ff) || (mode->vtotal > 0xfff))
|
|
return MODE_BAD_VVALUE;
|
|
|
|
DRM_DEBUG_DRIVER("Vertical parameters OK\n");
|
|
|
|
/*
|
|
* TODO: We should use the struct display_timing if available
|
|
* and / or trying to stretch the timings within that
|
|
* tolerancy to take care of panels that we wouldn't be able
|
|
* to have a exact match for.
|
|
*/
|
|
if (rgb->panel) {
|
|
DRM_DEBUG_DRIVER("RGB panel used, skipping clock rate checks");
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* That shouldn't ever happen unless something is really wrong, but it
|
|
* doesn't harm to check.
|
|
*/
|
|
if (!rgb->bridge)
|
|
goto out;
|
|
|
|
tcon->dclk_min_div = 6;
|
|
tcon->dclk_max_div = 127;
|
|
rounded_rate = clk_round_rate(tcon->dclk, rate);
|
|
|
|
lowest = rate * (1000 - SUN4I_RGB_DOTCLOCK_TOLERANCE_PER_MILLE);
|
|
do_div(lowest, 1000);
|
|
if (rounded_rate < lowest)
|
|
return MODE_CLOCK_LOW;
|
|
|
|
highest = rate * (1000 + SUN4I_RGB_DOTCLOCK_TOLERANCE_PER_MILLE);
|
|
do_div(highest, 1000);
|
|
if (rounded_rate > highest)
|
|
return MODE_CLOCK_HIGH;
|
|
|
|
out:
|
|
DRM_DEBUG_DRIVER("Clock rate OK\n");
|
|
|
|
return MODE_OK;
|
|
}
|
|
|
|
static struct drm_connector_helper_funcs sun4i_rgb_con_helper_funcs = {
|
|
.get_modes = sun4i_rgb_get_modes,
|
|
};
|
|
|
|
static void
|
|
sun4i_rgb_connector_destroy(struct drm_connector *connector)
|
|
{
|
|
struct sun4i_rgb *rgb = drm_connector_to_sun4i_rgb(connector);
|
|
|
|
drm_panel_detach(rgb->panel);
|
|
drm_connector_cleanup(connector);
|
|
}
|
|
|
|
static const struct drm_connector_funcs sun4i_rgb_con_funcs = {
|
|
.fill_modes = drm_helper_probe_single_connector_modes,
|
|
.destroy = sun4i_rgb_connector_destroy,
|
|
.reset = drm_atomic_helper_connector_reset,
|
|
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
|
|
};
|
|
|
|
static void sun4i_rgb_encoder_enable(struct drm_encoder *encoder)
|
|
{
|
|
struct sun4i_rgb *rgb = drm_encoder_to_sun4i_rgb(encoder);
|
|
|
|
DRM_DEBUG_DRIVER("Enabling RGB output\n");
|
|
|
|
if (rgb->panel) {
|
|
drm_panel_prepare(rgb->panel);
|
|
drm_panel_enable(rgb->panel);
|
|
}
|
|
}
|
|
|
|
static void sun4i_rgb_encoder_disable(struct drm_encoder *encoder)
|
|
{
|
|
struct sun4i_rgb *rgb = drm_encoder_to_sun4i_rgb(encoder);
|
|
|
|
DRM_DEBUG_DRIVER("Disabling RGB output\n");
|
|
|
|
if (rgb->panel) {
|
|
drm_panel_disable(rgb->panel);
|
|
drm_panel_unprepare(rgb->panel);
|
|
}
|
|
}
|
|
|
|
static struct drm_encoder_helper_funcs sun4i_rgb_enc_helper_funcs = {
|
|
.disable = sun4i_rgb_encoder_disable,
|
|
.enable = sun4i_rgb_encoder_enable,
|
|
.mode_valid = sun4i_rgb_mode_valid,
|
|
};
|
|
|
|
static void sun4i_rgb_enc_destroy(struct drm_encoder *encoder)
|
|
{
|
|
drm_encoder_cleanup(encoder);
|
|
}
|
|
|
|
static struct drm_encoder_funcs sun4i_rgb_enc_funcs = {
|
|
.destroy = sun4i_rgb_enc_destroy,
|
|
};
|
|
|
|
int sun4i_rgb_init(struct drm_device *drm, struct sun4i_tcon *tcon)
|
|
{
|
|
struct drm_encoder *encoder;
|
|
struct sun4i_rgb *rgb;
|
|
int ret;
|
|
|
|
rgb = devm_kzalloc(drm->dev, sizeof(*rgb), GFP_KERNEL);
|
|
if (!rgb)
|
|
return -ENOMEM;
|
|
rgb->tcon = tcon;
|
|
encoder = &rgb->encoder;
|
|
|
|
ret = drm_of_find_panel_or_bridge(tcon->dev->of_node, 1, 0,
|
|
&rgb->panel, &rgb->bridge);
|
|
if (ret) {
|
|
dev_info(drm->dev, "No panel or bridge found... RGB output disabled\n");
|
|
return 0;
|
|
}
|
|
|
|
drm_encoder_helper_add(&rgb->encoder,
|
|
&sun4i_rgb_enc_helper_funcs);
|
|
ret = drm_encoder_init(drm,
|
|
&rgb->encoder,
|
|
&sun4i_rgb_enc_funcs,
|
|
DRM_MODE_ENCODER_NONE,
|
|
NULL);
|
|
if (ret) {
|
|
dev_err(drm->dev, "Couldn't initialise the rgb encoder\n");
|
|
goto err_out;
|
|
}
|
|
|
|
/* The RGB encoder can only work with the TCON channel 0 */
|
|
rgb->encoder.possible_crtcs = drm_crtc_mask(&tcon->crtc->crtc);
|
|
|
|
if (rgb->panel) {
|
|
drm_connector_helper_add(&rgb->connector,
|
|
&sun4i_rgb_con_helper_funcs);
|
|
ret = drm_connector_init(drm, &rgb->connector,
|
|
&sun4i_rgb_con_funcs,
|
|
DRM_MODE_CONNECTOR_Unknown);
|
|
if (ret) {
|
|
dev_err(drm->dev, "Couldn't initialise the rgb connector\n");
|
|
goto err_cleanup_connector;
|
|
}
|
|
|
|
drm_connector_attach_encoder(&rgb->connector,
|
|
&rgb->encoder);
|
|
|
|
ret = drm_panel_attach(rgb->panel, &rgb->connector);
|
|
if (ret) {
|
|
dev_err(drm->dev, "Couldn't attach our panel\n");
|
|
goto err_cleanup_connector;
|
|
}
|
|
}
|
|
|
|
if (rgb->bridge) {
|
|
ret = drm_bridge_attach(encoder, rgb->bridge, NULL, 0);
|
|
if (ret) {
|
|
dev_err(drm->dev, "Couldn't attach our bridge\n");
|
|
goto err_cleanup_connector;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_cleanup_connector:
|
|
drm_encoder_cleanup(&rgb->encoder);
|
|
err_out:
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(sun4i_rgb_init);
|