Dan Carpenter c015295b28 ocfs2: fix snprintf() checking ... [ Upstream commit 54e948c60cc843b6e84dc44496edc91f51d2a28e ] The snprintf() function returns the number of bytes which would have been printed if the buffer was large enough. In other words it can return ">= remain" but this code assumes it returns "== remain". The run time impact of this bug is not very severe. The next iteration through the loop would trigger a WARN() when we pass a negative limit to snprintf(). We would then return success instead of -E2BIG. The kernel implementation of snprintf() will never return negatives so there is no need to check and I have deleted that dead code. Link: https://lkml.kernel.org/r/20210511135350.GV1955@kadam Fixes: a860f6eb4c ("ocfs2: sysfile interfaces for online file check") Fixes: 74ae4e104d ("ocfs2: Create stack glue sysfs files.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Changwei Ge <gechangwei@live.cn> Cc: Gang He <ghe@suse.com> Cc: Jun Piao <piaojun@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-07-14 16:56:13 +02:00
..
cluster	ocfs2: fix a use after free on error	2021-03-04 11:38:18 +01:00
dlm	ocfs2: add missing annotation for dlm_empty_lockres()	2020-06-02 10:59:05 -07:00
dlmfs	dlmfs: clean up dlmfs_file_{read,write}() a bit	2020-06-14 19:04:42 -04:00
acl.c	ocfs2: fix remounting needed after setfacl command	2020-08-07 11:33:21 -07:00
acl.h
alloc.c	ocfs2: fix potential soft lockup during fstrim	2020-10-13 18:38:27 -07:00
alloc.h
aops.c	ocfs2: fix deadlock between setattr and dio_end_io_write	2021-04-14 08:41:58 +02:00
aops.h
blockcheck.c	ocfs2: replace HTTP links with HTTPS ones	2020-08-07 11:33:22 -07:00
blockcheck.h
buffer_head_io.c
buffer_head_io.h
dcache.c
dcache.h
dir.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
dir.h
dlmglue.c	ocfs2: fix unbalanced locking	2020-08-07 11:33:22 -07:00
dlmglue.h
export.c
export.h
extent_map.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
extent_map.h
file.c	ocfs2: fix data corruption by fallocate	2021-06-10 13:39:26 +02:00
file.h
filecheck.c	ocfs2: fix snprintf() checking	2021-07-14 16:56:13 +02:00
filecheck.h
heartbeat.c
heartbeat.h
inode.c
inode.h
ioctl.c
ioctl.h
journal.c	jbd2: rename j_maxlen to j_total_len and add jbd2_journal_max_txn_bufs	2020-11-06 23:01:02 -05:00
journal.h
Kconfig	ocfs2: replace HTTP links with HTTPS ones	2020-08-07 11:33:22 -07:00
localalloc.c	ocfs2: delete repeated words in comments	2020-10-13 18:38:27 -07:00
localalloc.h
locks.c
locks.h
Makefile
mmap.c	ocfs2: fix spelling mistake and grammar	2020-06-10 19:14:18 -07:00
mmap.h
move_extents.c
move_extents.h
namei.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
namei.h
ocfs1_fs_compat.h
ocfs2_fs.h	ocfs2: fix value of OCFS2_INVALID_SLOT	2020-06-26 00:27:37 -07:00
ocfs2_ioctl.h
ocfs2_lockid.h
ocfs2_lockingver.h
ocfs2_trace.h
ocfs2.h	ocfs2: change slot number type s16 to u16	2020-08-07 11:33:21 -07:00
quota_global.c
quota_local.c
quota.h
refcounttree.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
refcounttree.h
reservations.c
reservations.h
resize.c
resize.h
slot_map.c	ocfs2: mount shared volume without ha stack	2020-06-02 10:59:05 -07:00
slot_map.h
stack_o2cb.c
stack_user.c
stackglue.c	ocfs2: fix snprintf() checking	2021-07-14 16:56:13 +02:00
stackglue.h
suballoc.c	ocfs2: change slot number type s16 to u16	2020-08-07 11:33:21 -07:00
suballoc.h	ocfs2: suballoc.h: delete a duplicated word	2020-08-07 11:33:21 -07:00
super.c	ocfs2: initialize ip_next_orphan	2020-11-14 11:26:04 -08:00
super.h
symlink.c
symlink.h
sysfile.c
sysfile.h
uptodate.c
uptodate.h
xattr.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
xattr.h