linux_dsm_epyc7002/drivers/net/ethernet/hisilicon
Gustavo A. R. Silva c5d6cf903f net: hns: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-02-26 16:43:09 -08:00
..
hns net: hns: Replace zero-length array with flexible-array member 2020-02-26 16:43:09 -08:00
hns3 net: hns3: remove redundant initialization of pointer 'client' 2020-02-24 11:21:19 -08:00
hip04_eth.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2019-12-22 15:15:05 -08:00
hisi_femac.c net: convert suitable drivers to use phy_do_ioctl_running 2020-01-23 10:49:30 +01:00
hix5hd2_gmac.c netdev: pass the stuck queue to the timeout handler 2019-12-12 21:38:57 -08:00
hns_mdio.c
Kconfig
Makefile