mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-18 16:46:45 +07:00
0c65b2b90d
Before this change of_get_phy_mode() returned an enum, phy_interface_t. On error, -ENODEV etc, is returned. If the result of the function is stored in a variable of type phy_interface_t, and the compiler has decided to represent this as an unsigned int, comparision with -ENODEV etc, is a signed vs unsigned comparision. Fix this problem by changing the API. Make the function return an error, or 0 on success, and pass a pointer, of type phy_interface_t, where the phy mode should be stored. v2: Return with *interface set to PHY_INTERFACE_MODE_NA on error. Add error checks to all users of of_get_phy_mode() Fixup a few reverse christmas tree errors Fixup a few slightly malformed reverse christmas trees v3: Fix 0-day reported errors. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
93 lines
1.9 KiB
C
93 lines
1.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/**
|
|
* emac_arc.c - ARC EMAC specific glue layer
|
|
*
|
|
* Copyright (C) 2014 Romain Perier
|
|
*
|
|
* Romain Perier <romain.perier@gmail.com>
|
|
*/
|
|
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of_net.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include "emac.h"
|
|
|
|
#define DRV_NAME "emac_arc"
|
|
#define DRV_VERSION "1.0"
|
|
|
|
static int emac_arc_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct arc_emac_priv *priv;
|
|
phy_interface_t interface;
|
|
struct net_device *ndev;
|
|
int err;
|
|
|
|
if (!dev->of_node)
|
|
return -ENODEV;
|
|
|
|
ndev = alloc_etherdev(sizeof(struct arc_emac_priv));
|
|
if (!ndev)
|
|
return -ENOMEM;
|
|
platform_set_drvdata(pdev, ndev);
|
|
SET_NETDEV_DEV(ndev, dev);
|
|
|
|
priv = netdev_priv(ndev);
|
|
priv->drv_name = DRV_NAME;
|
|
priv->drv_version = DRV_VERSION;
|
|
|
|
err = of_get_phy_mode(dev->of_node, &interface);
|
|
if (err) {
|
|
if (err == -ENODEV)
|
|
interface = PHY_INTERFACE_MODE_MII;
|
|
else
|
|
goto out_netdev;
|
|
}
|
|
|
|
priv->clk = devm_clk_get(dev, "hclk");
|
|
if (IS_ERR(priv->clk)) {
|
|
dev_err(dev, "failed to retrieve host clock from device tree\n");
|
|
err = -EINVAL;
|
|
goto out_netdev;
|
|
}
|
|
|
|
err = arc_emac_probe(ndev, interface);
|
|
out_netdev:
|
|
if (err)
|
|
free_netdev(ndev);
|
|
return err;
|
|
}
|
|
|
|
static int emac_arc_remove(struct platform_device *pdev)
|
|
{
|
|
struct net_device *ndev = platform_get_drvdata(pdev);
|
|
int err;
|
|
|
|
err = arc_emac_remove(ndev);
|
|
free_netdev(ndev);
|
|
return err;
|
|
}
|
|
|
|
static const struct of_device_id emac_arc_dt_ids[] = {
|
|
{ .compatible = "snps,arc-emac" },
|
|
{ /* Sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, emac_arc_dt_ids);
|
|
|
|
static struct platform_driver emac_arc_driver = {
|
|
.probe = emac_arc_probe,
|
|
.remove = emac_arc_remove,
|
|
.driver = {
|
|
.name = DRV_NAME,
|
|
.of_match_table = emac_arc_dt_ids,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(emac_arc_driver);
|
|
|
|
MODULE_AUTHOR("Romain Perier <romain.perier@gmail.com>");
|
|
MODULE_DESCRIPTION("ARC EMAC platform driver");
|
|
MODULE_LICENSE("GPL");
|