mirror of
https://github.com/AuxXxilium/linux_dsm_epyc7002.git
synced 2024-12-23 00:59:39 +07:00
1250c3048c
Our ABI for write() uses a s32 for FDs and a u32 for IDRs, but internally we ended up implicitly casting these ABI values into an 'int'. For ioctl() we use a s64 for FDs and a u64 for IDRs, again casting to an int. The various casts to int are all missing range checks which can cause userspace values that should be considered invalid to be accepted. Fix this by making the generic lookup routine accept a s64, which does not truncate the write API's u32/s32 or the ioctl API's s64. Then push the detailed range checking down to the actual type implementations to be shared by both interfaces. Finally, change the copy of the uobj->id to sign extend into a s64, so eg, if we ever wish to return a negative value for a FD it is carried properly. This ensures that userspace values are never weirdly interpreted due to the various trunctations and everything that is really out of range gets an EINVAL. Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
105 lines
2.8 KiB
C
105 lines
2.8 KiB
C
/*
|
|
* Copyright (c) 2018, Mellanox Technologies inc. All rights reserved.
|
|
*
|
|
* This software is available to you under a choice of one of two
|
|
* licenses. You may choose to be licensed under the terms of the GNU
|
|
* General Public License (GPL) Version 2, available from the file
|
|
* COPYING in the main directory of this source tree, or the
|
|
* OpenIB.org BSD license below:
|
|
*
|
|
* Redistribution and use in source and binary forms, with or
|
|
* without modification, are permitted provided that the following
|
|
* conditions are met:
|
|
*
|
|
* - Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer.
|
|
*
|
|
* - Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the following
|
|
* disclaimer in the documentation and/or other materials
|
|
* provided with the distribution.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
|
|
#ifndef RDMA_USER_IOCTL_CMDS_H
|
|
#define RDMA_USER_IOCTL_CMDS_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/ioctl.h>
|
|
|
|
/* Documentation/ioctl/ioctl-number.txt */
|
|
#define RDMA_IOCTL_MAGIC 0x1b
|
|
#define RDMA_VERBS_IOCTL \
|
|
_IOWR(RDMA_IOCTL_MAGIC, 1, struct ib_uverbs_ioctl_hdr)
|
|
|
|
enum {
|
|
/* User input */
|
|
UVERBS_ATTR_F_MANDATORY = 1U << 0,
|
|
/*
|
|
* Valid output bit should be ignored and considered set in
|
|
* mandatory fields. This bit is kernel output.
|
|
*/
|
|
UVERBS_ATTR_F_VALID_OUTPUT = 1U << 1,
|
|
};
|
|
|
|
struct ib_uverbs_attr {
|
|
__u16 attr_id; /* command specific type attribute */
|
|
__u16 len; /* only for pointers */
|
|
__u16 flags; /* combination of UVERBS_ATTR_F_XXXX */
|
|
union {
|
|
struct {
|
|
__u8 elem_id;
|
|
__u8 reserved;
|
|
} enum_data;
|
|
__u16 reserved;
|
|
} attr_data;
|
|
union {
|
|
/* Used by PTR_IN/OUT, ENUM_IN and IDR */
|
|
__aligned_u64 data;
|
|
/* Used by FD_IN and FD_OUT */
|
|
__s64 data_s64;
|
|
};
|
|
};
|
|
|
|
struct ib_uverbs_ioctl_hdr {
|
|
__u16 length;
|
|
__u16 object_id;
|
|
__u16 method_id;
|
|
__u16 num_attrs;
|
|
__aligned_u64 reserved1;
|
|
__u32 driver_id;
|
|
__u32 reserved2;
|
|
struct ib_uverbs_attr attrs[0];
|
|
};
|
|
|
|
enum rdma_driver_id {
|
|
RDMA_DRIVER_UNKNOWN,
|
|
RDMA_DRIVER_MLX5,
|
|
RDMA_DRIVER_MLX4,
|
|
RDMA_DRIVER_CXGB3,
|
|
RDMA_DRIVER_CXGB4,
|
|
RDMA_DRIVER_MTHCA,
|
|
RDMA_DRIVER_BNXT_RE,
|
|
RDMA_DRIVER_OCRDMA,
|
|
RDMA_DRIVER_NES,
|
|
RDMA_DRIVER_I40IW,
|
|
RDMA_DRIVER_VMW_PVRDMA,
|
|
RDMA_DRIVER_QEDR,
|
|
RDMA_DRIVER_HNS,
|
|
RDMA_DRIVER_USNIC,
|
|
RDMA_DRIVER_RXE,
|
|
RDMA_DRIVER_HFI1,
|
|
RDMA_DRIVER_QIB,
|
|
};
|
|
|
|
#endif
|